delta/coreboot/vboot.git, branch release-R73-11647.B

futility: updater: Correct HWID digest when preserving HWID

2019-01-16T13:26:12+00:00

Starting from GBB 1.2, a digest is stored in GBB and must be updated
whenever the HWID string is changed.

In shell script version of updater, the digest is automatically updated
when we do "futility gbb -s --hwid=XXX", but in native updater
implementation we only updated the HWID string and left digest
unchanged, this leaves devices generating wrong PCR1 values.

`cmd_gbb_utility` updates the digest by calling `update_hwid_digest`
using vboot1 structure, so we should introduce a new vboot2 friendly
function, `vb2_change_hwid`, which changes both HWID string and digest
at same time.

Note this has no impact for end user's devices with write protection
enabled. Only changes dogfood units AU results.

BUG=b:122248649
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=none

Change-Id: I6ad2754e6df3c9dd66d71c560a2afc26d14eae33
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1411932
Reviewed-by: Joel Kitching

image_signing: Add cr50 firmware signing support.

2019-01-13T21:52:16+00:00

This introduces a script for signing Cr50 images on the build server.

BRANCH=cr50
TEST=sign_official_build.sh cr50_firmware input tests/devkeys output
BUG=b:74100307

Change-Id: I741b8532980b0a7a0b32fbacff235c38661c7668
Signed-off-by: Vadim Bendebury 
Reviewed-on: https://chromium-review.googlesource.com/1313573
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Mike Frysinger

Add cgpt_find to libvboothost

2019-01-11T21:32:22+00:00

Includes cgpt_find.c and some dependencies in the make rule for
libvboothost so that they can be used by the new C++ clobber-state.

BUG=chromium:884520
TEST=vboothost successfully builds
BRANCH=none

Change-Id: I4cedd7625c8dd905b4391de39477f42ad0dc4902
Reviewed-on: https://chromium-review.googlesource.com/1395811
Commit-Ready: Fletcher Woodruff 
Tested-by: Fletcher Woodruff 
Reviewed-by: Hung-Te Lin 
Reviewed-by: Mike Frysinger

tests: add valid key.versions files for all test keysets

2019-01-10T12:49:52+00:00

Since we enforce this file (with name=) on signers, add it to our test
keysets so we can run unittests against them.

BRANCH=None
BUG=chromium:343499
TEST=precq passes as do new unittests

Change-Id: Ia807df1b8037097064dadc85fcf8796d44ada1af
Reviewed-on: https://chromium-review.googlesource.com/1401143
Commit-Ready: Mike Frysinger 
Tested-by: Mike Frysinger 
Reviewed-by: LaMont Jones

futility: updater: Add '--fast' for quick development

2019-01-03T23:04:14+00:00

When using 'futility update' with Servo Micro or CCD, the programmer is
pretty slow that every invocation of flashrom would take a very long
time, so re-reading firmware contents when writing (flashrom -w) seems
redundant. For such usage, a '--fast' would be helpful that
 - Uses the last read image (image_current) as --diff
 - Add --noverify

BUG=None
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: I1ad57185160a082ea6b5c94b837a4d3ba708b587
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1375495

futility: updater: quirks: Support special released SNOW RO

2018-12-29T00:14:08+00:00

A special Snow RO firmware had been released and would break existing
platform check: 'Google_Snow_Rev4.2695.128.0'. As a result, we want to
bypass platform check in quirk 'daisy_snow_dual_model'.

BUG=chromium:917581
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: I10b0e4c2b8a11faff979b4add368f342a72a6cec
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1390083
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Joel Kitching

image_signing: drop support for old_verity_argv images

2018-12-23T22:46:12+00:00

We changed the verity kernel command line form before R16 was released
and included backwards compat support in the scripts for it.  But all
the devices that were released for these old versions are EOL, and we
don't need to sign images that old anymore, so drop support.

BRANCH=None
BUG=chromium:891015
TEST=precq passes

Change-Id: I5cc37fae19fb4b3db229598aa0f5c69a6f32005a
Reviewed-on: https://chromium-review.googlesource.com/1387904
Commit-Ready: LaMont Jones 
Tested-by: LaMont Jones 
Reviewed-by: Mike Frysinger

futility: updater: Correct output version for Snow

2018-12-19T09:13:04+00:00

In quirk daisy_snow_dual_model, after RO is preserved the actual RO
version should be updated as well from current image. Without this,
reported version may look weird as RO=132, RW=117.

BRANCH=None
BUG=chromium:915013
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility

Change-Id: I1bc6c47a8bd548265fd654dae6ab2a5971d59a1c
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1383631
Reviewed-by: Duncan Laurie

image_signing: fix breakage from dropping

2018-12-15T10:18:44+00:00

Commit 16ceb9625ed13b0da4ae6306f9187b672b9b382f dropped support for old
versions, but it also accidentally dropped the salt= setting which ended
up breaking newer recovery kernels.  Restore that line and drop an unused
var from the old code path.

BRANCH=None
BUG=chromium:891015, chromium:891764
TEST=running `./sign_official_build.sh verify` against the images in crbug.com/891764 works again

Change-Id: I8ae619c9243f9c2638962ae439b9df5090d6c535
Reviewed-on: https://chromium-review.googlesource.com/1376831
Commit-Ready: Mike Frysinger 
Tested-by: Mike Frysinger 
Reviewed-by: David Riley

futility: update: Fix 'smm_store' unit test

2018-12-14T03:28:03+00:00

In CL:1351178 the SMM store file name has been changed to 'smm_store' so we
have to also change test script.

BUG=b:120060878
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility

Change-Id: Idc98517cc46a848bb77335214a11fbc9303590f2
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1375494
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Joel Kitching