<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/coreboot/vboot.git, branch release-R58-9334.B</title>
<subtitle>review.coreboot.org: vboot.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/'/>
<entry>
<title>poppy: center detachable menu text</title>
<updated>2017-03-03T06:02:21+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-02-27T23:58:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=50d1282e856953616d3d3e7be31aa0f9fefd0f9a'/>
<id>50d1282e856953616d3d3e7be31aa0f9fefd0f9a</id>
<content type='text'>
BUG=b:35585623
BRANCH=None
TEST=reboot and make sure menu is centered in fw screen
CQ-DEPEND=CL:447818

Change-Id: I7ce5063adab978338af18ad2befe65107fdea21f
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/447838
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
BUG=b:35585623
BRANCH=None
TEST=reboot and make sure menu is centered in fw screen
CQ-DEPEND=CL:447818

Change-Id: I7ce5063adab978338af18ad2befe65107fdea21f
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/447838
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>poppy: define VbExDisplayGetDimension()</title>
<updated>2017-03-02T17:33:57+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-02-27T23:56:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=97a8aa97c3e73d6a9ce2b305920413a042d74351'/>
<id>97a8aa97c3e73d6a9ce2b305920413a042d74351</id>
<content type='text'>
callback to get rows/cols of display

BUG=b:35585623
BRANCH=None
TEST=make sure code compiles

Change-Id: I276975b2f0eecceb66a30ceaa449ab76a440026d
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/447837
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
callback to get rows/cols of display

BUG=b:35585623
BRANCH=None
TEST=make sure code compiles

Change-Id: I276975b2f0eecceb66a30ceaa449ab76a440026d
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/447837
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>poppy: Disable arrow keys for language switch</title>
<updated>2017-03-02T17:33:57+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-02-15T22:18:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=48a67d3ca74843be77c88f65c9efe0af904b0e70'/>
<id>48a67d3ca74843be77c88f65c9efe0af904b0e70</id>
<content type='text'>
Previously, could use arrow keys to change language
in fw screen.  Disabling this in detachable menu
because will be using menu to switch languages.

BUG=b:35585623
BRANCH=None
TEST=reboot and try to use right/left arrows.  Make
     sure they don't do anything.

Change-Id: Ic720ea4ec9e6b7ae1676fdf60d27e2c74e48f736
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/444945
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, could use arrow keys to change language
in fw screen.  Disabling this in detachable menu
because will be using menu to switch languages.

BUG=b:35585623
BRANCH=None
TEST=reboot and try to use right/left arrows.  Make
     sure they don't do anything.

Change-Id: Ic720ea4ec9e6b7ae1676fdf60d27e2c74e48f736
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/444945
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>poppy: use return key for selection</title>
<updated>2017-03-02T17:33:57+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-02-15T19:06:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=05f00584796fc5aca01f4a4587158d60bded9d49'/>
<id>05f00584796fc5aca01f4a4587158d60bded9d49</id>
<content type='text'>
Replacing right arrow key with return for selection
when keyboard is available because it's more obvious.

BUG=b:35585623
BRANCH=None
TEST=reboot and make sure return selects menu item.

Change-Id: I6b2fbd8cddcd98c49638a6b9d79b47da1ca6545f
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/444944
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replacing right arrow key with return for selection
when keyboard is available because it's more obvious.

BUG=b:35585623
BRANCH=None
TEST=reboot and make sure return selects menu item.

Change-Id: I6b2fbd8cddcd98c49638a6b9d79b47da1ca6545f
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/444944
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>poppy: reinstating fw ctrl functions</title>
<updated>2017-03-02T17:33:57+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-02-14T22:50:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=19a41188cd50b5cdcd6fc50b718031a3d469c025'/>
<id>19a41188cd50b5cdcd6fc50b718031a3d469c025</id>
<content type='text'>
Putting ctrl+D, ctrl+U, ctrl+L shortcuts
back in from the fw screens.

BUG=b:35585623
BRANCH=None
TEST=reboot and try ctrl+D, etc. in fw screen to
     make sure that they have desired effects.

Change-Id: I5ca555658eddabeeea6a2f64794e6839f35d75f7
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/443349
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Putting ctrl+D, ctrl+U, ctrl+L shortcuts
back in from the fw screens.

BUG=b:35585623
BRANCH=None
TEST=reboot and try ctrl+D, etc. in fw screen to
     make sure that they have desired effects.

Change-Id: I5ca555658eddabeeea6a2f64794e6839f35d75f7
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/443349
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot_ui_menu: getting rid of explicit function print</title>
<updated>2017-03-02T17:33:56+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-02-14T22:35:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=e6198e7fc0e9c998fb89ad180fefc9f87340df51'/>
<id>e6198e7fc0e9c998fb89ad180fefc9f87340df51</id>
<content type='text'>
Since we're now using VB2_DEBUG, no need to explicitly
print out __func__ anymore.

BUG=b:35585623
BRANCH=None
TEST=reboot and make sure still see serial output in
     AP console.

Change-Id: Ica524d4e50c61681e466815ffb93d33ceee215aa
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/443348
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since we're now using VB2_DEBUG, no need to explicitly
print out __func__ anymore.

BUG=b:35585623
BRANCH=None
TEST=reboot and make sure still see serial output in
     AP console.

Change-Id: Ica524d4e50c61681e466815ffb93d33ceee215aa
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/443348
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>poppy: replacing dev warn &amp; rec screens with base</title>
<updated>2017-03-02T17:33:56+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-01-27T22:47:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=ea97468d8acd34000ff5a8e3094b56c7f5ffca6a'/>
<id>ea97468d8acd34000ff5a8e3094b56c7f5ffca6a</id>
<content type='text'>
Using new base screen only and leaving center
blank for displaying the detachable menu items.

BUG=b:35585623
BRANCH=None
TEST=reboot and make sure icons don't show up
     in FW screens.

Change-Id: I705dac43441f386ebceb58533fa0e336541fcd3c
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/442692
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Using new base screen only and leaving center
blank for displaying the detachable menu items.

BUG=b:35585623
BRANCH=None
TEST=reboot and make sure icons don't show up
     in FW screens.

Change-Id: I705dac43441f386ebceb58533fa0e336541fcd3c
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/442692
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>poppy: defining base screen enum item</title>
<updated>2017-03-02T02:42:22+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-02-14T18:51:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=b6ce9d095e5a353b5cd6fbe2f21a2e525a1b0745'/>
<id>b6ce9d095e5a353b5cd6fbe2f21a2e525a1b0745</id>
<content type='text'>
BUG=b:35585623
BRANCH=None
TEST=None

Change-Id: I2bb7f3f3cb8fd37f8a7c2253e1ea0cb322d01c9c
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/442691
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
BUG=b:35585623
BRANCH=None
TEST=None

Change-Id: I2bb7f3f3cb8fd37f8a7c2253e1ea0cb322d01c9c
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/442691
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>poppy: Highlight menu selection</title>
<updated>2017-02-27T20:03:18+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-02-13T21:52:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=04b42e96126e6fd79edfbde9b7230bc977c657de'/>
<id>04b42e96126e6fd79edfbde9b7230bc977c657de</id>
<content type='text'>
Reverse foreground/background colors for
highlighted selection.

BUG=chrome-os-partner:61275
BRANCH=None
TEST=reboot and make sure selection is highlighted
CQ-DEPEND=CL:442747

Change-Id: Iaf33cf6140a3ce774a67e3ac7d381d5e05feeddb
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/442690
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reverse foreground/background colors for
highlighted selection.

BUG=chrome-os-partner:61275
BRANCH=None
TEST=reboot and make sure selection is highlighted
CQ-DEPEND=CL:442747

Change-Id: Iaf33cf6140a3ce774a67e3ac7d381d5e05feeddb
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/442690
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>poppy: add highlight param to VbExDisplayText()</title>
<updated>2017-02-27T20:03:18+00:00</updated>
<author>
<name>Shelley Chen</name>
<email>shchen@chromium.org</email>
</author>
<published>2017-02-10T03:52:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=5c4c4678e7127e5153b571e1a2ec55caa2df7146'/>
<id>5c4c4678e7127e5153b571e1a2ec55caa2df7146</id>
<content type='text'>
BUG=chrome-os-partner:61275
BRANCH=None
TEST=None
CQ-DEPEND=CL:442747,CL:442690

Change-Id: I0730b64a1f8bf1f4aeca1be5ee87724d61818b23
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/442689
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
BUG=chrome-os-partner:61275
BRANCH=None
TEST=None
CQ-DEPEND=CL:442747,CL:442690

Change-Id: I0730b64a1f8bf1f4aeca1be5ee87724d61818b23
Signed-off-by: Shelley Chen &lt;shchen@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/442689
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
