delta/coreboot/vboot.git, branch firmware-volteer-13672.148.B

minidiag: Add storage self-test screen

2021-04-28T05:49:15+00:00

Implement the ui for storage self-test.

BUG=b:173364332
TEST=make clean && CC=x86_64-pc-linux-gnu-clang make runtests
BRANCH=none

Cq-Depend: chromium:2848057
Signed-off-by: Chung-Sheng Wu 
Change-Id: Ieb3a24e0bf19f4e62de41cccd1138719dbc65e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848049
Commit-Queue: Chung-Sheng Wu 
Tested-by: Chung-Sheng Wu 
Reviewed-by: Nick Vaccaro

minidiag: Update strings for minidiag v1.1

2021-04-28T05:49:08+00:00

Update strings to meet the UX review.

BRANCH=none
BUG=b:183351700
TEST=none

Cq-Depend: chromium:2777880
Signed-off-by: Chung-Sheng Wu 
Change-Id: Ic8d9653abffd80039347f81823930eaa7f35180e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848048
Reviewed-by: Nick Vaccaro 
Tested-by: Nick Vaccaro 
Commit-Queue: Chung-Sheng Wu

vboot/ui: Refactor log_page api

2021-04-28T05:49:07+00:00

Refactor code to use log_page_update to update log pages. Clean up
duplicated code. Split the cancel button logic to
log_page_show_back_or_cancel function.

BUG=b:174127808, b:157625765
TEST=make clean && CC=x86_64-pc-linux-gnu-clang make runtests
BRANCH=none

Cq-Depend: chromium:2641904
Signed-off-by: Chung-Sheng Wu 
Change-Id: Iaa8565c91c310e218dade45eb0efd56c72950512
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2641981
Reviewed-by: Hsuan Ting Chen 
Reviewed-by: Yu-Ping Wu 
Tested-by: Chung-Sheng Wu 
Commit-Queue: Chung-Sheng Wu 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848047
Reviewed-by: Nick Vaccaro 
Tested-by: Nick Vaccaro

vboot: do not change screens when dev boot disallowed

2021-04-28T05:49:07+00:00

In CL:2716747, VB2_SCREEN_DEVELOPER_TO_NORM is pulled up to act
as the root screen in the case of dev boot being disallowed.

As such, the screen changes can be removed from
VB2_SCREEN_DEVELOPER_MODE init() and reinit() functions.
If the user does manage to get into the developer mode screen
while developer mode is disabled, rely on the individual checks
in these functions to prevent booting:

- vb2_ui_developer_mode_boot_internal_action
- vb2_ui_developer_mode_boot_external_action
- vb2_ui_developer_mode_boot_altfw_action

BUG=b:159579189, b:181087237
TEST=make clean && make runtests
BRANCH=none

Signed-off-by: Joel Kitching 
Change-Id: Ic72d30709baeac2fc7e681d973413e2e9c8b0483
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2730669
Reviewed-by: Joel Kitching 
Tested-by: Joel Kitching 
Commit-Queue: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848046
Reviewed-by: Nick Vaccaro 
Tested-by: Nick Vaccaro 
Commit-Queue: Chung-Sheng Wu

vboot/ui: Split out enabling/disabling buttons from log_page_* functions

2021-04-28T05:49:06+00:00

Add a new log_page_update function to maintain the state of page up/down
buttons.

BUG=b:174127808
TEST=make clean && CC=x86_64-pc-linux-gnu-clang make runtests
BRANCH=none

Signed-off-by: Chung-Sheng Wu 
Change-Id: I6c396af3139229771557f017b816ea93aba27be2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2641979
Tested-by: Chung-Sheng Wu 
Commit-Queue: Chung-Sheng Wu 
Reviewed-by: Meng-Huan Yu 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848045
Reviewed-by: Nick Vaccaro 
Tested-by: Nick Vaccaro

vboot: Replace VB2_REQUEST_UI_CONTINUE with VB2_SUCCESS

2021-04-28T05:49:05+00:00

In current codebase, VB2_REQUEST_UI_CONTINUE is for successful ui
function call, and VB2_SUCCESS is for breaking the main ui loop.

Replace most of the VB2_REQUEST_UI_CONTINUE with VB2_SUCCESS, and
replace those breaking requesting VB2_SUCCESS with VB2_REQUEST_UI_EXIT.
All the "VB2_REQUEST_UI_CONTINUE" and "VB2_REQUEST_UI_EXIT" are caught
in the ui loop. VB2_REQUEST_UI_CONTINUE does nothing while
VB2_REQUEST_UI_EXIT breaks the ui loop and return VB2_SUCCESS. Returning
VB2_SUCCESS and VB2_REQUEST_UI_CONTINUE to the ui loop now should do the
same thing, that is, continue process the ui.

VB2_REQUEST_UI_CONTINUE can be used to quickly return from ui functions
to the main UI loop, because it is not VB2_SUCCESS and makes VB2_TRY
return.

BRANCH=none
BUG=b:157625765
TEST=make clean && CC=x86_64-pc-linux-gnu-clang make runtests

Signed-off-by: Chung-Sheng Wu 
Change-Id: If1b54657d09198196f9c646b6b907b4fd8faadce
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2714502
Tested-by: Chung-Sheng Wu 
Reviewed-by: Joel Kitching 
Commit-Queue: Chung-Sheng Wu 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848044
Reviewed-by: Nick Vaccaro 
Tested-by: Nick Vaccaro

minidiag: Rename storage to storage health info

2021-04-28T05:49:04+00:00

Rename storage to storage health info to prevent confusing with storage
self-test.

BRANCH=none
BUG=b:173364332
TEST=make clean && CC=x86_64-pc-linux-gnu-clang make runtests

Cq-Depend: chromium:2709784
Signed-off-by: Chung-Sheng Wu 
Change-Id: I6c5e355e2062b8c371dbbeff8a5f1b9445bac9f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2719252
Tested-by: Chung-Sheng Wu 
Commit-Queue: Chung-Sheng Wu 
Reviewed-by: Meng-Huan Yu 
Reviewed-by: Yu-Ping Wu 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848043
Reviewed-by: Nick Vaccaro 
Tested-by: Nick Vaccaro

vboot: always return after calling vb2_ui_screen_change

2021-04-28T05:49:04+00:00

Without returning, subsequent code may operate under the
assumption that the screen has *not* changed, leading to
unexpected behaviour.  The user may also be able to select
otherwise disallowed menu items.

BUG=b:181087237, chromium:1181484
TEST=make clean && make runtests
BRANCH=none

Signed-off-by: Joel Kitching 
Change-Id: I820e387417ad39e2f7bd47f65d08c387cf66d6e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2717449
Tested-by: Joel Kitching 
Reviewed-by: Yu-Ping Wu 
Commit-Queue: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848042
Reviewed-by: Nick Vaccaro 
Tested-by: Nick Vaccaro 
Commit-Queue: Chung-Sheng Wu

vboot/ui: Change root screen if DEV_DISABLE_BOOT is set

2021-04-28T05:49:03+00:00

Change UI root screen to DEVELOPER_TO_NORM if DEV_DISABLE_BOOT is set in
FWMP, and disable all dev-mode shortcuts except '\t'. This ensures
DEVELOPER_TO_NORM and VB2_SCREEN_DEBUG_INFO are the only two screens
accessible from the UI.

Also hide the "Cancel" menu item in DEVELOPER_TO_NORM.

BUG=b:159579189, chromium:1181484
TEST=make runtests
TEST=emerge-asurada depthcharge
BRANCH=none

Change-Id: Ifedb53ae2eb968b1118340aef30cda00b7925f03
Signed-off-by: Yu-Ping Wu 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2716747
Reviewed-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848041
Reviewed-by: Nick Vaccaro 
Tested-by: Nick Vaccaro 
Commit-Queue: Chung-Sheng Wu

vboot: add tests for VB2_TRY around screen changes

2021-04-28T05:49:02+00:00

After these functions are called, no assumptions may be made
about which screen is currently displayed, and thus execution
should return to ui_loop:

- vb2_ui_menu_select
- vb2_ui_screen_back
- vb2_ui_screen_change

When VB2_TRY() is wrapped around these functions, the result
should be returning immediately.  No code following the functions
should be executed.  Add unit test coverage for this.

BUG=b:157625765
TEST=make clean && make runtests
BRANCH=none

Signed-off-by: Joel Kitching 
Change-Id: I4fc2a1eb59012eeefce34d25f010a49cb1d957de
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2721377
Tested-by: Joel Kitching 
Reviewed-by: Hsuan Ting Chen 
Commit-Queue: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2848040
Reviewed-by: Nick Vaccaro 
Tested-by: Nick Vaccaro 
Commit-Queue: Chung-Sheng Wu