delta/coreboot/vboot.git, branch firmware-octopus-11297.106.B

lib/ec_sync_all: Reboot EC to RO after successful AUX FW update

2019-06-21T21:09:55+00:00

Currently some chips that require AUX FW update request EC reboot to RO
after the FW update is applied successfully while some chips do not. It
is safe to request EC reboot to RO whenever AUX FW update is applied
successfully so that all the chips that require AUX FW update gets reset
to a clean state.

Update tests to handle the updated code flow and return code correctly.

Cq-Depend: chromium:1625866
BUG=b:128820536,b:119046668
BRANCH=None
TEST=Ensure that the device boots to ChromeOS. Force a TCPC FW update
and ensure that after it is successfully applied EC reboots to RO.

Change-Id: I72849620d90284e49cd1a9b31fc5eadede455c51
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1672056
Reviewed-by: Karthikeyan Ramasubramanian 
Commit-Queue: Karthikeyan Ramasubramanian 
Tested-by: Karthikeyan Ramasubramanian

tests/ec_sync_tests: Update the test to reflect new AUX FW protection

2019-06-21T20:58:09+00:00

All AUX FW remote bus tunnels are protected as part of
VbootExEcVbootDone callback. So update the test to reflect that
behavior.

BUG=None
BRANCH=None
TEST=/mnt/host/source/chromite/bin/cros_run_unit_tests --board=octopus
--packages=chromeos-base/vboot_reference

Change-Id: I163518a57deb586fb12ea11ba74987ff1a4ad90b
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1641531
Tested-by: Karthikeyan Ramasubramanian 
Reviewed-by: Julius Werner 
Commit-Queue: Karthikeyan Ramasubramanian 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1672055
Reviewed-by: Karthikeyan Ramasubramanian

firmware/lib/ec_sync_all: Refactor the EC SW Sync flow

2019-06-21T20:58:08+00:00

Perform all the operations regarding EC AUX FW update once the EC update
is applied and EC has jumped to the updated image. This way the
information regarding the devices that require EC AUX FW update can be
probed and obtained from EC consistently.

BUG=b:128820536,b:119046668
BRANCH=None
TEST=Ensure that the device boots to ChromeOS. Ensure that the Aux FW
update is handled after EC update is applied and jumped to the updated
EC image.

Casta:
sync_one_ec: jumping to EC-RW
send_packet: CrosEC result code 12
EC returned from reboot after 53061us
ps8751.0: vendor 0x1da0 product 0x8751 device 0x0001 fw_rev 0x39
ps8751.1: vendor 0x1da0 product 0x8751 device 0x0001 fw_rev 0x39

Bobba:
sync_one_ec: jumping to EC-RW
send_packet: CrosEC result code 12
EC returned from reboot after 52271us
ps8751.1: vendor 0x1da0 product 0x8751 device 0x0001 fw_rev 0x39

Ampton:
sync_one_ec: jumping to EC-RW
EC returned from reboot after 43019us
vb2_developer_ui: Entering
vboot_draw_screen: screen=0x101 locale=0

Change-Id: I28956543dfe1e059e15212dceada8bc517c0e7fc
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://chromium-review.googlesource.com/1592472
Commit-Ready: Karthikeyan Ramasubramanian 
Tested-by: Karthikeyan Ramasubramanian 
Legacy-Commit-Queue: Commit Bot 
Reviewed-by: Julius Werner 
Reviewed-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1672054
Reviewed-by: Karthikeyan Ramasubramanian 
Commit-Queue: Karthikeyan Ramasubramanian

futility: updater: Revise error message when model is not defined in manifest

2018-11-30T16:00:45+00:00

"Model '%s' is not defined in manifest." is not very easy to understand
for people who are debugging devices in early stages. We should provide
better instructions. For example, running with Coral updater will now
show:

ERROR: manifest_find_model: Cannot get model name.
You are probably running an image for wrong board, or a device in early
stage that 'mosys' command is not ready, or image from old (or factory)
branches that Unified Build config is not updated yet for 'mosys'.
Please check command 'mosys platform model', which should output one of
the supported models below:
 unprovisioned_meep sparky orbatrix unprovisioned_fleex grabbiter bobba
 unprovisioned_bobba mimrock fleex meep yorp phaser360 sparky360 phaser
 bobba360 unprovisioned_phaser bip

BUG=chromium:875551
TEST=TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: Ib17fcb654d1530b94c44cf21aaa28717841f11ed
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1351171
Reviewed-by: Cheng-Han Yang 
Reviewed-by: Ting Shen 
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/c/1355750
Reviewed-by: Furquan Shaikh 
Commit-Queue: Furquan Shaikh 
Tested-by: Furquan Shaikh 
Trybot-Ready: Furquan Shaikh

firmware: tpm2_lite: Implement TlclGetRandom()

2018-11-30T16:00:38+00:00

Implement support for getting random bytes from the TPM in the tpm2
library. The intent is to use this to seed the kaslr-seed DT property on
ARM devices.

BRANCH=None
BUG=None
TEST=Generate some random bytes in depthcharge using this API,
and 'stop trunksd; tpmc rand ' with sizes (0, 1, 0xf0, and
0xf1) on the device and see the last one fail

Change-Id: Ied0dc1ead70ac4daa2cee315516160ec100039be
Signed-off-by: Stephen Boyd 
Reviewed-on: https://chromium-review.googlesource.com/1327187
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Andrey Pronin 
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/c/1355749
Reviewed-by: Furquan Shaikh 
Commit-Queue: Furquan Shaikh 
Tested-by: Furquan Shaikh 
Trybot-Ready: Furquan Shaikh

test/ec_sync_test: Add mock test for VB_AUX_FW_NO_DEVICE severity

2018-11-30T16:00:29+00:00

Add a mock test to handle VB_AUX_FW_NO_DEVICE severity

BUG=chromium:896451
BRANCH=None
TEST=/mnt/host/source/chromite/bin/cros_run_unit_tests
      --board=octopus --packages=chromeos-base/vboot_reference

Change-Id: Ifdabdf3cee1130a8c853d57c278f0e557ebbb96f
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://chromium-review.googlesource.com/1299994
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Julius Werner 
Reviewed-by: Jett Rink 
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/c/1355748
Commit-Queue: Furquan Shaikh 
Tested-by: Furquan Shaikh 
Trybot-Ready: Furquan Shaikh

vboot_api: Add new VB_AUX_FW_NO_DEVICE update severity

2018-11-30T16:00:21+00:00

There is a possibility that a registered device is not present at
run-time and this scenario needs to be handled a little different. Add a
new update severity to handle this situation.

BUG=chromium:896451
BRANCH=None
TEST=bootup to ChromeOS by connecting and disconnecting the USB
daughterboard

Change-Id: I8a2044ce6a10fe611ee1f47262a7b54598a53ce3
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://chromium-review.googlesource.com/1299993
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Julius Werner 
Reviewed-by: Jett Rink 
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/c/1355747
Commit-Queue: Furquan Shaikh 
Tested-by: Furquan Shaikh 
Trybot-Ready: Furquan Shaikh

futility: updater: Revise output messages for debug logs

2018-11-25T03:21:29+00:00

In auto update and recovery, the firmware updater was executed with both
stdout and stderr logged. However, the logs usually comes with all stderr
first then all stdout. This makes it harder to debug because the
messages logged in out of order.

TO solve that, few macros are introduced:
 INFO: for useful information.
 STATUS: the most common information, usually comes with a prefix code.

And all messages should now go to stderr except the final execution
result (and those output commands, for example --manifest).

BUG=chromium:875551
TEST=TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
CQ-DEPEND=CL:1345250
BRANCH=None

Change-Id: Ie0dc6594ece10e7e15caf9c36353e2b3ec8754c5
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1345611
Reviewed-by: Youcheng Syu

futility: updater: Add new quirk 'allow_empty_wltag'

2018-11-25T03:21:28+00:00

There were devices shipped as "only device" (no key set) and then became
one of the "white label" family. This is now no longer valid on newer
devices but we have to support the legacy ones, for example Reks.

BUG=chromium:906962
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: I437be08726ab2c46229062689bf765ac6837ca5d
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1345610
Reviewed-by: Youcheng Syu

futility: updater: Load quirks immediately after host image is loaded

2018-11-25T03:21:28+00:00

There may be quirks needed during image archive setup (for example
loading white label tags) so we have to move quirks setup to some
earlier place.

BUG=chromium:906962
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: I1f6eddb0119c64098df75bad72809ba8366625c7
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1345609
Reviewed-by: Youcheng Syu