From fd8854ec0f51cf1107c8e001fc01da63ceff6110 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Fri, 10 Feb 2023 09:56:40 -0700 Subject: Docs/Makefile: change 'which' to 'command -v' The "which" command is not a posix command. Additionally, if a file is not found, it outputs "command not found", so when checking to see if the response is "", that doesn't work. "command -v" is a posix compliant replacement that doesn't put out any text if the command is not found, so is more suitable in this case anyway. Signed-off-by: Martin Roth Change-Id: I22207e818c847d50998f90c9abd55a3cb4bb2ab3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/72922 Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer --- Documentation/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'Documentation') diff --git a/Documentation/Makefile b/Documentation/Makefile index 836b6e5f87..8552c6d692 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -10,9 +10,9 @@ FIGS=codeflow.pdf hypertransport.pdf all: corebootPortingGuide.pdf -SVG2PDF=$(shell which svg2pdf) -INKSCAPE=$(shell which inkscape) -CONVERT=$(shell which convert) +SVG2PDF=$(shell command -v svg2pdf) +INKSCAPE=$(shell command -v inkscape) +CONVERT=$(shell command -v convert) codeflow.pdf: codeflow.svg ifneq ($(strip $(SVG2PDF)),) -- cgit v1.2.1