From 7aab81edce830e15134b52256ad3186e08951b10 Mon Sep 17 00:00:00 2001 From: Vincent Palatin Date: Thu, 6 Mar 2014 16:02:58 -0800 Subject: force the compiler to use a valid register allocation for irq handlers When we are calling the re-scheduling routine at the end of an irq handling routine, we need to ensure that the high registers are not currently saved on the system stack. On Cortex-M3/M4, the compiler is normally doing tail-call optimization there and behaving properly, but this fixes the fact that insanely large interrupt handling routines where sometimes not compile and not running properly (aka issue 24515). This also prepares for one more core-specific DECLARE_IRQ routine on Cortex-M0. Note: now on, the IRQ handling routines should no longer be "static". Signed-off-by: Vincent Palatin BRANCH=none BUG=chrome-os-partner:24515 TEST=make -j buildall revert the workaround for 24515, see the issue happening only without this CL. Change-Id: Ic419369231925568df05815fd079ed191a5446db Reviewed-on: https://chromium-review.googlesource.com/189153 Reviewed-by: Vic Yang Reviewed-by: Randall Spangler Commit-Queue: Vincent Palatin Tested-by: Vincent Palatin --- chip/mec1322/i2c.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'chip/mec1322/i2c.c') diff --git a/chip/mec1322/i2c.c b/chip/mec1322/i2c.c index feaade3813..8eaf861382 100644 --- a/chip/mec1322/i2c.c +++ b/chip/mec1322/i2c.c @@ -403,10 +403,10 @@ static void handle_interrupt(int port) task_set_event(id, TASK_EVENT_I2C_IDLE, 0); } -static void i2c0_interrupt(void) { handle_interrupt(0); } -static void i2c1_interrupt(void) { handle_interrupt(1); } -static void i2c2_interrupt(void) { handle_interrupt(2); } -static void i2c3_interrupt(void) { handle_interrupt(3); } +void i2c0_interrupt(void) { handle_interrupt(0); } +void i2c1_interrupt(void) { handle_interrupt(1); } +void i2c2_interrupt(void) { handle_interrupt(2); } +void i2c3_interrupt(void) { handle_interrupt(3); } DECLARE_IRQ(MEC1322_IRQ_I2C_0, i2c0_interrupt, 2); DECLARE_IRQ(MEC1322_IRQ_I2C_1, i2c1_interrupt, 2); -- cgit v1.2.1