From 83d793839479a6f3414dbf51c00536aff65618f3 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Fri, 20 Sep 2019 10:04:44 -0700 Subject: host_command: Change host command return value to enum ec_status If the host command handler callback function returns an int, it's easy to accidentally mix up the enum ec_error_list and enum ec_status types. The host commands always expect an enum ec_status type, so we change the return value to be of that explicit type. Compilation will then fail if you accidentally try to return an enum ec_error_list value. Ran the following commands and then manually fixed up a few remaining instances that were not caught: git grep --name-only 'static int .*(struct host_cmd_handler_args \*args)' |\ xargs sed -i 's#static int \(.*\)(struct host_cmd_handler_args \*args)#\ static enum ec_status \1(struct host_cmd_handler_args \*args)##' git grep --name-only 'int .*(struct host_cmd_handler_args \*args)' |\ xargs sed -i 's#int \(.*\)(struct host_cmd_handler_args \*args)#\ enum ec_status \1(struct host_cmd_handler_args \*args)##' BRANCH=none BUG=chromium:1004831 TEST=make buildall -j Cq-Depend: chrome-internal:1872675 Change-Id: Id93df9387ac53d016a1594dba86c6642babbfd1e Signed-off-by: Tom Hughes Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816865 Reviewed-by: Daisuke Nojiri Reviewed-by: Jack Rosenthal --- board/samus/panel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'board/samus') diff --git a/board/samus/panel.c b/board/samus/panel.c index beb0d32e9d..b3fe6060aa 100644 --- a/board/samus/panel.c +++ b/board/samus/panel.c @@ -144,7 +144,8 @@ DECLARE_DEFERRED(lp8555_enable_pwm_mode); /** * Host command to toggle backlight. */ -static int switch_command_enable_backlight(struct host_cmd_handler_args *args) +static enum ec_status +switch_command_enable_backlight(struct host_cmd_handler_args *args) { const struct ec_params_switch_enable_backlight *p = args->params; -- cgit v1.2.1