From 4201931efe7fd413ae7a02b12d5f6c8e5709771f Mon Sep 17 00:00:00 2001 From: nickchen Date: Wed, 25 Jul 2018 16:40:29 +0800 Subject: phaser: remove GPIO_PULL_UP of volume buttons Remove the unnecessary GPIO_PULL_UP of volume up and down for phaser, there are external pull up resistors (R185 & R229). BUG=b:110013537 BRANCH=none TEST=Press volume buttons, verified by OEM. make buildall pass. Change-Id: I316973e02a24cb8716da372e9bbd1f3ae7dfdfc7 Signed-off-by: nickchen Reviewed-on: https://chromium-review.googlesource.com/1149775 Commit-Ready: Nick Chen Tested-by: Nick Chen Reviewed-by: Nick Chen Reviewed-by: Jett Rink --- board/phaser/gpio.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'board/phaser') diff --git a/board/phaser/gpio.inc b/board/phaser/gpio.inc index d8c9db8c15..94e848efb7 100644 --- a/board/phaser/gpio.inc +++ b/board/phaser/gpio.inc @@ -19,8 +19,8 @@ GPIO_INT(LID_OPEN, PIN(D, 2), GPIO_INT_BOTH | GPIO_INT(POWER_BUTTON_L, PIN(0, 1), GPIO_INT_BOTH, power_button_interrupt) /* MECH_PWR_BTN_ODL */ GPIO_INT(AC_PRESENT, PIN(0, 0), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, extpower_interrupt) /* ACOK_OD */ -GPIO_INT(EC_VOLUP_BTN_ODL, PIN(7, 5), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) -GPIO_INT(EC_VOLDN_BTN_ODL, PIN(4, 0), GPIO_INT_BOTH | GPIO_PULL_UP, button_interrupt) +GPIO_INT(EC_VOLUP_BTN_ODL, PIN(7, 5), GPIO_INT_BOTH, button_interrupt) +GPIO_INT(EC_VOLDN_BTN_ODL, PIN(4, 0), GPIO_INT_BOTH, button_interrupt) /* USB-C interrupts */ GPIO_INT(USB_C0_MUX_INT_ODL, PIN(6, 1), GPIO_INT_FALLING, tcpc_alert_event) -- cgit v1.2.1