From 5a9a8f3dbf93cb651bef6ffbd420a24ca5ee01aa Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Thu, 25 Feb 2016 10:48:10 -0800 Subject: cleanup: Add warning comment to gpio.inc files With commit e9883124ff16, a GPIO_INT macro was added. That change also required that all instances of GPIO_INT in a board's gpio.inc file come before any GPIO macros, or the interrupt handler wouldn't work properly. This CL just adds a warning comment about requirement to all gpio.inc files. BUG=chromium:471331 BRANCH=none TEST=make buildall, test image on Cr50 This is a change to comments only. There is no new behavior to verify, although I did run try out one new image just to be sure nothing stupid happened. Change-Id: I83f7819929a53bce3a8bae04d15b3ee3bda11738 Signed-off-by: Bill Richardson Reviewed-on: https://chromium-review.googlesource.com/329334 Reviewed-by: Vadim Bendebury --- board/lucid/gpio.inc | 3 +++ 1 file changed, 3 insertions(+) (limited to 'board/lucid') diff --git a/board/lucid/gpio.inc b/board/lucid/gpio.inc index 72fb4acfa8..90fa4d2c16 100644 --- a/board/lucid/gpio.inc +++ b/board/lucid/gpio.inc @@ -5,6 +5,9 @@ * found in the LICENSE file. */ +/* Declare symbolic names for all the GPIOs that we care about. + * Note: Those with interrupt handlers must be declared first. */ + /* Interrupts */ GPIO_INT(AC_PRESENT, PIN(C, 13), GPIO_INT_BOTH, vbus_evt) /* AC power present */ GPIO_INT(CHARGE_STATUS, PIN(F, 1), GPIO_INT_BOTH, charge_state_interrupt) -- cgit v1.2.1