From 2eb53a39662b905c65015bafb5f73ab2324d369c Mon Sep 17 00:00:00 2001 From: Wai-Hong Tam Date: Tue, 3 Aug 2021 17:17:56 -0700 Subject: lid_angle: Create a common callback for lid angle changes Each board defines its own callback lid_angle_peripheral_enable(). The implementation is very similar. Create a common implementation and reduce the duplicated code. This CL removes the board callbacks which are identifical to the common callback. If it is slightly different, keep it and add the __override tag. The check of TEST_BUILD is unnecessary as the board callback is not linked in the test build. BRANCH=None BUG=b:194922043 TEST=Build all the images. Change-Id: I73d381730f35b80eff69399cdfc5fb54f839aee0 Signed-off-by: Wai-Hong Tam Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069175 Reviewed-by: Aseda Aboagye --- board/drawcia/board.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'board/drawcia') diff --git a/board/drawcia/board.c b/board/drawcia/board.c index 60ddffaaa5..80f93e4d1d 100644 --- a/board/drawcia/board.c +++ b/board/drawcia/board.c @@ -662,9 +662,8 @@ const struct temp_sensor_t temp_sensors[] = { }; BUILD_ASSERT(ARRAY_SIZE(temp_sensors) == TEMP_SENSOR_COUNT); -#ifndef TEST_BUILD /* This callback disables keyboard when convertibles are fully open */ -void lid_angle_peripheral_enable(int enable) +__override void lid_angle_peripheral_enable(int enable) { int chipset_in_s0 = chipset_in_state(CHIPSET_STATE_ON); @@ -688,7 +687,6 @@ void lid_angle_peripheral_enable(int enable) keyboard_scan_enable(0, KB_SCAN_DISABLE_LID_ANGLE); } } -#endif __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, -- cgit v1.2.1