From e7c0bbeddb24a0c44e49aa720589932bafba5aea Mon Sep 17 00:00:00 2001 From: Scott Chao Date: Mon, 9 Aug 2021 18:08:57 +0800 Subject: primus: add fan control - Need EN_P5000_FAN to be off when S5. - Don't let fan keep on in S5 when using dummy fan. BUG=b:195901486, b:195387997 BRANCH=none TEST=make -j BOARD=primus Signed-off-by: Scott Chao Change-Id: I3f2d060967d0538e54dfe2f99df7025ccb9a36ef Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3081041 Reviewed-by: caveh jalali --- board/primus/board.h | 5 +---- board/primus/sensors.c | 6 +++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/board/primus/board.h b/board/primus/board.h index 7a2e77543b..6d96e80e21 100644 --- a/board/primus/board.h +++ b/board/primus/board.h @@ -130,10 +130,7 @@ /* LED */ #define CONFIG_BATTERY_LEVEL_NEAR_FULL 91 -/* - * TODO: no fan control loop until sensors are tuned - */ -/* #define CONFIG_FANS FAN_CH_COUNT */ +#define CONFIG_FANS FAN_CH_COUNT /* Charger defines */ #define CONFIG_CHARGER_BQ25720 diff --git a/board/primus/sensors.c b/board/primus/sensors.c index 50fe62c198..57fecaf780 100644 --- a/board/primus/sensors.c +++ b/board/primus/sensors.c @@ -86,7 +86,7 @@ const struct temp_sensor_t temp_sensors[] = { BUILD_ASSERT(ARRAY_SIZE(temp_sensors) == TEMP_SENSOR_COUNT); /* - * TODO(b/190459738): update for Alder Lake/primus + * TODO(b/195901486): update for Alder Lake/primus * * Tiger Lake specifies 100 C as maximum TDP temperature. THRMTRIP# occurs at * 130 C. However, sensor is located next to DDR, so we need to use the lower @@ -105,7 +105,7 @@ static const struct ec_thermal_config thermal_cpu = { }; /* - * TODO(b/190459738): update for Alder Lake/primus + * TODO(b/195901486): update for Alder Lake/primus * * Inductor limits - used for both charger and PP3300 regulator * @@ -130,7 +130,7 @@ static const struct ec_thermal_config thermal_inductor = { }; /* - * TODO(b/190459738): Thermal table need to be fine tuned. + * TODO(b/195901486): Thermal table need to be fine tuned. */ struct ec_thermal_config thermal_params[] = { [TEMP_SENSOR_1_DDR_SOC] = thermal_cpu, -- cgit v1.2.1