From e4fe08f268f7fdb38f3bcce1889475fc0f2d841f Mon Sep 17 00:00:00 2001 From: Michael5 Chen Date: Wed, 2 Oct 2019 16:37:37 +0800 Subject: helios: Modify EC fan control table Modify EC fan control table by Thermal request. (#21) BUG=b:136565336 BRANCH=none TEST=Manual Verify fan behavior by thermal team. Remove DPTF and check fan speed with temperature. When temperature over 65 degree, the fan start working. When temperature over 85 degree, the fan full run. And check system shutdown when temperature over 90 degree. Change-Id: I0d4633e9ba93ba12f28d4d069a9ae2a7a82fcedd Signed-off-by: Michael5 Chen Signed-off-by: Tim Wawrzynczak Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1833944 --- board/helios/board.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/board/helios/board.c b/board/helios/board.c index bb13c5531c..5630416818 100644 --- a/board/helios/board.c +++ b/board/helios/board.c @@ -387,26 +387,20 @@ const struct temp_sensor_t temp_sensors[] = { }; BUILD_ASSERT(ARRAY_SIZE(temp_sensors) == TEMP_SENSOR_COUNT); - -/* Helios Temperature sensors */ -/* - * TODO(b/124316213): These setting need to be reviewed and set appropriately - * for Helios. They matter when the EC is controlling the fan as opposed to DPTF - * control. - */ +/* Helios temperature control thresholds */ const static struct ec_thermal_config thermal_a = { .temp_host = { [EC_TEMP_THRESH_WARN] = 0, - [EC_TEMP_THRESH_HIGH] = C_TO_K(75), - [EC_TEMP_THRESH_HALT] = C_TO_K(80), + [EC_TEMP_THRESH_HIGH] = C_TO_K(65), + [EC_TEMP_THRESH_HALT] = C_TO_K(90), }, .temp_host_release = { [EC_TEMP_THRESH_WARN] = 0, - [EC_TEMP_THRESH_HIGH] = C_TO_K(65), + [EC_TEMP_THRESH_HIGH] = C_TO_K(60), [EC_TEMP_THRESH_HALT] = 0, }, - .temp_fan_off = C_TO_K(25), - .temp_fan_max = C_TO_K(50), + .temp_fan_off = C_TO_K(65), + .temp_fan_max = C_TO_K(80), }; struct ec_thermal_config thermal_params[TEMP_SENSOR_COUNT]; -- cgit v1.2.1