From bd931142b838be17046ffa091ecb7abe26226552 Mon Sep 17 00:00:00 2001 From: Mary Ruthven Date: Mon, 7 Nov 2022 10:13:09 -0800 Subject: rddkeepalive: return EC_ERROR_ACCESS_DENIED if the console is locked If the console is locked, return EC_ERROR_ACCESS_DENIED instead of EC_ERROR_PARAM1, so the behavior is consistent with other commands. BUG=b:251207798 TEST=run rddkeepalive enable when the console is locked. Change-Id: I65e210052afc197899873f3e1079c7dc5b791c58 Signed-off-by: Mary Ruthven Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4009999 Reviewed-by: Jett Rink Commit-Queue: Jett Rink --- chip/g/rdd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/chip/g/rdd.c b/chip/g/rdd.c index 7620e55a49..c121a232a8 100644 --- a/chip/g/rdd.c +++ b/chip/g/rdd.c @@ -227,7 +227,9 @@ static int command_rdd_keepalive(int argc, char **argv) return EC_SUCCESS; } - if (console_is_restricted() || !parse_bool(argv[1], &force_detected)) + if (console_is_restricted()) + return EC_ERROR_ACCESS_DENIED; + if (!parse_bool(argv[1], &force_detected)) return EC_ERROR_PARAM1; if (force_detected) { -- cgit v1.2.1