From 92ccd12aeb8cd4fd0f6463c66e4d9c2e6836d586 Mon Sep 17 00:00:00 2001 From: Rob Barnes Date: Tue, 27 Apr 2021 15:39:57 -0600 Subject: mancomb: Pull eSPI RST# high to disable eSPI RST# is asserted during S0ix but eSPI is not reinitialized during resume. eSPI RST# isn't actually needed because PLTRST# is used during initialization. BUG=b:186135022, b:186470159 TEST=No espi errors on guybrush. Builds for mancomb. BRANCH=None Signed-off-by: Rob Barnes Change-Id: I1d1b3c28c3f3661452e841f3293234a9337070ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2855634 Reviewed-by: Diana Z --- baseboard/mancomb/base_gpio.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/baseboard/mancomb/base_gpio.inc b/baseboard/mancomb/base_gpio.inc index 999fafda83..3417850762 100644 --- a/baseboard/mancomb/base_gpio.inc +++ b/baseboard/mancomb/base_gpio.inc @@ -113,6 +113,9 @@ GPIO(HDMI_1_CEC, PIN(1, 7), GPIO_OUT_LOW) GPIO_INT(FAULT_HDMI_1_L, PIN(2, 5), GPIO_INT_FALLING, hdmi_fault_interrupt) GPIO_INT(FAULT_DP_L, PIN(2, 6), GPIO_INT_FALLING, dp_fault_interrupt) +/* b/186135022: Pull eSPI RST# high to disable */ +GPIO(EC_ESPI_RST_L, PIN(5, 4), GPIO_PULL_UP) + #if 0 /* * SOC eSPI Bus @@ -125,7 +128,6 @@ GPIO(ESPI_SOC_D0_EC, PIN(4, 6), GPIO_DEFAULT) GPIO(ESPI_SOC_D1_EC, PIN(4, 7), GPIO_DEFAULT) GPIO(ESPI_SOC_D2_EC, PIN(5, 1), GPIO_DEFAULT) GPIO(ESPI_SOC_D3_EC, PIN(5, 2), GPIO_DEFAULT) -GPIO(EC_ESPI_RST_L, PIN(5, 4), GPIO_DEFAULT) GPIO(ESPI_EC_ALERT_SOC_L, PIN(5, 7), GPIO_DEFAULT) #endif -- cgit v1.2.1