From 88295aca5ac9bb9d13adf086bda66be09bd9f182 Mon Sep 17 00:00:00 2001 From: Randall Spangler Date: Mon, 16 Jun 2014 16:30:57 -0700 Subject: i2c: remove (lack of) 10-bit support in i2c passthru We never implemented this. We have no devices which support it. And we used bit #17 in a 16-bit field to flag it, so it wouldn't have worked even if we did. So, remove this (dead) code. BUG=chromium:382944 BRANCH=none TEST=make -j buildall Change-Id: Id3a4a93612d1078a3239d85921a05cfd7362b84c Signed-off-by: Randall Spangler Reviewed-on: https://chromium-review.googlesource.com/204162 Reviewed-by: Doug Anderson --- common/i2c.c | 7 ------- include/ec_commands.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/common/i2c.c b/common/i2c.c index fab2aefc67..82e36f6c25 100644 --- a/common/i2c.c +++ b/common/i2c.c @@ -443,13 +443,6 @@ static int check_i2c_params(const struct host_cmd_handler_args *args) msgnum++, msg++) { unsigned int addr_flags = msg->addr_flags; - /* Parse slave address if necessary */ - if (addr_flags & EC_I2C_FLAG_10BIT) { - /* 10-bit addressing not supported yet */ - PTHRUPRINTF("i2c passthru no 10-bit addressing"); - return EC_RES_INVALID_PARAM; - } - PTHRUPRINTF("i2c passthru port=%d, %s, addr=0x%02x, " "len=0x%02x", params->port, diff --git a/include/ec_commands.h b/include/ec_commands.h index 54f0ed2aa7..55187cdb93 100644 --- a/include/ec_commands.h +++ b/include/ec_commands.h @@ -2046,9 +2046,6 @@ struct ec_response_power_info { #define EC_CMD_I2C_PASSTHRU 0x9e -/* Slave address is 10 (not 7) bit */ -#define EC_I2C_FLAG_10BIT (1 << 16) - /* Read data; if not present, message is a write */ #define EC_I2C_FLAG_READ (1 << 15) -- cgit v1.2.1