From 2ccb1e3e8b04a78ad0091a82473164a5b093ca0f Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Wed, 29 Sep 2021 00:03:19 +0000 Subject: core/minute-ia: Remove .func and .endfunc .func and .endfunc were used to emit STABS debug information (not DWARF). These only have an effect with -gstabs, which we're not using. I suspect their inclusion was not intentional. STABS is not supported when building with clang, so it generates the following errors: core/minute-ia/switch.S:27:1: error: unknown directive .func __task_start ^ core/minute-ia/switch.S:42:1: error: unknown directive .endfunc See https://bugs.llvm.org/show_bug.cgi?id=20424 and https://sourceware.org/gdb/current/onlinedocs/stabs.html. As indicated by the TEST line, the output is indentical before and after this change. BRANCH=none BUG=b:172020503 TEST=make CC=clang V=1 BOARD=arcada_ish TEST=./util/compare_build.sh -b all -j 70 Signed-off-by: Tom Hughes Change-Id: I1e1e5f57fb382797e01dcf797d72de0468150054 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3193271 Reviewed-by: Aseda Aboagye --- core/minute-ia/switch.S | 8 -------- 1 file changed, 8 deletions(-) diff --git a/core/minute-ia/switch.S b/core/minute-ia/switch.S index f8d0be3874..cec3f904f9 100644 --- a/core/minute-ia/switch.S +++ b/core/minute-ia/switch.S @@ -24,7 +24,6 @@ # Start the task scheduling. Start current_task (hook_task) # This function is not an ISR but imitates the sequence. .align 4 -.func __task_start __task_start: movl 0x4(%esp), %ecx movl current_task, %eax @@ -39,12 +38,10 @@ __task_start: movl $0x1, (%ecx) # first task is ready. set start_called = 1 popa iret -.endfunc # Default interrupt handler - to handle exceptions # and prints error .align 4 -.func default_int_handler default_int_handler: pusha @@ -70,10 +67,8 @@ default_int_handler: ASM_LOCK_PREFIX subl $1, __in_isr popa iret -.endfunc .align 4 -.func sw_irq_handler sw_irq_handler: pusha ASM_LOCK_PREFIX addl $1, __in_isr @@ -91,14 +86,12 @@ sw_irq_handler: ASM_LOCK_PREFIX subl $1, __in_isr popa iret -.endfunc # Switches from one task to another if ready. # __schedule triggers software interrupt ISH_TS_VECTOR, which is handled by # __switchto .align 4 -.func __switchto __switchto: pusha ASM_LOCK_PREFIX addl $1, __in_isr @@ -116,4 +109,3 @@ __switchto: ASM_LOCK_PREFIX subl $1, __in_isr popa iret -.endfunc -- cgit v1.2.1