From 0ac6316df6dad527a44a2537a4a42b7803035e38 Mon Sep 17 00:00:00 2001 From: Hyungwoo Yang Date: Wed, 8 May 2019 16:26:22 -0700 Subject: ish: fix bugs in fwst check functions currently functions to check the status of ilup(IPC link up) and hup(HECI up) are changing values of FW status which is bug. BRANCH=none BUG=none TEST=tested on Arcada platform Change-Id: I1839304af619a3ee5a0856fe83560aa21a99e60a Signed-off-by: Hyungwoo Yang Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1601779 Reviewed-by: Jack Rosenthal Reviewed-by: Jett Rink Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1615482 Commit-Queue: Jett Rink Tested-by: Jett Rink --- chip/ish/ish_fwst.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chip/ish/ish_fwst.h b/chip/ish/ish_fwst.h index 506740e51b..c114db3241 100644 --- a/chip/ish/ish_fwst.h +++ b/chip/ish/ish_fwst.h @@ -117,7 +117,7 @@ static inline void ish_fwst_clear_ilup(void) /* return IPC link up state */ static inline int ish_fwst_is_ilup_set(void) { - return !!(IPC_ISH_FWSTS &= IPC_ISH_FWSTS_ILUP_MASK); + return !!(IPC_ISH_FWSTS & IPC_ISH_FWSTS_ILUP_MASK); } /* set HECI up */ @@ -135,7 +135,7 @@ static inline void ish_fwst_clear_hup(void) /* get HECI up status */ static inline int ish_fwst_is_hup_set(void) { - return !!(IPC_ISH_FWSTS &= IPC_ISH_FWSTS_HUP_MASK); + return !!(IPC_ISH_FWSTS & IPC_ISH_FWSTS_HUP_MASK); } /* set fw failure reason */ -- cgit v1.2.1