summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Nautilus : Change charging voltage and currentfirmware-poppy-10431.BYongBeum.Ha2023-02-081-2/+8
| | | | | | | | | | | | | | | | | Change charging voltage(8600mV) and current(3200mA). BUG=b:266123223 BRANCH=firmware-octopus-11297.B TEST=build, update and check charging voltage and current Change-Id: I589692ae43231b2af61a7ced129b5340a5cbd041 Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4199247 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Henry Sun <henrysun@google.com> (cherry picked from commit e4d60e249544547da843904c737c040d123834b3) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4230852 Commit-Queue: Henry Sun <henrysun@google.com>
* Nautilus : Change Maximum Voltage of BatteryYongBeum.Ha2023-02-031-1/+1
| | | | | | | | | | | | | | | | Change max voltage of battery to 8600mV BUG=b:266123223 BRANCH=firmware-octopus-11297.B TEST= build, update and check charging voltage Change-Id: Iccb17ad8e503e8743a4de591d79375810f86c2f8 Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4199246 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> (cherry picked from commit d97ab1cd05355fa7b26ac2d6bf3074b95e0b30d9) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4207267 Reviewed-by: Henry Sun <henrysun@google.com>
* Clear OWNERS for factory/firmware branchBrian Norris2021-09-112-10/+1
| | | | | | | | | | | | BUG=none TEST=none Change-Id: I0f03f432ada1064ffba9595be78ca7ab4d25ecd1 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3155224 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Owners-Override: Jora Jacobi <jora@google.com> Tested-by: Jack Rosenthal <jrosenth@chromium.org>
* poppy: Disable PU on GPIO10Nicolas Boichat2020-08-082-1/+11
| | | | | | | | | | | | | | | | | For NPCX5, when CR_SIN is selected via DEVALTC.UART_SL2, the PU/PD is selected according to GPIO10 configuration (and not according to GPIO64). Also, disable the relevant WKIEN bit for GPIO10. BRANCH=poppy BUG=b:111215677 TEST=Boot soraka Change-Id: Icee01043dcd562f9b72f2097b9a988d5535e0ffc Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Signed-off-by: CHLin <CHLIN56@nuvoton.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2214454
* nautilus: allow prswap to sink in S0ix and drswap in ROInno.Park2020-07-261-12/+12
| | | | | | | | | | | | | | | | | | | | | | | This merged crrev.com/c/1585121 and crrev.com/c/1355371 and applied them to nautilus. BUG=b:117232092 BRANCH=none TEST=Plug in an unpowered dongle to nautilus in S0, close the lid to trigger S0ix, plug in power to the dongle and check if power role swap accepted. && Disable software sync on nautilus and confirmed a powered hub could reliably display, enable software sync and put the EC into hibernate, waking it with a powered hub, confirming data role swap in RO had no adverse affects or hard resets. Change-Id: I616ca8a0e948076c690ea2a6a3a47eb12a3fd389 Signed-off-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2282725 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Bob Moragues <moragues@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Commit-Queue: Bob Moragues <moragues@chromium.org>
* board: Set Accelerometer range to 4gGwendal Grignou2020-06-2415-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Required by Android CDD - Section 7.3.1 - Paragraph C.1.4 Modified mechanically with: for i in $(grep -lr "\.default_range" board); do sed -i '/.default_range =/s#\(.*\.default_range = \).* /\ \* g.*#\14, /* g, to meet CDD 7.3.1/C-1-4 reqs */#' $i done Manually reworked to only change the accelerometer that matters to android: The lid accelerometer or the base accelerometer if the base also hosts the gyroscope. This is only for future EC, no need to land the change on branches: mems_setup will take care to set accelerometer ranges at 4g on startup. Conflicts: board/akemi/board.c board/ampton/board.c board/arcada_ish/board.c board/bloog/board.c board/bobba/board.c board/cheza/board.c board/coral/board.c board/dood/board.c board/drallion_ish/board.c board/dratini/board.c board/elm/board.c board/flapjack/board.c board/fleex/board.c board/garg/board.c board/glados/board.c board/hatch/board.c board/helios/board.c board/jinlon/board.c board/kindred/board.c board/kodama/board.c board/kohaku/board.c board/kukui/board.c board/mchpevb1/board.c board/meep/board.c board/nami/board.c board/nocturne/board.c board/nucleo-f411re/board.c board/oak/board.c board/phaser/board.c board/rammus/board.c board/reef_mchp/board.c board/strago/board.c board/stryke/board.c board/tglrvp_ish/board.c board/treeya/board.c board/trogdor/board.c board/yorp/board.c BUG=b:144004449 BRANCH=none TEST=compile Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1957375 Reviewed-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Alexandru M Stan <amstan@chromium.org> (cherry picked from commit 992810a77dd3698e69bcedd84f8259a08a753cb9) Change-Id: If8c14b2e928c9c70c0ce51451adcfcd674a9e73b Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2249460
* driver: bmi160: Fix rounding error in set_offset() and get_offset()Ching-Kang Yen2020-06-233-8/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | The original set_offset() and get_offset() codes in the driver/accelgyro_bmi160 use simple divisions to write the data. The more times the set_offset() and get_offset() is used, the data will get closer to 0. Fixing it by replacing simple division to round_divide(), division that round to nearest, in the common/math_util.c. BRANCH=octopus BUG=b:146823505 TEST=Testing on octopus:ampton on branch [firmware-octopus-11297.B]. Checking the data did not rounding to 0. Change-Id: Ide9df9e32fc501e63d6f952cb8254df7662afd23 Signed-off-by: Ching-Kang Yen <chingkang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2002998 Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org> (cherry picked from commit 036e9f7b214b763524497550aae0ee94df8fd536) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2249638 Reviewed-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com> Tested-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com> Commit-Queue: Bob Moragues <moragues@chromium.org>
* driver: bmi160: Fix ODR to REG when rate is less than 100Hz properlyGwendal Grignou2020-06-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the ODr was the exact frequency, the calculation was not correct. For instance, 50Hz would return register 6 when 7 was expected. Fixes: 0e99e9763 ("bmi160: Fix ODR to REG when rate is less than 100Hz") BUG=b:120942904 BRANCH=none TEST=use: for (int i = 1600000 ; i > 1000 ; i >>= 1) { printf("%d mHZ : reg %d\n", i + 1, BMI160_ODR_TO_REG(i + 1)); printf("%d mHZ : reg %d\n", i, BMI160_ODR_TO_REG(i)); printf("%d mHZ : reg %d\n", i -1 , BMI160_ODR_TO_REG(i -1)); } To verify the code is correct: 1600001 mHZ : reg 12 1600000 mHZ : reg 12 1599999 mHZ : reg 11 800001 mHZ : reg 11 800000 mHZ : reg 11 799999 mHZ : reg 10 400001 mHZ : reg 10 400000 mHZ : reg 10 399999 mHZ : reg 9 200001 mHZ : reg 9 200000 mHZ : reg 9 199999 mHZ : reg 8 100001 mHZ : reg 8 100000 mHZ : reg 8 99999 mHZ : reg 7 50001 mHZ : reg 7 50000 mHZ : reg 7 49999 mHZ : reg 6 25001 mHZ : reg 6 25000 mHZ : reg 6 24999 mHZ : reg 5 12501 mHZ : reg 5 12500 mHZ : reg 5 12499 mHZ : reg 4 6251 mHZ : reg 4 6250 mHZ : reg 4 6249 mHZ : reg 3 3126 mHZ : reg 3 3125 mHZ : reg 3 3124 mHZ : reg 2 1563 mHZ : reg 2 1562 mHZ : reg 2 1561 mHZ : reg 1 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Change-Id: Iefd0e0c732b52fef02f5b048c083ea67a2da247c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2093289 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> (cherry picked from commit c3dcd2826896e2f2f9b585dcd42ea98d38ae17cc) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2247975 Reviewed-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com> Tested-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com> Commit-Queue: Bob Moragues <moragues@chromium.org>
* poppy: Change console default to not overload cros_ec.logGwendal Grignou2020-06-181-0/+8
| | | | | | | | | | | | | | Use standard default to prevent sensor commands to fill /var/log/cros_ec.log. BUG=none BRANCH=poppy TEST=Check cros_ec.log is not filled with command 0x2b. Change-Id: Iac3b64dd4058683e03328a291fcb5bc6f8091932 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2251362 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
* stm32: Fix manual interrupt clearing functionCraig Hesling2020-03-171-1/+3
| | | | | | | | | | | | | | | | | | | | | This fixes a bug in gpio_clear_pending_interrupt, where all pending interrupts are unintentionally cleared. This is not in the code path for normal gpio interrupt handlers, since the normal interrupt clearing occurs in gpio_interrupt (right below this function). BRANCH=none BUG=chromium:1059520 TEST=none Signed-off-by: Craig Hesling <hesling@chromium.org> Change-Id: I4d6fe7947f4d76cf3b57dfbf3bb926e41851c80c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101208 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> (cherry picked from commit c2c2c083fef813e3e3c70f8c13a1418717ba682d) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2107291
* driver: bma2x2: Fix frequency precision errorGwendal Grignou2020-03-101-8/+10
| | | | | | | | | | | | | | | | | | | | | | | On nautilus, the max frequency is set to 62.5Hz (the EC max frequency is set to 100Hz). However, when setting frequency to 62500 (mHz), the EC would bump up the frequency to 125Hz. The problem was in the calculation of the true frequency. By using 7.81Hz instead of 7.8125Hz as the multiplier, the driver would calculate the true frequency as 62480mHz, so it would set the accelerometer frequency to the next data rate. BUG=chromium:1059456 BRANCH=poppy TEST=On nocturne, check frequency is set right and tast run <IP> hardware.SensorRing passes. Change-Id: I743201bc8cccc7d38f39d1e370d660f4f37b4d95 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2092911 Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> (cherry picked from commit 6c25137279a382ed186aff0d21f471503dcca16b) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2097440
* nautilus : Enable CONFIG_BATTERY_REQUESTS_NIL_WHEN_DEADYongBeum Ha2019-12-031-0/+2
| | | | | | | | | | | | | | | | | | It takes 850ms~950ms to get valid RSOC after battery wake-up. Sometimes battery FG returns garbage data(1%) as RSOC and 0 value of desired current / voltage. Enable CONFIG_BATTERY_REQUESTS_NIL_WHEN_DEAD and CONFIG_BATTERY_DEAD_UNTIL_VALUE to continue charging. BUG=b:138413964 BRANCH=firmware-poppy-10431.B TEST=build & flash, check battery charging with dead battery Change-Id: Id0c4a1d8a78c24412a4a9c6dd3c13c666130b0dd Signed-off-by: YongBeum Ha <ybha@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1835071 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org>
* battery : Define CONFIG_BATTERY_DEAD_UNTIL_VALUEYongBeum Ha2019-11-253-0/+15
| | | | | | | | | | | | | | | | | | It takes 850ms~950ms to get valid RSOC after battery wake-up. Sometimes battery FG returns garbage data(1%) as RSOC and 0 value of desired current / voltage. Add CONFIG_BATTERY_DEAD_UNTIL_VALUE to continue charging. BUG=b:138413964 BRANCH=None TEST=build & flash, check battery charging with dead battery Change-Id: I0cbe30aa973499b0c27faf9b6da03a0344ad1065 Signed-off-by: YongBeum Ha <ybha@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1918985 Reviewed-by: Jett Rink <jettrink@chromium.org> (cherry picked from commit 89eee491e4f4744a0602d5362e39c5618cab06c1) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1932856
* nautilus : Do not override charge on dead batteryYongBeum Ha2019-09-201-0/+7
| | | | | | | | | | | | | | | | | | | | charger_profile_override() change charging voltage & current as battery temperature. The flag for bad temperature is set when battery is not responsive then the current is set to 0. Charge does not charge dead battery and the battery can't wake. Then the system can't power on with dead battery. BUG=b:138413964 BRANCH=none TEST=flash EC and check if dead battery is charged. Change-Id: I6af5c2d328df1c1be16261d581cdcafeb6036eaa Signed-off-by: YongBeum Ha <ybha@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1720176 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org>
* FIXUP: sensor: Adjust max_frequency based on EC performanceGwendal Grignou2019-05-301-1/+1
| | | | | | | | | | | | | | | When chaning the macro fro BMA255, the step was set to 125Hz, so it assumes the EC can support MEMS ODR set to 125Hz. This is not the case on poppy and nautilus in the poppy branch. BRANCH=poppy BUG=b:118205424,b:118851581,chromium:615059,b:131705379 TEST=Compile Change-Id: Ib60abb3919dc1ce049211d848fc4e4de2e5e51c0 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621507 Reviewed-by: Enrico Granata <egranata@chromium.org>
* bmm150: lower max frequency to match a frequency supported by BMI160Gwendal Grignou2019-05-301-2/+14
| | | | | | | | | | | | | | | | | | | | | | | Be sure the frequency we report does not need to be rounded up by BMI160 when BMM150 is behind BMI160. For instance, if we set 29Hz as maximum frequency, 29Hz will be rounded up to 50Hz (BMI160 samples at its own recognized frequency). At that speed, the BMM150 will lock up. BUG=b:120942904 BRANCH=none TEST=On eve with magnetometer check the maximum frequency reported by the magnetometer is 25Hz. Check the magnetometer is working with 'ectool motionsense 3' (cherry picked from commit e726fe4b2c1ea392ed059c4dbdedec253605cd7f) Reviewed-on: https://chromium-review.googlesource.com/1535161 Reviewed-by: Enrico Granata <egranata@chromium.org> Reviewed-by: Yilun Lin <yllin@chromium.org> Change-Id: I7025fe8a400e050907af490784521295d987051a Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621509
* driver: accel: Prevent ODR from crashing the ECGwendal Grignou2019-05-303-32/+21
| | | | | | | | | | | | | | | | | | | | | | For accelerometers which are interrupt driven, setting ODR too high may exhaust the EC and trigger the watchdog timer. Use config variable to verify the ODR requested is not too big. Return an error when setting unsupported parameters. BUG=b:112672627 BRANCH=nocturne,eve TEST=Without this change, ectool motionsense odr 0 500000 crashes the EC Now, it returns EC result 3 (INVALID_PARAM) (cherry picked from commit f932679e653a4b62fbe1fb28fba8a20d7a7e38c2) Reviewed-on: https://chromium-review.googlesource.com/1200068 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Change-Id: I64a4e522dcad450d619a7fc48a1330479f1cf81f Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621505 Reviewed-by: Enrico Granata <egranata@chromium.org>
* sensor: Adjust max_frequency based on EC performanceGwendal Grignou2019-05-3015-20/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Put in max_frequency a value that the sensor AND the EC support. BRANCH=none BUG=b:118205424,b:118851581,chromium:615059 TEST=Compile. Check all max sensors frequencies have been altered with: for i in $(grep -rh max_frequency board | cut -d '=' -f 2 | sort | \ uniq | grep FREQ | sed 's/FREQ.*//') ; do echo -n $i ; git show | grep -q $i || break; echo check done Check on nocturne accel max frequency is still correct. (cherry picked from commit 77b306b340ca428ba6785add204ccdce82185274) Conflicts: driver/mag_lis2mdl.h : driver not present yet. include/config.h : added defines. Reviewed-on: https://chromium-review.googlesource.com/1352063 Commit-Ready: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Jesse Schettler <jschettler@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org> Change-Id: I848396d9f150a2e94d430a8feeafc1087a6bf2c3 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621506 Reviewed-by: Enrico Granata <egranata@chromium.org>
* FIXUP: driver: lsm6dsm/lsm6dsl: Add FIFO supportGwendal Grignou2019-05-301-0/+2
| | | | | | | | | | | | | | | | | | | | Returns an error if the ODR set is less than 13Hz instead of silently put the sensor in suspend mode. BUG=b:77601149 BRANCH=None TEST=Check with accelrate we get an error instead of "Data rate for sensor 0: 0" (cherrypicked from a796f04b1 'FIXUP: driver: lsm6dsm/lsm6dsl: Add FIFO support') Reviewed-on: https://chromium-review.googlesource.com/1000399 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Change-Id: Iead740f4205bbce1cfbccf2407f2a3a0dcf0ddaf Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621263 Reviewed-by: Enrico Granata <egranata@chromium.org>
* driver: lsm6dsm: Allow roundup to work below 13HzGwendal Grignou2019-05-301-1/+1
| | | | | | | | | | | | | | | | | Recalculate ODR properly after rounding up the requested rate. BUG=b:112179405 TEST=Check ODR is set properly BRANCH=none (cherry picked from commit 837c7609f290d4694c3912aaeb4562fbf4b59b8e) Reviewed-on: https://chromium-review.googlesource.com/1200067 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Change-Id: I3f5abd5a1720f21d666cd3029000c2cec257c6f1 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621264 Reviewed-by: Enrico Granata <egranata@chromium.org>
* driver: lsm6dsm/lsm6dsl: Add FIFO supportMario Tesi2019-05-243-65/+446
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added FIFO support to Acc and Gyro with watermark interrupt management. Watermark is configurable setting macro CONFIG_ACCEL_FIFO_THRES properly (board.h) BUG=b:73546254 BRANCH=master TEST=Pass CTS test cheets_CTS_N.7.1_r15.x86.CtsHardwareTestCases on meowth. TEST=Tested on discovery (target stmems) BOARD with LSM6DSM connected to EC i2c master bus. Using motion sense console commands is possible to: - enable sensor (accelinit 0, accelinit 1 for acc and gyro) - set ODR (accelrate 0 x, accelrate 1 y where x, y are mHz) - show sensor data (accelinfo on <time> where time is in ms) Using this procedure is possible to see Green Led of Discovery Board Blinking each time an interrupt from FIFO arrives. To be sure to generate interrupt is better to use high ODR and low time in accelinfo. (cherry picked from 87e769a87 driver: lsm6dsm/lsm6dsl: Add FIFO support) Signed-off-by: Mario Tesi <mario.tesi@st.com> Reviewed-on: https://chromium-review.googlesource.com/467326 Commit-Ready: Gwendal Grignou <gwendal@chromium.org> Tested-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Change-Id: Icf95b0e889dc806206b8ca50e74636e6a2441a18 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621262 Reviewed-by: Enrico Granata <egranata@chromium.org>
* Revert "nautilus: Reduce FIFO size to 256 to pass cts.SensorBatchingTests"Gwendal Grignou2019-05-241-1/+1
| | | | | | | | | | | | | | | This reverts commit a948e0e1d3c97c3e59ef45dc5767c69a1bd2254a. This change is not needed since the proper fix is in Sensor HAL. BUG=b:123099878,b:124391215 TEST=Test CTS on nautilus BRANCH=poppy Change-Id: Ief0367c0e628d50ed24c13b22937c32d81ceb18f Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621256 Reviewed-by: Enrico Granata <egranata@chromium.org>
* Tell linker about the arch and CPU it's linking forPatrick Georgi2019-05-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | GCC 8.1's linker tries to rewrite the code to match the lowest common denominator, reintroducing references to __aeabi_idivmod and friends even on ARM revisions that don't need them. Tell it what it's linking for to keep it harmless. BUG=b:65441143 BRANCH=none TEST=make buildall works with gcc 8.1 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://chromium-review.googlesource.com/1061693 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Stefan Reinauer <reinauer@google.com> Change-Id: I7296aa80f587aa4f004fb20958714766793ab2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621257 Reviewed-by: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
* Shuffle const aroundPatrick Georgi2019-05-249-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | gcc 8.1 complains about duplicate const, and while some of these really are duplicate, others look like they were supposed to tighten the API contract so that variables are "const pointer to const data", but didn't have that effect. BUG=b:65441143 BRANCH=none TEST=building Chrome EC as part of upstream coreboot's build with a gcc 8.1 compiler now works (better. there are other issues left) Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://chromium-review.googlesource.com/1039812 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-by: Stefan Reinauer <reinauer@google.com> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> (cherry picked from commit 85ddb2ce533cb0276aab7780238ec98e1abec2fe) Change-Id: I6016c5f282516471746f08d5714ea07ebdd10331 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621258 Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>
* util/ecst: refactor path manglingPatrick Georgi2019-05-242-49/+53
| | | | | | | | | | | | | | | | | | | | ecst has two open-coded implementations of a function to inject a string into another string (that happens to be a path). Factor out and make sure that gcc 8.1's static analysis of string lengths is happy. BUG=b:65441143 BRANCH=none TEST=builds with gcc 8.1 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://chromium-review.googlesource.com/1061878 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Change-Id: I80581d26b6f75cac2c9530c18f94d12614aa1586 Reviewed-by: Stefan Reinauer <reinauer@google.com> Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621259 Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>
* nds32: make code build with gcc 8.1Patrick Georgi2019-05-242-0/+29
| | | | | | | | | | | | | | | | | | | | *** 21744 bytes still available in flash on reef_it8320 **** BUG=b:65441143 BRANCH=none TEST=make BOARD=reef_it8320 builds with gcc 8.1. not tested at all Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://chromium-review.googlesource.com/1077207 Commit-Ready: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Patrick Georgi <pgeorgi@chromium.org> Change-Id: Ie79ee23452574fd883c7f9425b8614346e46fdd7 Reviewed-by: Stefan Reinauer <reinauer@google.com> Signed-off-by: Gwendal Grignou <gwenal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621260 Reviewed-by: Patrick Georgi <pgeorgi@chromium.org> Tested-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
* driver: lsm6dsm: Fix ODR rate calculationGwendal Grignou2019-05-242-5/+3
| | | | | | | | | | | | | | | | | | rate was wrong, but round up was saving us. BUG=b:73546254 BRANCH=none TEST=Check register is set correctly even when roundup is 0. (cherry picked from commit 94eaba49b0166f7d1d7f5356f4b5c21468f419f1) Reviewed-on: https://chromium-review.googlesource.com/986917 Tested-by: Gwendal Grignou <gwendal@google.com> Reviewed-by: Gwendal Grignou <gwendal@google.com> Change-Id: I4cf11291345ccfaacd1fc9942a3f112b460268c1 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621261 Reviewed-by: Enrico Granata <egranata@chromium.org>
* Revert "scarlet: Hookup the vsync pin and the sync driver"Gwendal Grignou2019-05-243-23/+2
| | | | | | | | | | | | | | | | | | | This reverts commit 12291b201445c60cbdb8d98e6becb1d901163560. sync driver has been removed from the poppy branch. Conflicts: board/scarlet/board.c : remove VSYNC sensor board/scarlet/gpio.inc : Charger interrupt is hooked up. BUG=b:111220617 TEST=Compile BRANCH=poppy Change-Id: Ibaf18fb7aee9a463256398645362d0260bd3d8aa Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621255 Reviewed-by: Enrico Granata <egranata@chromium.org>
* bmi160: Fix ODR to REG when rate is less than 100HzGwendal Grignou2019-05-241-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The calculation was wrong and always returned the next value. We were lucky that we always ask to round up, so the frequencies were rounded up from the get go. BUG=b:120942904 BRANCH=none TEST=Test with several ODR for correctness: cout << "10:" << BMI160_ODR_TO_REG(10000) << ":" << BMI160_REG_TO_ODR(BMI160_ODR_TO_REG(10000)) << "\n" << "29:" << BMI160_ODR_TO_REG(29000) << ":" << BMI160_REG_TO_ODR(BMI160_ODR_TO_REG(29000)) << "\n" << "59:" << BMI160_ODR_TO_REG(59000) << ":" << BMI160_REG_TO_ODR(BMI160_ODR_TO_REG(59000)) << "\n" << "99:" << BMI160_ODR_TO_REG(99000) << ":" << BMI160_REG_TO_ODR(BMI160_ODR_TO_REG(99000)) << "\n" << "109:" << BMI160_ODR_TO_REG(109000) << ":" << BMI160_REG_TO_ODR(BMI160_ODR_TO_REG(109000)) << "\n" << "209:" << BMI160_ODR_TO_REG(209000) << ":" << BMI160_REG_TO_ODR(BMI160_ODR_TO_REG(209000)) << "\n" ; Returns: 10:4:6250 29:6:25000 59:7:50000 99:7:50000 109:8:100000 209:9:200000 (cherry picked from commit 0e99e97634135c9d4e6b60dcd6837bb76d91acf7) Reviewed-on: https://chromium-review.googlesource.com/1535160 Reviewed-by: Yilun Lin <yllin@chromium.org> Change-Id: I898d1077af78ab1d0e65ac0e8f7714a2a3b042b3 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621508
* nautilus: Reduce FIFO size to 256 to pass cts.SensorBatchingTestsGwendal Grignou2019-01-251-1/+1
| | | | | | | | | | | | | | | | | | When FIFO is set to 512, at 50Hz, there is ~340 events in each dump, 7s between events dump. This is too long for the test, it fails with: ... Failed due to (insufficient events 346/400, ) ... BRANCH=poppy TEST=Pass cts.SensorBatchingTests BUG=b:123172158 Change-Id: I79d385a4dd69cc18ab7c8eec626f959334929ea5 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1431873 Reviewed-by: Enrico Granata <egranata@chromium.org>
* poppy: Increase console buffer size to 4096 bytesNicolas Boichat2019-01-171-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | Increase the size from 1024 to 4096 to reduce the likelihood of overflows. To make space for the larger buffer, we reduce CONFIG_ACCEL_FIFO to 512 entries (from 1024 entries: saves 4096 bytes of RAM). grep shared_mem_buf build/lux/RW/ec.RW.smap Before this patch: 200c74e0 D __shared_mem_buf After this patch: 200c70e0 D __shared_mem_buf (we saved 1024 bytes of RAM) BRANCH=poppy BUG=b:77159941, b:120097505 TEST=Flash lux, see that we do not lose EC logs in /var/log/cros_ec.log. Change-Id: I320c370369364b280e59f490a86f057fbb502da3 Reviewed-on: https://chromium-review.googlesource.com/c/1418254 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> Commit-Queue: Enrico Granata <egranata@chromium.org> Tested-by: Enrico Granata <egranata@chromium.org>
* stm32: usb_hid_touchpad: add confidenceWei-Han Chen2018-11-195-43/+54
| | | | | | | | | | | | | | | | | | | | `confidence` is expected from a PTP-compliant touchpad BRANCH=none BUG=b:70482333 BUG=chromium:904711 TEST=manual Signed-off-by: Wei-Han Chen <stimim@chromium.org> Change-Id: Ibe7166f43cae5fb36bbcc4e6dfd9ae6525a7225e Reviewed-on: https://chromium-review.googlesource.com/1188170 Commit-Ready: Wei-Han Chen <stimim@chromium.org> Tested-by: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1333949 Commit-Queue: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
* usb_hid_touchpad: make max pressure configurableWei-Han Chen2018-11-193-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | Maximum pressure is now defined by CONFIG_USB_HID_TOUCHPAD_LOGICAL_MAX_Z. `hammer` is the only board using usb_hid_touchpad, the board.h is updated to reflect the change (for old boards "HAMMER" and "STAFF", we keep the value 1023, so they should behave the same). BRANCH=none BUG=b:70482333 BUG=chromium:904711 TEST=make BOARD=whiskers TEST=make buildall -j TEST=manually on device Signed-off-by: Wei-Han Chen <stimim@chromium.org> Change-Id: I70b0a5b19dfbe3ac731ef2ead08578a7f7a1cb0b Reviewed-on: https://chromium-review.googlesource.com/1141676 Commit-Ready: Wei-Han Chen <stimim@chromium.org> Tested-by: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1333948 Commit-Queue: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
* usb_hid_touchpad.c: change report_desc to USAGE(touch pad)Wei-Han Chen2018-11-191-1/+1
| | | | | | | | | | | | | | | | | BRANCH=none BUG=b:70482333 BUG=chromium:904711 TEST=tested on device Signed-off-by: Wei-Han Chen <stimim@chromium.org> Change-Id: Ifc1ece2de00979e171f0a29226d927da3951515e Reviewed-on: https://chromium-review.googlesource.com/1124267 Commit-Ready: Wei-Han Chen <stimim@chromium.org> Tested-by: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> (cherry picked from commit 925798c329cd6780663144ca9d90dbfa90560b1b) Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1333947
* Poppy: Remove VR decay for V1.00A power railRoy Mingi Park2018-11-131-18/+0
| | | | | | | | | | | | | | | | | | | | This patches removes the VR decay for V1.00A power rail when system enters low power mode. According to PAG #543977, V1.00A power has tolerance from -6.7% to 5% but it doens't support LPM like VccPRIM_CORE which could down to 0.75v in low power mode. BUG=b:116180071 BRANCH=None TEST=Measure V1.00A power rail when system is in S0iX and ensure it keeps at 1.0v Change-Id: Ib1fca8b849e9602abcef221a7e3d0dc0a0c50690 Signed-off-by: Roy Mingi Park <roy.mingi.park@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/1323850 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Trybot-Ready: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* nautilus : cc1 / cc2 is toggling when system is offYB.Ha2018-10-221-1/+0
| | | | | | | | | | | | Remove option "CONFIG_USB_PD_DUAL_ROLE_AUTO_TOGGLE" BUG=b:116177102 TEST=Build & flash EC then check cc1/cc2 on S5. Change-Id: Ib619749904a474865eda125950fc1e0e76983bb0 Signed-off-by: YB.Ha <ybha@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/1278416 Reviewed-by: Philip Chen <philipchen@chromium.org>
* motion: Wake up motion task when sampling rate changesGwendal Grignou2018-10-041-0/+4
| | | | | | | | | | | | | | | | | | | | | | Wake up motion task to evacuate pending samples to the host as soon as the sampling rate changes. It is required for CST testSanitizedContinuousEventsUidIdle to pass, it assumes only new samples will be present. BUG=b:111422556 BRANCH=eve TEST=cheets_CTS_P.9.0_r2.x86.CtsSensorTestCases passes on eve-arcnext. Change-Id: I34e51c0db42fe1a8d5abc91c6d80bcce974da099 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1217604 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> (cherry picked from commit e18316ecc7f7f6d7226fc741570a94c5024d42e8) Reviewed-on: https://chromium-review.googlesource.com/c/1259384 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Trybot-Ready: Philip Chen <philipchen@chromium.org>
* motion: Change ODR only within the motion sensor taskGwendal Grignou2018-10-042-25/+14
| | | | | | | | | | | | | | | | | | | | | | | When changing ODR for one sensor, we insert a timestamp in the FIFO. That timestamp can be misinterpreted by other sensor while in batch mode, condensing all events in a small timezone. Also, it can lead the motionsense stack to insert timestamp from the past. BUG=b:111422556,chromium:562245 TEST=Check cheets_CTS_P.9.0_r2.x86.CtsSensorTestCases pass on eve. BRANCH=eve Change-Id: If76aa3abcedbe463321ccbb1c183dc16edda8693 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1204692 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> (cherry picked from commit f62f2ebbecb131956a5edc4bf60c094bc67972a1) Reviewed-on: https://chromium-review.googlesource.com/c/1259383 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Trybot-Ready: Philip Chen <philipchen@chromium.org>
* base_detect: Expose console command to force state.RaviChandra Sadineni2018-09-278-16/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In an effort to test wake sources on any given platform, this CL exposes console command to set the base state. This console command can then be invoked by autottests from the uart interface. We have two implementations for managing base status. One is interrupt driven while the other is a polling via a task. Boards current implementations then are: interrupts: lux, soraka, cheza polling task: nocturne, zoombini For forcing base connect and disconnect, interrupts: Disable interrupts and set forced base state. polling task: Stop periodic task and set forced base state. On reset, interrupts: Schedule deferred task immediately and enable interrupts. polling task: Clear forced base state and begin rescheduling periodic task. Signed-off-by: RaviChandra Sadineni <ravisadineni@google.com> BRANCH=poppy,nocturne BUG=chromium:820668, b:37223093 TEST=Tested on lux, soraka and nocturne basestate a : attaches the lid, reflected in ui. basestate d : detaches the lid, reflected in ui. basestate r : resets to the correct state. Wakes the device up on lux and nocturne and soraka. orig-Change-Id: Iab698e103a50b8d22bf216a6f816998cb158e38a orig-Reviewed-on: https://chromium-review.googlesource.com/1184172 Change-Id: I13a12c302fb6c50b11a70f15c218eb72079f2c17 Reviewed-on: https://chromium-review.googlesource.com/1240456 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org> Commit-Queue: Ravi Chandra Sadineni <ravisadineni@chromium.org> Tested-by: Ravi Chandra Sadineni <ravisadineni@chromium.org> Trybot-Ready: Ravi Chandra Sadineni <ravisadineni@chromium.org>
* touchpad_elan: Fix the trace number accessing for width/hight propertyKT Liao2018-08-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | Base on Elan I2C driver and Elan touchpad spec, the x trace number of touching object is in the low nibble of byte. And y trace number is in the high nibble. This is a minor bug and difficult to find in operation. I fix the byte accessing to make it right in palm detection Signed-off-by: KT Liao <kt.liao@emc.com.tw> BRANCH=poppy BUG=None TEST=Test hammer in EVTEST and check MAJOR/MINOR Change-Id: I83e5e1f224eaf815914e7001234cdc1b1af22660 Reviewed-on: https://chromium-review.googlesource.com/659478 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> (cherry picked from commit b8af74cc4cf7a304ce8087fc60248ea037aad566) Reviewed-on: https://chromium-review.googlesource.com/1183543 Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
* keyboard_8042: Clear buffer before adding command byteFurquan Shaikh2018-07-251-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the host attempts to read CTR, first clear the keyboard buffer to ensure that we do not have any stale data in it. If the buffered data is not cleared, host could end up interpreting the keypress data as CTR thus resulting in unwanted side-effects. Reason for putting in this change is because Linux kernel does not disable keyboard scanning when doing a reboot or poweroff. Now, if user keeps pressing keys while the system is booting up, kernel could end up reading key press data as CTR thus resulting in keyboard being disabled on boot-up. This change ensures that keyboard buffer is cleared before adding CTR data to it. BUG=b:111228655 BRANCH=poppy,eve,nami TEST=Verified on nautilus that keyboard is still functional after doing a reboot from AP shell and continuously pressing keys while system is booting up in normal mode. Change-Id: I5cbc904629fbd40b39625e37abccb80c83447d39 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://chromium-review.googlesource.com/1149561 Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Trybot-Ready: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Philip Chen <philipchen@chromium.org>
* nautilus: Remove the unused GPIO USB_POWERON_LPhilip Chen2018-07-172-6/+1
| | | | | | | | | | | | | | BUG=b:111433611 BRANCH=poppy TEST=manually confirm USB-A port still works Change-Id: I70146f696056e526df08831847650710dea4a8ae Signed-off-by: Philip Chen <philipchen@google.com> Reviewed-on: https://chromium-review.googlesource.com/1140794 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Trybot-Ready: Philip Chen <philipchen@chromium.org>
* Revert "sensor: bmi160: Don't batch data on the sensor"Alexandru M Stan2018-07-161-2/+3
| | | | | | | | | | | | | | | | | | | | This reverts commit e6a755c60094fa397f422b83d5aeb269cea68e82. A few EC CLs made some bad assumption and caused CTS to fail (without realizing it in time). This is a series to revert those bad CLs and other CLs that depend on it. They might reland back soon. BUG=b/111220617 TEST=With series, CTS passes once again Change-Id: I9c27fb38fb4d67ed1b0df9f830982c23c66be7a3 Signed-off-by: Alexandru M Stan <amstan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1134078 Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* Revert "motion: remove load_fifo"Alexandru M Stan2018-07-166-234/+227
| | | | | | | | | | | | | | | | | | | | This reverts commit 1d89369b51135d979c5adcd8cc7b9c6d5853a467. A few EC CLs made some bad assumption and caused CTS to fail (without realizing it in time). This is a series to revert those bad CLs and other CLs that depend on it. They might reland back soon. BUG=b/111220617 TEST=With series, CTS passes once again Change-Id: I0b549d036a1bfd2126b50afe0da73c21188745e8 Signed-off-by: Alexandru M Stan <amstan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1134057 Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* Revert "motion: Lower jitter of Sensor->EC timestamp"Alexandru M Stan2018-07-165-58/+23
| | | | | | | | | | | | | | | | | | | | This reverts commit 05c410f34add5d4b2a50b248ab79c9436a0cf776. A few EC CLs made some bad assumption and caused CTS to fail (without realizing it in time). This is a series to revert those bad CLs and other CLs that depend on it. They might reland back soon. BUG=b/111220617 TEST=With series, CTS passes once again Change-Id: Id0d98eacf388d6e7778cf23c5dfcefca9e78a757 Signed-off-by: Alexandru M Stan <amstan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1134056 Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* Revert "sensors: Add driver for SYNC"Alexandru M Stan2018-07-164-147/+2
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2778b192f39ea01fc870153d4c21b42fc2149590. A few EC CLs made some bad assumption and caused CTS to fail (without realizing it in time). This is a series to revert those bad CLs and other CLs that depend on it. They might reland back soon. Conflicts: include/config.h BUG=b/111220617 TEST=With series, CTS passes once again Change-Id: Ieeb6515c12a544a99efcfc254bbdea520b7e05ee Signed-off-by: Alexandru M Stan <amstan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1134055 Reviewed-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org>
* test: Make it possible to run rsa tests on hammer boardNicolas Boichat2018-06-292-1/+3
| | | | | | | | | | | | | | | | | | BRANCH=poppy BUG=b:35647963 BUG=b:77608104 TEST=make run-rsa run-rsa3 TEST=make BOARD=hammer test-rsa3, test on board Change-Id: Id4bd8d5f550dbc6569d88ced114849b3b6411b2f Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1071410 Reviewed-by: Vincent Palatin <vpalatin@chromium.org> (cherry picked from commit 1d2c13a1630a1a6222411e1c03186cb9b1f576e0) [conflict in test/build.mk as the CLs were cherry-picked in the wrong order] Reviewed-on: https://chromium-review.googlesource.com/1119505 Reviewed-by: Furquan Shaikh <furquan@chromium.org>
* nautilus: remove code for supporting old board(BDID 0/1/2/3)YB.Ha2018-06-282-49/+6
| | | | | | | | | | | | | BDID 0/1/2/3 will reuse for hopper-LTE. BUG=b:110715659 BRANCH=poppy TEST=Build & flash EC then check if working correctly. Change-Id: I015d96a2bafd881adc62a55116f8f0b4d606ca1a Signed-off-by: YB.Ha <ybha@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/1116500 Reviewed-by: Philip Chen <philipchen@chromium.org>
* nautilus: Only disable keyscanning when not in S0.Aseda Aboagye2018-06-111-6/+13
| | | | | | | | | | | | | | | | | | | | Devices should not disable keyboard scanning when the chipset is in S0. Thy should keep the keyboard enabled and continue to forward the keys to the AP such that the AP can make the decision whether to ignore them or not. BUG=b:79670788 BRANCH=poppy TEST=Flash nautilus; Connect external display, reduce brightness on internal display to make external display the primary display; Enter tablet mode, verify that keyboard presses still show up in the UI. Change-Id: I452299726c6e8b388eb1061c23bed013228c2a2c Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/1089823 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Alexandru M Stan <amstan@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* nautilus: change the reference value, NOISY_MAGNITUDE_DEVIATIONInno Park2018-06-083-15/+24
| | | | | | | | | | | | | | | | | | | | Changed NOISY_MAGNITUDE_DEVIATION from 1 to 1.5. Current value seems to be set too low. So ec could regard lid angle as unreliable even when sensors are at rest. BUG=b:79670788 BRANCH=firmware-poppy-10431.B TEST=Build & flash EC then ectool motionsense Change-Id: I07c3e5c2149e7dade567592a437d36d3a294b7af Signed-off-by: Inno Park <ih.yoo.park@samsung.com> Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/1065954 Tested-by: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Ih-Yoo Park <ih.yoo.park@samsung.corp-partner.google.com> Reviewed-by: Ih-Yoo Park <ih.yoo.park@samsung.corp-partner.google.com> Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Ih-Yoo Park <ih.yoo.park@samsung.corp-partner.google.com>
View Lorry Controller Status