<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/coreboot/chrome-ec.git/include/lid_angle.h, branch main</title>
<subtitle>review.coreboot.org: chrome-ec.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/'/>
<entry>
<title>Update license boilerplate text in source code files</title>
<updated>2022-09-12T20:11:50+00:00</updated>
<author>
<name>Mike Frysinger</name>
<email>vapier@chromium.org</email>
</author>
<published>2022-09-12T18:54:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=71b2ef709dcb14260f5fdaa3ab4ced005a29fb46'/>
<id>71b2ef709dcb14260f5fdaa3ab4ced005a29fb46</id>
<content type='text'>
Normally we don't do this, but enough changes have accumulated that
we're doing a tree-wide one-off update of the name &amp; style.

BRANCH=none
BUG=chromium:1098010
TEST=`repo upload` works

Change-Id: Icd3a1723c20595356af83d190b2c6a9078b3013b
Signed-off-by: Mike Frysinger &lt;vapier@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891203
Reviewed-by: Jeremy Bettis &lt;jbettis@chromium.org&gt;
Reviewed-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Normally we don't do this, but enough changes have accumulated that
we're doing a tree-wide one-off update of the name &amp; style.

BRANCH=none
BUG=chromium:1098010
TEST=`repo upload` works

Change-Id: Icd3a1723c20595356af83d190b2c6a9078b3013b
Signed-off-by: Mike Frysinger &lt;vapier@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891203
Reviewed-by: Jeremy Bettis &lt;jbettis@chromium.org&gt;
Reviewed-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>include/lid_angle.h: Format with clang-format</title>
<updated>2022-07-01T21:17:57+00:00</updated>
<author>
<name>Jack Rosenthal</name>
<email>jrosenth@chromium.org</email>
</author>
<published>2022-06-27T21:12:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=e1e7362a5a27774d171bc38c28926d3db4c63cb1'/>
<id>e1e7362a5a27774d171bc38c28926d3db4c63cb1</id>
<content type='text'>
BUG=b:236386294
BRANCH=none
TEST=none

Change-Id: I21d887e8f73fae04eaccf06f57e965aa85c01717
Signed-off-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730301
Reviewed-by: Jeremy Bettis &lt;jbettis@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
BUG=b:236386294
BRANCH=none
TEST=none

Change-Id: I21d887e8f73fae04eaccf06f57e965aa85c01717
Signed-off-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730301
Reviewed-by: Jeremy Bettis &lt;jbettis@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lid_angle: Create a common callback for lid angle changes</title>
<updated>2021-08-05T00:13:33+00:00</updated>
<author>
<name>Wai-Hong Tam</name>
<email>waihong@google.com</email>
</author>
<published>2021-08-04T00:17:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=2eb53a39662b905c65015bafb5f73ab2324d369c'/>
<id>2eb53a39662b905c65015bafb5f73ab2324d369c</id>
<content type='text'>
Each board defines its own callback lid_angle_peripheral_enable().
The implementation is very similar. Create a common implementation
and reduce the duplicated code.

This CL removes the board callbacks which are identifical to the
common callback. If it is slightly different, keep it and add
the __override tag.

The check of TEST_BUILD is unnecessary as the board callback is not
linked in the test build.

BRANCH=None
BUG=b:194922043
TEST=Build all the images.

Change-Id: I73d381730f35b80eff69399cdfc5fb54f839aee0
Signed-off-by: Wai-Hong Tam &lt;waihong@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069175
Reviewed-by: Aseda Aboagye &lt;aaboagye@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Each board defines its own callback lid_angle_peripheral_enable().
The implementation is very similar. Create a common implementation
and reduce the duplicated code.

This CL removes the board callbacks which are identifical to the
common callback. If it is slightly different, keep it and add
the __override tag.

The check of TEST_BUILD is unnecessary as the board callback is not
linked in the test build.

BRANCH=None
BUG=b:194922043
TEST=Build all the images.

Change-Id: I73d381730f35b80eff69399cdfc5fb54f839aee0
Signed-off-by: Wai-Hong Tam &lt;waihong@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069175
Reviewed-by: Aseda Aboagye &lt;aaboagye@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>LICENSE: remove unnecessary (c) after Copyright</title>
<updated>2019-06-19T00:30:43+00:00</updated>
<author>
<name>Tom Hughes</name>
<email>tomhughes@chromium.org</email>
</author>
<published>2019-06-18T18:41:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=f36a4e530c40284228b6954564cd3836b4588401'/>
<id>f36a4e530c40284228b6954564cd3836b4588401</id>
<content type='text'>
Ran the following command:
git grep -l 'Copyright (c)' | \
  xargs sed -i 's/Copyright (c)/Copyright/g'

BRANCH=none
BUG=none
TEST=make buildall -j

Change-Id: I6cc4a0f7e8b30d5b5f97d53c031c299f3e164ca7
Signed-off-by: Tom Hughes &lt;tomhughes@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1663262
Reviewed-by: Daisuke Nojiri &lt;dnojiri@chromium.org&gt;
Reviewed-by: Aseda Aboagye &lt;aaboagye@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ran the following command:
git grep -l 'Copyright (c)' | \
  xargs sed -i 's/Copyright (c)/Copyright/g'

BRANCH=none
BUG=none
TEST=make buildall -j

Change-Id: I6cc4a0f7e8b30d5b5f97d53c031c299f3e164ca7
Signed-off-by: Tom Hughes &lt;tomhughes@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1663262
Reviewed-by: Daisuke Nojiri &lt;dnojiri@chromium.org&gt;
Reviewed-by: Aseda Aboagye &lt;aaboagye@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Cyan: Added Clamshell/Tablet mode support</title>
<updated>2015-08-10T20:42:18+00:00</updated>
<author>
<name>li feng</name>
<email>li1.feng@intel.com</email>
</author>
<published>2015-07-02T20:29:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=2911e38022a950d9f0e85ed7480829bf21d34a1f'/>
<id>2911e38022a950d9f0e85ed7480829bf21d34a1f</id>
<content type='text'>
Enabled lid angle calculation. Clamshell/Tablet mode is decided by lid angle.
Accelerometers are set to be active in S3 also.
Trackpad is enabled/disabled by GPIO TP_INT_DISABLE.
Keyboard scan and trackpad are enabled in clamshell mode and disabled in
tablet mode.
Removed enable_keyboard() since keyboard is enabled in clamshell S0 and
S3.

BUG=chrome-os-partner:41353
TEST=Verify in clamshell mode, system can be waken up from S3 by keyboard/trackpad;
And not tablet mode.
BRANCH=None

Change-Id: Ic5fb5a562e8426288eae2fb9815a213fe5033955
Signed-off-by: li feng &lt;li1.feng@intel.com&gt;
Signed-off-by: Shamile Khan &lt;shamile.khan@intel.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/287341
Reviewed-by: Shawn N &lt;shawnn@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enabled lid angle calculation. Clamshell/Tablet mode is decided by lid angle.
Accelerometers are set to be active in S3 also.
Trackpad is enabled/disabled by GPIO TP_INT_DISABLE.
Keyboard scan and trackpad are enabled in clamshell mode and disabled in
tablet mode.
Removed enable_keyboard() since keyboard is enabled in clamshell S0 and
S3.

BUG=chrome-os-partner:41353
TEST=Verify in clamshell mode, system can be waken up from S3 by keyboard/trackpad;
And not tablet mode.
BRANCH=None

Change-Id: Ic5fb5a562e8426288eae2fb9815a213fe5033955
Signed-off-by: li feng &lt;li1.feng@intel.com&gt;
Signed-off-by: Shamile Khan &lt;shamile.khan@intel.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/287341
Reviewed-by: Shawn N &lt;shawnn@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Convert motion sense calculations to fixed point.</title>
<updated>2015-02-05T19:41:41+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2015-01-28T23:23:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=fd6a6900f786d47fc5364f9013356a741da5c113'/>
<id>fd6a6900f786d47fc5364f9013356a741da5c113</id>
<content type='text'>
Motion sense calculations do not require huge amounts of precision, so
fixed point is plenty accurate.  And fixed point works on Cortex-M0,
which lacks a FPU.

BUG=chrome-os-partner:36126
BRANCH=minnie (samus already works with the FPU, but could grab this if we
       want additional testing)
TEST=manual
    1. Boot system
    2. At EC console: accelinfo on 250
    3. Move lid through several different angles (30 degrees to max open) and
       see that it updates correctly and relatively smoothly.  A few degrees
       of angle jitter is normal.
    4. At several angles, rotate the chromebook around and see that the lid
       angle remains relatively stable.
    5. If the hinge is made normal to the ground (or within 15 degrees of
       vertical), the angle should read 500, since the acceleration vectors
       don't yield good results in that orientation (for either fixed or float
       math).
    And run 'make buildall -j', which tests arc_cos() and lid angle calculations

Change-Id: I70a0d08b8914629a3e21ae5578cbe8e50f29ad68
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/244116
Reviewed-by: Alec Berg &lt;alecaberg@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Motion sense calculations do not require huge amounts of precision, so
fixed point is plenty accurate.  And fixed point works on Cortex-M0,
which lacks a FPU.

BUG=chrome-os-partner:36126
BRANCH=minnie (samus already works with the FPU, but could grab this if we
       want additional testing)
TEST=manual
    1. Boot system
    2. At EC console: accelinfo on 250
    3. Move lid through several different angles (30 degrees to max open) and
       see that it updates correctly and relatively smoothly.  A few degrees
       of angle jitter is normal.
    4. At several angles, rotate the chromebook around and see that the lid
       angle remains relatively stable.
    5. If the hinge is made normal to the ground (or within 15 degrees of
       vertical), the angle should read 500, since the acceleration vectors
       don't yield good results in that orientation (for either fixed or float
       math).
    And run 'make buildall -j', which tests arc_cos() and lid angle calculations

Change-Id: I70a0d08b8914629a3e21ae5578cbe8e50f29ad68
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/244116
Reviewed-by: Alec Berg &lt;alecaberg@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>accel: Add host cmd for setting lid angle threshold for disabling keyboard wake</title>
<updated>2014-04-11T04:00:44+00:00</updated>
<author>
<name>Alec Berg</name>
<email>alecaberg@chromium.org</email>
</author>
<published>2014-04-08T17:28:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=eaa645e0cc092fbaaa1a81ed5308831e71ebf86c'/>
<id>eaa645e0cc092fbaaa1a81ed5308831e71ebf86c</id>
<content type='text'>
Added a sub-command to the motionsense host command (0x2b) for getting/setting
the lid angle at which the keyboard is disabled as a wake source in S3. The
value can be anywhere from 0 to 360 degrees, default set to 180. Note, this
only takes affect for boards that have CONFIG_LID_ANGLE_KEY_SCAN defined.
Modified ectool motionsense command to use new host sub-command.

Also modified the lid angle measurement in the EC to be in the range [0, 360],
instead of [-180, 180], and changed casting of lid angle as an int to round
to nearest.

BUG=none
BRANCH=rambi
TEST=Tested on a glimmer:
Using default keyboard disable lid angle of 180, made sure that when lid
angle is past 180, key presses do not wake system, and when lid angle is
less than 180, key presses do wake up system.

Used ectool motionsense kb_wake to set the keyboard disable lid angle to 0.
Made sure that keyboard never wakes up the system. Set keyboard disable lid
angle to 360 and made sure that the keyboard always wakes up the system.

Change-Id: I437164c6e38c29169ef6e20e86c9cf2a1c78f86e
Signed-off-by: Alec Berg &lt;alecaberg@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/193663
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/194172
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Added a sub-command to the motionsense host command (0x2b) for getting/setting
the lid angle at which the keyboard is disabled as a wake source in S3. The
value can be anywhere from 0 to 360 degrees, default set to 180. Note, this
only takes affect for boards that have CONFIG_LID_ANGLE_KEY_SCAN defined.
Modified ectool motionsense command to use new host sub-command.

Also modified the lid angle measurement in the EC to be in the range [0, 360],
instead of [-180, 180], and changed casting of lid angle as an int to round
to nearest.

BUG=none
BRANCH=rambi
TEST=Tested on a glimmer:
Using default keyboard disable lid angle of 180, made sure that when lid
angle is past 180, key presses do not wake system, and when lid angle is
less than 180, key presses do wake up system.

Used ectool motionsense kb_wake to set the keyboard disable lid angle to 0.
Made sure that keyboard never wakes up the system. Set keyboard disable lid
angle to 360 and made sure that the keyboard always wakes up the system.

Change-Id: I437164c6e38c29169ef6e20e86c9cf2a1c78f86e
Signed-off-by: Alec Berg &lt;alecaberg@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/193663
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/194172
</pre>
</div>
</content>
</entry>
<entry>
<title>rambi: glimmer: Disable key scanning in suspend when lid is open</title>
<updated>2014-03-27T18:44:14+00:00</updated>
<author>
<name>Alec Berg</name>
<email>alecaberg@chromium.org</email>
</author>
<published>2014-03-14T16:27:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=242f1957714153075e2eb9d5541923d28f05ec7c'/>
<id>242f1957714153075e2eb9d5541923d28f05ec7c</id>
<content type='text'>
Added ability to disable the keyboard to wake from suspend when the lid
is outside a certain angle range. This has been added to glimmer by
defining CONFIG_LID_ANGLE_KEY_SCAN in its board.h.

Also modified the lid angle calculation to include a reliability
flag which can be used to tell when the hinge aligns too closely
with gravity and the lid angle value is unreliable.

BUG=none
BRANCH=rambi
TEST=Tested on a glimmer:

In S3, verified that when the lid is open past ~180 deg, the keyboard
does not wake the machine. Also verified that if you align hinge with
gravity, the keyboard enabled/disabled status remains the same (since
we can't actually trust the lid angle value).

Change-Id: I45b2c7c3c4bbcae61d3a0f8b5baa461ab8dabfb0
Original-Change-Id: If1a1592d259902d38941936961854b81b3a75b95
Signed-off-by: Alec Berg &lt;alecaberg@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/190061
Reviewed-on: https://chromium-review.googlesource.com/191612
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Added ability to disable the keyboard to wake from suspend when the lid
is outside a certain angle range. This has been added to glimmer by
defining CONFIG_LID_ANGLE_KEY_SCAN in its board.h.

Also modified the lid angle calculation to include a reliability
flag which can be used to tell when the hinge aligns too closely
with gravity and the lid angle value is unreliable.

BUG=none
BRANCH=rambi
TEST=Tested on a glimmer:

In S3, verified that when the lid is open past ~180 deg, the keyboard
does not wake the machine. Also verified that if you align hinge with
gravity, the keyboard enabled/disabled status remains the same (since
we can't actually trust the lid angle value).

Change-Id: I45b2c7c3c4bbcae61d3a0f8b5baa461ab8dabfb0
Original-Change-Id: If1a1592d259902d38941936961854b81b3a75b95
Signed-off-by: Alec Berg &lt;alecaberg@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/190061
Reviewed-on: https://chromium-review.googlesource.com/191612
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
