delta/coreboot/chrome-ec.git, branch release-R85-13310.B-master

Swap system_jumped_to_this_image with system_jumped_late

2020-06-26T04:07:10+00:00

EFS2 boards need to call system_jumped_late in HOOK_INIT to avoid
running init code twice per boot.

system_jumped_to_this_image and system_jumped_late are functionally
equivalent for non EFS2 boards.

This patch will prevent system_jumped_to_this_image from being used
for EFS2 boards when code is copied from a past project.

BUG=chromium:1072743
BRANCH=none
TEST=buildall

Signed-off-by: Daisuke Nojiri 
Change-Id: I73fb5cedc5325d1c80825f9346954013046ee1df
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2267685
Reviewed-by: Keith Short

Swap system_jumped_to_this_image with _late for common code

2020-06-26T04:07:08+00:00

EFS2 boards need to call system_jumped_late in HOOK_INIT to avoid
running init code twice per boot.

system_jumped_to_this_image and system_jumped_late are functionally
equivalent for non EFS2 boards.

BUG=chromium:1072743
BRANCH=none
TEST=buildall

Signed-off-by: Daisuke Nojiri 
Change-Id: Iecfd4f6d3e9d43cea535cfd503d6bcf7b79bc4fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2267684
Reviewed-by: Keith Short

EFS2: Ping cr50 beforehand in case it's asleep

2020-06-26T03:13:06+00:00

There are situations where EC resets while Cr50 is in sleep. In such
cases, Cr50 doesn't get ready for ec-comm until EC talks to Cr50 thus
EC may time out after 5 attempts.

This patch makes EC toggle PACKET_MODE_EN proactively in case Cr50 is
in sleep.

BUG=b:158486465
BRANCH=none
TEST=Shutdown Trembyle, hibernate EC, press power button.
     EC receives response from Cr50 without timeout.

Change-Id: I02fcfdc00e2596d6ca6a7be4e0a8996654639984
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2264893
Reviewed-by: Eric Peers 
Tested-by: Eric Peers 
Tested-by: Daisuke Nojiri 
Auto-Submit: Daisuke Nojiri 
Commit-Queue: Daisuke Nojiri

tcpmv1: string reduction

2020-06-26T02:31:22+00:00

De-duplicate some output strings to reduce flash sizes.

BUG=none
BRANCH=none
TEST=make buildall -j

Signed-off-by: Keith Short 
Change-Id: Ide613f2641cdf7190603c37ab774121a4bd639ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2267680
Reviewed-by: Abe Levkoy 
Commit-Queue: Abe Levkoy

tcpmv2: Add delay when exiting low-power mode

2020-06-26T02:31:20+00:00

Adds a 25ms delay when exiting low power mode. Some TCPCs are slow to
update the CC_STATUS register when exiting low power mode when a non-PD
charger is connected.

BUG=b:155364505
BRANCH=none
TEST=make buildall
TEST=connect 15W non-PD charger to Volteer C1 port. Verify charging
starts.

Signed-off-by: Keith Short 
Change-Id: I0d4514447799acd60ffbcd52a62bff8bffb58b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2259272
Reviewed-by: Denis Brockus

TCPMv2: Clear VDM timeout flag in ready

2020-06-25T23:57:56+00:00

The VDM timeout flag represents an issue within a single AMS and should
therefore be cleared on return to the READY states.

BRANCH=None
BUG=None
TEST=on zork, timeout on cable identity VDM doesn't effect future SOP
identity calls

Signed-off-by: Diana Z 
Change-Id: Ic065fbeeb9e1df88595bffbbbf6c3827e9bb17af
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2267628
Commit-Queue: Denis Brockus 
Reviewed-by: Denis Brockus

TCPMv2: Report message discard to the PE

2020-06-25T23:57:54+00:00

This commit creates a reporting function for the PRL to let the PE know
when messages have been discarded.

States will have to handle message discard internally since the response
depends on the portion of the AMS sequence they're in.  For some states
which begin AMSes, a new shared parent has been added which runs the
sender response timer and checks discard for the child.

More states (and discard mid-AMS) are expected to be added in future
CLs.

The new parent state saves an average of 124 bytes of flash space.

BRANCH=None
BUG=b:158248741,b:157228506
TEST=on waddledoo, Dell dock no longer soft resets during power role
swap

Signed-off-by: Diana Z 
Change-Id: I61b3e96e1d14634dcd5edda4e133968ace769b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2241577
Reviewed-by: Denis Brockus 
Commit-Queue: Denis Brockus

common: Document flash_set_protect better

2020-06-25T23:48:34+00:00

BRANCH=none
BUG=none
TEST=none

Signed-off-by: Craig Hesling 
Change-Id: I07967c32fd481f76385e65af8752c9f5c5d19d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2222691
Reviewed-by: Jett Rink

volteer: Remove c10_gate_change

2020-06-25T21:31:02+00:00

This is unneeded, now that the EC doesn't need to control power
sequencing.

BUG=b:143375057
TEST=make buildall
BRANCH=none

Change-Id: I36d3ddefa5941d94b1549c1b8e1374bfa0d10b80
Signed-off-by: Abe Levkoy 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2267624
Reviewed-by: Keith Short 
Commit-Queue: Keith Short

sn5s330: initialize chip after EFS2 sysjump

2020-06-25T21:30:43+00:00

this fixes an issue where the pcc was not fully initialized as
intended due to EFS2 interactions.

when EFS2 is enabled, we sysjump to RW very early - before INIT_HOOKS
run. any code in pd_task that is predicated by
system_jumped_to_this_image() will either always run or never
run. this is not the intended behavior.

sn5s330_init() is called from ppc_init() which runs as part of
initialization done by pd_task(). we now need to check
system_jumped_late() instead of system_jumped_to_this_image() to get
the intended behavior.

BRANCH=none
BUG=b:159769490, chromium:1072743
TEST=verified all of sn5s330_init() now runs using additional debug
	printfs.

Change-Id: I3a8e6627e6e57e22b287b3f97bc79b0f3a07e5fa
Signed-off-by: Caveh Jalali 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2265608
Reviewed-by: Keith Short 
Reviewed-by: Daisuke Nojiri 
Commit-Queue: Keith Short 
Tested-by: Keith Short