delta/coreboot/chrome-ec.git, branch release-R58-9334.B

pyro: battery FW update tool modify for learning mode

2017-03-21T14:47:50+00:00

Let unit can't update battery FW when battery state in learning mode.

BUG=b:36372859
BRANCH=reef
TEST=check unit can't update battery FW in learning mode.

Change-Id: I9d69811d84fc386cda6adb51be51f1cfb4fcdf55
Signed-off-by: Bruce.Wan 
Reviewed-on: https://chromium-review.googlesource.com/454656
Commit-Ready: Keith Tzeng 
Tested-by: Keith Tzeng 
Reviewed-by: Aaron Durbin 
(cherry picked from commit 80cb93f45d396d797a47ab478dd62f9d29be7b3b)
Reviewed-on: https://chromium-review.googlesource.com/456437
Reviewed-by: YH Lin 
Commit-Queue: Keith Tzeng

npcx: gpio: Fixed bug GPIO's ISRs clear the other pending bits.

2017-03-03T09:32:21+00:00

Since the interrupts of MIWU group E/F/G/H of table 0 are the same
(interrupt 11), we need to handle LPCs' and GPIOs' events at the
same ISR. But we also found there is a leak that ec has the chance
to skip the other events which don't belong to GPIOs unexpectedly.
(For example, LRESET and eSPI Reset) This CL fixed this issue by
only clearing pending bits belong to GPIOs in their ISRs.

BRANCH=none
BUG=b:35648154
TEST=passed warm-reset testing on pyro over 12 hours.

Change-Id: Ie626db00b54cff566798b4a593f6b0267a6fadc2
Signed-off-by: Mulin Chao 
Reviewed-on: https://chromium-review.googlesource.com/449472
Reviewed-by: Aaron Durbin 
Reviewed-by: Nicolas Boichat

hammer: Add rollback protection flash region

2017-03-03T07:46:18+00:00

In the process, also manually specify all regions exact size,
which will be useful later on (e.g. when using RO/RW of different
sizes).

BRANCH=none
BUG=chrome-os-partner:61671
TEST=make BOARD=hammer -j; flashwp true/rb/rw protects the expected
     regions, flashwp noall unprotects them.

Change-Id: Ib31d9384060b1373e0834cfecb4ebd0a7bafd356
Reviewed-on: https://chromium-review.googlesource.com/430520
Commit-Ready: Nicolas Boichat 
Tested-by: Nicolas Boichat 
Reviewed-by: Randall Spangler

Include in include/watchdog.h.

2017-03-03T06:02:23+00:00

Previously, the int types used in the watchdog_trace() function
signature were not being included properly.

BUG=none
BRANCH=none
TEST=make buildall -j

Change-Id: Ib4666285c314cbdb101e3ba602e4f27540a1346c
Reviewed-on: https://chromium-review.googlesource.com/448345
Commit-Ready: Jeff Andersen 
Tested-by: Jeff Andersen 
Reviewed-by: Carl Hamilton 
Reviewed-by: Vadim Bendebury

usb_updater: fix command line options description

2017-03-03T02:34:10+00:00

The -b command line option should not be described as requiring a
parameter, as the binary file is given to most of invocations of
usb_updater.

Also adding the missing -p command line option description.

BRANCH=none
BUG=none
TEST='usb_updater -b ' does not fail any more

Change-Id: I6ceefa8c4dda841db63177d6134a611600a43078
Signed-off-by: Vadim Bendebury 
Reviewed-on: https://chromium-review.googlesource.com/448956
Reviewed-by: Aaron Durbin

g: enhance flash INFO api

2017-03-03T00:50:05+00:00

Flash INFO access API presently is hardcoded to access the endorsement
space. To enable INFO map based rollback protection one needs to be
able to access different areas of the INFO.

The FLASH REGION3 register used by the API is in fact used for NVMEM
flash accesses too, so it is better to leave it alone and use REGION6
for the purpose of accessing of the INFO space.

The API now requires the user to specify flash offset and region size,
the size must be power of 2, the offset must be aligned at size, and
the region must not spill beyond the INFO space address range.

BRANCH=cr50
BUG=b:35774863
TEST=with the rest of the patches applied it is possible to erase the
     base word in the info map segment;
     reading of the endorsement space at startup still works fine.

Change-Id: I008165ee9e11a7b49985d2b30683509cf6699431
Signed-off-by: Vadim Bendebury 
Reviewed-on: https://chromium-review.googlesource.com/447965
Reviewed-by: Nagendra Modadugu 
Reviewed-by: Mary Ruthven

switch: Initialize switch state earlier during HOOK_INIT

2017-03-02T19:29:07+00:00

The host may ask for our switch state at any time, so do initialization
immediately after lid + power button are initialized.

BUG=chrome-os-partner:63073
BRANCH=gru
TEST=On kevin, verify system boots when EC reset is triggered with lid
open. Verify lid close and power button press still succeed to
power-down from dev screen.

Change-Id: I8e37c02ef4f4d2d7c06beb383cdbda8eea67bc5c
Signed-off-by: Shawn Nematbakhsh 
Reviewed-on: https://chromium-review.googlesource.com/444322
Reviewed-by: Aseda Aboagye 
(cherry picked from commit 106d33cd3a8e4f3356950a3b2b92ea587977b4e7)
Reviewed-on: https://chromium-review.googlesource.com/445276
Commit-Ready: Shawn N 
Tested-by: Shawn N

pd: Add tcpc_select_rp_value to stub tcpm driver

2017-03-02T19:29:06+00:00

The function tcpm_select_rp_value() is used to set a given Rp
value. This function was not supported for boards that use the config
option CONFIG_USB_PD_TCPC. This CL adds a weak board_ function which
can be overloaded for boards that have the requirement to set Rp to
different values.

BUG=chrome-os-partner:61878
BRANCH=servo
TEST=run 'make buildall'. On plankton added a console command to trigger
a call to tcpm_select_rp_value(0, 0), verified that it returned
2 (EC_ERROR_NOT_IMPLEMENTED). Then added board_select_rp_value() to
plankton's board.c and verified that it returned 0.

Change-Id: I1cd6f0ed51717736d30575c58025bd9a1c5d6fc4
Signed-off-by: Scott 
Reviewed-on: https://chromium-review.googlesource.com/446685
Commit-Ready: Scott Collyer 
Tested-by: Scott Collyer 
Reviewed-by: Vincent Palatin

g: reformat signing manifests

2017-03-02T02:42:20+00:00

The json parser used by the signer is perfectly capable of parsing
multiline contents.

Let's reformat signer manifests to make it easier to see the entire
file in one terminal window.

BRANCH=none
BUG=b:35774863
TEST=none

Change-Id: I41d69ad11f07521f68a7a50227dc843872613127
Signed-off-by: Vadim Bendebury 
Reviewed-on: https://chromium-review.googlesource.com/447841
Reviewed-by: Marius Schilder

gpio: Add function to clear pending interrupt

2017-03-02T00:36:24+00:00

Currently if an interrupt is pending before it is enabled the interrupt
will fire immediately.  In most cases this is fine, but if we want to
use the interrupt to trigger something like waking the AP it should be
sure that it won't immediately fire once enabled.

For example: on the Eve board we have the trackpad interrupt run to the
AP and the EC in order to support wake from Deep S3 (magic AP state that
only the EC can wake it from).  This interrupt is used in S0 by the AP
while ignored by the EC, and then enabled on the transition to S3 in
order to be able to wake.  Since it has been active the interrupt may
be pending in the EC (depending on the chip), which can result in the
interrupt firing immediately and waking the AP.

BUG=chrome-os-partner:62224
BRANCH=none
TEST=This has been functionally tested on npcx only as that is what I
have a use case and system for, the others compile and look right but
have not been directly tested.

Change-Id: I9e0877d99e7f09f4c30bf9861fbad81c12c059ad
Signed-off-by: Duncan Laurie 
Reviewed-on: https://chromium-review.googlesource.com/446962
Reviewed-by: Randall Spangler