<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/coreboot/chrome-ec.git, branch release-R31-4731.B</title>
<subtitle>review.coreboot.org: chrome-ec.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/'/>
<entry>
<title>Set WLAN_OFF_L to open drain</title>
<updated>2013-09-24T01:32:51+00:00</updated>
<author>
<name>Paul Stewart</name>
<email>pstew@chromium.org</email>
</author>
<published>2013-09-23T17:20:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=03cc4b422d28459fca60d29d830078bd8d6f1db1'/>
<id>03cc4b422d28459fca60d29d830078bd8d6f1db1</id>
<content type='text'>
On bolt this pin is connected both to the PCH and the EC.
As designed, it was intended for both parts to treat this
as an open-drain circuit.

Signed-off-by: Paul Stewart &lt;pstew@chromium.org&gt;

BUG=chrome-os-partner:22175
BRANCH=none
TEST=No good test yet, since PCH appears to drive all the time

Change-Id: Ib6ca16b4f797c8c334fb9f030f20cdbbc756f3fb
Reviewed-on: https://chromium-review.googlesource.com/170257
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Commit-Queue: Paul Stewart &lt;pstew@chromium.org&gt;
Tested-by: Paul Stewart &lt;pstew@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
On bolt this pin is connected both to the PCH and the EC.
As designed, it was intended for both parts to treat this
as an open-drain circuit.

Signed-off-by: Paul Stewart &lt;pstew@chromium.org&gt;

BUG=chrome-os-partner:22175
BRANCH=none
TEST=No good test yet, since PCH appears to drive all the time

Change-Id: Ib6ca16b4f797c8c334fb9f030f20cdbbc756f3fb
Reviewed-on: https://chromium-review.googlesource.com/170257
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Commit-Queue: Paul Stewart &lt;pstew@chromium.org&gt;
Tested-by: Paul Stewart &lt;pstew@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Support compiling with chipset task disabled</title>
<updated>2013-09-23T21:26:29+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2013-09-20T21:00:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=29ee9c6d48910c8ce327ac1ccee18eaca9036eb1'/>
<id>29ee9c6d48910c8ce327ac1ccee18eaca9036eb1</id>
<content type='text'>
For bringup, we need to be able to compile a binary with the chipset
task disabled.  Chipset functions should be stubbed to do nothing in
that case.

BUG=chrome-os-partner:22820
BRANCH=none
TEST=compile falco, pit, link with chipset task commented out in ec.tasklist

Change-Id: I73a4e09effb049f19b1a128e643b267d6469037b
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/170221
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For bringup, we need to be able to compile a binary with the chipset
task disabled.  Chipset functions should be stubbed to do nothing in
that case.

BUG=chrome-os-partner:22820
BRANCH=none
TEST=compile falco, pit, link with chipset task commented out in ec.tasklist

Change-Id: I73a4e09effb049f19b1a128e643b267d6469037b
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/170221
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix thermal.c compilation if fans are not present.</title>
<updated>2013-09-23T21:26:26+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2013-09-19T23:55:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=6277f7e336f0dc96b676905a4c420f9d53951603'/>
<id>6277f7e336f0dc96b676905a4c420f9d53951603</id>
<content type='text'>
Currently, it doesn't compile unless CONFIG_FAN is defined.

BUG=chrome-os-partner:22803
BRANCH=none
TEST=temporarily undefine CONFIG_FAN in board/link/board.h; code compiles
     and all unit tests pass

Change-Id: I251d670ccd299f7a50b1455364a817e07fad4cb1
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/170106
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently, it doesn't compile unless CONFIG_FAN is defined.

BUG=chrome-os-partner:22803
BRANCH=none
TEST=temporarily undefine CONFIG_FAN in board/link/board.h; code compiles
     and all unit tests pass

Change-Id: I251d670ccd299f7a50b1455364a817e07fad4cb1
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/170106
</pre>
</div>
</content>
</entry>
<entry>
<title>stm32: Fix polarity of charger interrupt</title>
<updated>2013-09-23T19:23:58+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2013-09-23T17:04:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=61c40db16c0a5c03c9e2c25dfbf1e5e4645364bf'/>
<id>61c40db16c0a5c03c9e2c25dfbf1e5e4645364bf</id>
<content type='text'>
The charger interrupt is active-low.  Snow and Spring properly
triggered on falling (asserting) edge, but Pit (and Daisy/Puppy)
didn't.  Fix those boards, and rename the signal to end in _L so we
don't make that mistake again.

BUG=chrome-os-partner:22827
BRANCH=pit
TEST=unplug/replug AC adapter on pit; see debug output as follows:
	[batt] state charging -&gt; idle0
	Charger IRQ received.
	[batt] state idle0 -&gt; charging
	Charger IRQ received.

Change-Id: I1f5c9370d1118461dc033955ba77aab2cebb7ece
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/170256
Reviewed-by: Jaehoon Kim &lt;jh228.kim@samsung.com&gt;
Tested-by: Jaehoon Kim &lt;jh228.kim@samsung.com&gt;
Reviewed-by: Doug Anderson &lt;dianders@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The charger interrupt is active-low.  Snow and Spring properly
triggered on falling (asserting) edge, but Pit (and Daisy/Puppy)
didn't.  Fix those boards, and rename the signal to end in _L so we
don't make that mistake again.

BUG=chrome-os-partner:22827
BRANCH=pit
TEST=unplug/replug AC adapter on pit; see debug output as follows:
	[batt] state charging -&gt; idle0
	Charger IRQ received.
	[batt] state idle0 -&gt; charging
	Charger IRQ received.

Change-Id: I1f5c9370d1118461dc033955ba77aab2cebb7ece
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/170256
Reviewed-by: Jaehoon Kim &lt;jh228.kim@samsung.com&gt;
Tested-by: Jaehoon Kim &lt;jh228.kim@samsung.com&gt;
Reviewed-by: Doug Anderson &lt;dianders@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Record average runtime and delay of hooks</title>
<updated>2013-09-23T06:10:32+00:00</updated>
<author>
<name>Vic Yang</name>
<email>victoryang@chromium.org</email>
</author>
<published>2013-09-18T02:57:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=a4f3a72cf86ec99a765b3bf787aaf5b515e44030'/>
<id>a4f3a72cf86ec99a765b3bf787aaf5b515e44030</id>
<content type='text'>
In additional to recording the maximum runtime and delay, let's also
keep track of the moving average. The average is calculated by:
    New_Avg = (Old_Avg * 7 + New_Val) / 8
every time the hook fires.

The average values are only accurate for hooks that fire enough times,
but it won't be useful anyway for a hook that only fires just once or
twice.

Also, show warning if HOOK_TICK or HOOK_SECOND fires more than 10% late.

BUG=chrome-os-partner:21801
TEST=On Kirby, check average values are sane.
TEST='waitms 800' and see warning of HOOK_TICK firing late.
BRANCH=None

Change-Id: I453545830d854c6c5bfc795d01fc558a965cff6e
Signed-off-by: Vic Yang &lt;victoryang@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169704
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In additional to recording the maximum runtime and delay, let's also
keep track of the moving average. The average is calculated by:
    New_Avg = (Old_Avg * 7 + New_Val) / 8
every time the hook fires.

The average values are only accurate for hooks that fire enough times,
but it won't be useful anyway for a hook that only fires just once or
twice.

Also, show warning if HOOK_TICK or HOOK_SECOND fires more than 10% late.

BUG=chrome-os-partner:21801
TEST=On Kirby, check average values are sane.
TEST='waitms 800' and see warning of HOOK_TICK firing late.
BRANCH=None

Change-Id: I453545830d854c6c5bfc795d01fc558a965cff6e
Signed-off-by: Vic Yang &lt;victoryang@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169704
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lm4: make CONFIG_UART_HOST optional</title>
<updated>2013-09-20T20:44:54+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2013-09-19T23:43:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=f27c00768489ae6b81a1366116744fec7f849ba8'/>
<id>f27c00768489ae6b81a1366116744fec7f849ba8</id>
<content type='text'>
Currently, CONFIG_UART_HOST must be defined for all LM4-based
platforms.  Future platforms may not need host UART support, so make
it optional.

BUG=chrome-os-partner:22802
BRANCH=none
TEST=Temporarily comment out CONFIG_UART_HOST in board/link/board.h;
     code still compiles.

Change-Id: I8775d9daaf8f6e45f1f374c9be7f10316611447f
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/170104
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently, CONFIG_UART_HOST must be defined for all LM4-based
platforms.  Future platforms may not need host UART support, so make
it optional.

BUG=chrome-os-partner:22802
BRANCH=none
TEST=Temporarily comment out CONFIG_UART_HOST in board/link/board.h;
     code still compiles.

Change-Id: I8775d9daaf8f6e45f1f374c9be7f10316611447f
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/170104
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>cleanup: move test mocks to board/host and remove unused mocks</title>
<updated>2013-09-19T23:30:03+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2013-09-16T22:44:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=883dd51006600d78ccfc6c6ff73a66943492538e'/>
<id>883dd51006600d78ccfc6c6ff73a66943492538e</id>
<content type='text'>
Now that we have a better test framework in place, mock
implementations go in either chip/host/ or board/host/, depending on
whether they're mocking chip or common/board functionality.  Move the
remaining mocks there.  Also, several mocks were neither compiled nor
used, and haven't kept pace with other refactoring; delete those.

BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all board; pass all unit tests

Change-Id: Ie2a81c3ccd4506679192d979aa87fe7ed6c1c5a0
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169873
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now that we have a better test framework in place, mock
implementations go in either chip/host/ or board/host/, depending on
whether they're mocking chip or common/board functionality.  Move the
remaining mocks there.  Also, several mocks were neither compiled nor
used, and haven't kept pace with other refactoring; delete those.

BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all board; pass all unit tests

Change-Id: Ie2a81c3ccd4506679192d979aa87fe7ed6c1c5a0
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169873
</pre>
</div>
</content>
</entry>
<entry>
<title>Turn off backlight power when lid is closed.</title>
<updated>2013-09-19T02:42:00+00:00</updated>
<author>
<name>Jeremy Thorpe</name>
<email>jeremyt@chromium.org</email>
</author>
<published>2013-09-18T21:17:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=a7f5224a83ac58b569a0a3c3c95549d38f448171'/>
<id>a7f5224a83ac58b569a0a3c3c95549d38f448171</id>
<content type='text'>
Ensure that the backlight is off whenever the lid is closed,
independently of whether the AP asserts SUSPEND_L.

BUG=None
TEST=On Kirby, toggle lid switch closed and see that backlight turns off
immediately.
BRANCH=None

Change-Id: I1516be3b139a8cbb07a8a81229c8143c88118e91
Signed-off-by: Jeremy Thorpe &lt;jeremyt@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169875
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ensure that the backlight is off whenever the lid is closed,
independently of whether the AP asserts SUSPEND_L.

BUG=None
TEST=On Kirby, toggle lid switch closed and see that backlight turns off
immediately.
BRANCH=None

Change-Id: I1516be3b139a8cbb07a8a81229c8143c88118e91
Signed-off-by: Jeremy Thorpe &lt;jeremyt@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169875
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>cleanup: move board-specific battery files to board dirs</title>
<updated>2013-09-19T00:41:12+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2013-09-16T22:19:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=a95e80dd47474a25a77f0a3507053848c3fa0f36'/>
<id>a95e80dd47474a25a77f0a3507053848c3fa0f36</id>
<content type='text'>
The battery files contain board-specific constants and a few small
methods like battery-detect and battery-cut.  Most of these aren't
reused across platforms.  The battery files have also been cleaned up
so those board-specific constants basically all that's left in them.

Where a file is used by a single board only, move it to
board/(boardname)/battery.c.  Batteries used by more than one board
(e.g. battery_link.c used by both link and bolt) are still in
common/battery_*.c, since that's cleaner than duplicating the file in
each board's directory.

No code changes, just moving files.

BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all boards and pass unit tests

Change-Id: I946c8eb874672c77f9b77105e5b900f98fa48d0f
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169893
Reviewed-by: Vincent Palatin &lt;vpalatin@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The battery files contain board-specific constants and a few small
methods like battery-detect and battery-cut.  Most of these aren't
reused across platforms.  The battery files have also been cleaned up
so those board-specific constants basically all that's left in them.

Where a file is used by a single board only, move it to
board/(boardname)/battery.c.  Batteries used by more than one board
(e.g. battery_link.c used by both link and bolt) are still in
common/battery_*.c, since that's cleaner than duplicating the file in
each board's directory.

No code changes, just moving files.

BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all boards and pass unit tests

Change-Id: I946c8eb874672c77f9b77105e5b900f98fa48d0f
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169893
Reviewed-by: Vincent Palatin &lt;vpalatin@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix console channel name list</title>
<updated>2013-09-18T22:09:04+00:00</updated>
<author>
<name>Vic Yang</name>
<email>victoryang@chromium.org</email>
</author>
<published>2013-09-18T02:55:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/chrome-ec.git/commit/?id=6aa88ffa4e6d64a59e5c1d68439ee29d4e8193cc'/>
<id>6aa88ffa4e6d64a59e5c1d68439ee29d4e8193cc</id>
<content type='text'>
This adds back missing "hook" channel name. Also add a build assertion
to make sure we don't miss this again.

BUG=chrome-os-partner:21801
TEST=Build all boards. Remove "hook" channel and check build fails.
BRANCH=None

Change-Id: I373016504fd3753e1a791077d49b3af14b2b1aa4
Signed-off-by: Vic Yang &lt;victoryang@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169703
Reviewed-by: Vincent Palatin &lt;vpalatin@chromium.org&gt;
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This adds back missing "hook" channel name. Also add a build assertion
to make sure we don't miss this again.

BUG=chrome-os-partner:21801
TEST=Build all boards. Remove "hook" channel and check build fails.
BRANCH=None

Change-Id: I373016504fd3753e1a791077d49b3af14b2b1aa4
Signed-off-by: Vic Yang &lt;victoryang@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/169703
Reviewed-by: Vincent Palatin &lt;vpalatin@chromium.org&gt;
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
