From 831b0e9824e6c7cb07308830c12977acb79156c7 Mon Sep 17 00:00:00 2001 From: Jimmy Brisson Date: Wed, 5 Aug 2020 13:44:05 -0500 Subject: Don't return error information from console_flush And from crash_console_flush. We ignore the error information return by console_flush in _every_ place where we call it, and casting the return type to void does not work around the MISRA violation that this causes. Instead, we collect the error information from the driver (to avoid changing that API), and don't return it to the caller. Change-Id: I1e35afe01764d5c8f0efd04f8949d333ffb688c1 Signed-off-by: Jimmy Brisson --- plat/brcm/board/common/bcm_console.c | 4 ++-- plat/brcm/board/stingray/aarch64/plat_helpers.S | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'plat/brcm') diff --git a/plat/brcm/board/common/bcm_console.c b/plat/brcm/board/common/bcm_console.c index d484a6f63..5f2009403 100644 --- a/plat/brcm/board/common/bcm_console.c +++ b/plat/brcm/board/common/bcm_console.c @@ -39,7 +39,7 @@ void bcm_console_boot_init(void) void bcm_console_boot_end(void) { - (void)console_flush(); + console_flush(); (void)console_unregister(&bcm_boot_console); } @@ -59,7 +59,7 @@ void bcm_console_runtime_init(void) void bcm_console_runtime_end(void) { - (void)console_flush(); + console_flush(); (void)console_unregister(&bcm_runtime_console); } diff --git a/plat/brcm/board/stingray/aarch64/plat_helpers.S b/plat/brcm/board/stingray/aarch64/plat_helpers.S index 609553248..9a2039daf 100644 --- a/plat/brcm/board/stingray/aarch64/plat_helpers.S +++ b/plat/brcm/board/stingray/aarch64/plat_helpers.S @@ -182,7 +182,7 @@ func plat_crash_console_putc endfunc plat_crash_console_putc /* --------------------------------------------- - * int plat_crash_console_flush(void) + * void plat_crash_console_flush(void) * Function to flush crash console * Clobber list : x0, x1 * --------------------------------------------- -- cgit v1.2.1