From 1ad02ec15d4fab8cf22fbd49ef656e62e8953aab Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Fri, 23 Aug 2019 18:18:37 +1000 Subject: Remove github_action_linux tag from bundler examples. Maybe it has fixed at 5a384e2c08704dc7af9d8d3bdfc475eb8c0723aa --- spec/commands/exec_spec.rb | 2 +- spec/spec_helper.rb | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/spec/commands/exec_spec.rb b/spec/commands/exec_spec.rb index a36b303060..cf76d3fb93 100644 --- a/spec/commands/exec_spec.rb +++ b/spec/commands/exec_spec.rb @@ -55,7 +55,7 @@ RSpec.describe "bundle exec" do expect(out).to eq("hi") end - it "respects custom process title when loading through ruby", :github_action_linux do + it "respects custom process title when loading through ruby" do script_that_changes_its_own_title_and_checks_if_picked_up_by_ps_unix_utility = <<~'RUBY' Process.setproctitle("1-2-3-4-5-6-7-8-9-10-11-12-13-14-15") puts `ps -ocommand= -p#{$$}` diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index f10f6c464f..58d498e070 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -71,7 +71,6 @@ RSpec.configure do |config| config.filter_run_excluding :bundler => RequirementChecker.against(Bundler::VERSION.split(".")[0]) config.filter_run_excluding :ruby_repo => !ENV["GEM_COMMAND"].nil? config.filter_run_excluding :no_color_tty => Gem.win_platform? || !ENV["GITHUB_ACTION"].nil? - config.filter_run_excluding :github_action_linux => !ENV["GITHUB_ACTION"].nil? && (ENV["RUNNER_OS"] == "Linux") config.filter_run_when_matching :focus unless ENV["CI"] -- cgit v1.2.1 From 30a690edbdf5ee64ea54afc7d0c91d910ff2b80e Mon Sep 17 00:00:00 2001 From: Kazuhiro NISHIYAMA Date: Fri, 30 Aug 2019 12:49:27 +0900 Subject: Add guard as same as `==` Try to fix failure at https://github.com/ruby/ruby/runs/207580232#step:10:382 ``` undefined method `name' for "Gemfile.lock":String /home/runner/work/ruby/ruby/lib/bundler/resolver/spec_group.rb:65:in `eql?' ``` --- lib/bundler/resolver/spec_group.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/bundler/resolver/spec_group.rb b/lib/bundler/resolver/spec_group.rb index 119f63b5c8..e5772eed81 100644 --- a/lib/bundler/resolver/spec_group.rb +++ b/lib/bundler/resolver/spec_group.rb @@ -62,6 +62,7 @@ module Bundler end def eql?(other) + return unless other.is_a?(SpecGroup) name.eql?(other.name) && version.eql?(other.version) && source.eql?(other.source) -- cgit v1.2.1 From 273681f3afb0c9a2f1c0ca1fc203040a8c8989e1 Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Sun, 1 Sep 2019 08:56:00 +0900 Subject: Ignore the all of warnings with inline_spec.rb of bundler examples. --- spec/runtime/inline_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/runtime/inline_spec.rb b/spec/runtime/inline_spec.rb index 6c268a7c10..92243a77b6 100644 --- a/spec/runtime/inline_spec.rb +++ b/spec/runtime/inline_spec.rb @@ -90,7 +90,7 @@ RSpec.describe "bundler/inline#gemfile" do expect(out).to include("Installing activesupport") err.gsub! %r{(.*lib/sinatra/base\.rb:\d+: warning: constant ::Fixnum is deprecated$)}, "" err_lines = err.split("\n") - err_lines.reject!{|line| line =~ /\.rb:\d+: warning: The last/ } + err_lines.reject!{|line| line =~ /\.rb:\d+: warning: / } expect(err_lines).to be_empty expect(exitstatus).to be_zero if exitstatus end -- cgit v1.2.1