From 5e08e849ec451f06f9b0f46ec57e8696434db354 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Tue, 25 Jun 2019 16:50:20 +0200 Subject: Make some specs more explicit --- spec/install/gemfile/gemspec_spec.rb | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/spec/install/gemfile/gemspec_spec.rb b/spec/install/gemfile/gemspec_spec.rb index ecb8358ccc..c50f8c9668 100644 --- a/spec/install/gemfile/gemspec_spec.rb +++ b/spec/install/gemfile/gemspec_spec.rb @@ -331,24 +331,12 @@ RSpec.describe "bundle install from an existing gemspec" do context "previously bundled for Ruby" do let(:platform) { "ruby" } - let(:explicit_platform) { false } before do build_lib("foo", :path => tmp.join("foo")) do |s| s.add_dependency "rack", "=1.0.0" end - if explicit_platform - create_file( - tmp.join("foo", "foo-#{platform}.gemspec"), - build_spec("foo", "1.0", platform) do - dep "rack", "=1.0.0" - @spec.authors = "authors" - @spec.summary = "summary" - end.first.to_ruby - ) - end - gemfile <<-G source "#{source_uri}" gemspec :path => "../foo" @@ -379,7 +367,17 @@ RSpec.describe "bundle install from an existing gemspec" do context "using JRuby with explicit platform" do let(:platform) { "java" } - let(:explicit_platform) { true } + + before do + create_file( + tmp.join("foo", "foo-#{platform}.gemspec"), + build_spec("foo", "1.0", platform) do + dep "rack", "=1.0.0" + @spec.authors = "authors" + @spec.summary = "summary" + end.first.to_ruby + ) + end it "should install" do simulate_ruby_engine "jruby" do -- cgit v1.2.1