From b8e754c8523c8c3ba4562a536cb03e91e6d14f67 Mon Sep 17 00:00:00 2001 From: Andre Arko Date: Sun, 23 Aug 2015 02:11:42 -0700 Subject: avoid build ri or rdoc --- spec/support/builders.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/support/builders.rb b/spec/support/builders.rb index 2c02327b3d..dd54d765b0 100644 --- a/spec/support/builders.rb +++ b/spec/support/builders.rb @@ -628,7 +628,7 @@ module Spec Bundler.rubygems.build(@spec, opts[:skip_validation]) if opts[:to_system] - `gem install --ignore-dependencies #{@spec.full_name}.gem` + `gem install --ignore-dependencies --no-ri --no-rdoc #{@spec.full_name}.gem` else FileUtils.mv("#{@spec.full_name}.gem", opts[:path] || _default_path) end -- cgit v1.2.1 From 507ea45c54177c823ab17df70f87e86fd1d1a1b7 Mon Sep 17 00:00:00 2001 From: Andre Arko Date: Sun, 23 Aug 2015 02:11:58 -0700 Subject: try to install test system gems if missing --- spec/support/builders.rb | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/spec/support/builders.rb b/spec/support/builders.rb index dd54d765b0..fe9b2ba4d7 100644 --- a/spec/support/builders.rb +++ b/spec/support/builders.rb @@ -298,12 +298,20 @@ module Spec def build_repo(path, &blk) return if File.directory?(path) rake_path = Dir["#{Path.base_system_gems}/**/rake*.gem"].first + + if rake_path.nil? + Spec::Path.base_system_gems.rmtree + Spec::Rubygems.setup + rake_path = Dir["#{Path.base_system_gems}/**/rake*.gem"].first + end + if rake_path FileUtils.mkdir_p("#{path}/gems") FileUtils.cp rake_path, "#{path}/gems/" else - abort "You need to `rm -rf #{tmp}`" + abort "Your test gems are missing! Run `rm -rf #{tmp}` and try again." end + update_repo(path, &blk) end -- cgit v1.2.1 From 71a638848e3031828ff311d72648ba934df08e33 Mon Sep 17 00:00:00 2001 From: Andre Arko Date: Sun, 23 Aug 2015 15:21:18 -0700 Subject: disable module length cop --- .rubocop.yml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 5e60f77b23..38bbcc04bb 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -73,26 +73,21 @@ Style/TrailingComma: # Metrics -# Arbitrary max lengths for classes simply do not work and enabling this will -# lead to a never ending stream of annoyance and changes. +# We've chosen to use Rubocop only for style, and not for complexity or quality checks. Metrics/ClassLength: Enabled: false -# Arbitrary max lengths for methods simply do not work and enabling this will -# lead to a never ending stream of annoyance and changes. +Metrics/ModuleLength: + Enabled: false + Metrics/MethodLength: Enabled: false -# No enforced convention here. Metrics/BlockNesting: Enabled: false -# It will be obvious which code is complex, Rubocop should only lint simple -# rules for us. Metrics/AbcSize: Enabled: false -# It will be obvious which code is complex, Rubocop should only lint simple -# rules for us. Metrics/CyclomaticComplexity: Enabled: false -- cgit v1.2.1