diff options
author | The Bundler Bot <bot@bundler.io> | 2017-08-15 18:37:25 +0000 |
---|---|---|
committer | The Bundler Bot <bot@bundler.io> | 2017-08-15 18:37:25 +0000 |
commit | d01a309b2f9b4de99f98700264de72c9274ded01 (patch) | |
tree | 2ced6c31c9d3172f124582d72f34520727479fb5 /spec/bundler | |
parent | 7cc6448fcd796ea93e0d6e24fee0cc615efc15f7 (diff) | |
parent | 23e9287ae6f230d5dd47451f9082665c2847070b (diff) | |
download | bundler-d01a309b2f9b4de99f98700264de72c9274ded01.tar.gz |
Auto merge of #5910 - bundler:seg-outdated-warning-tweak, r=indirect
[CLI] Suggest bundle update --bundler when a newer version is installed
### What was the end-user problem that led to this PR?
The problem is once users start using our new `bin/bundle` binstub or the RubyGems that helps lock to the bundler version in the lockfile, the outdated bundler version warning was outdated.
### What was your diagnosis of the problem?
My diagnosis was we needed to tell people to `bundle update --bundler`, and restrict the `gem install` suggestion to when the latest version indeed wasn't installed.
### What is your fix for the problem, implemented in this PR?
My fix takes into account the actual installed bundler versions.
@indirect I think this addresses your concern on the RG PR?
Diffstat (limited to 'spec/bundler')
-rw-r--r-- | spec/bundler/cli_spec.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/bundler/cli_spec.rb b/spec/bundler/cli_spec.rb index fc5b6ebfaf..fd4820b67f 100644 --- a/spec/bundler/cli_spec.rb +++ b/spec/bundler/cli_spec.rb @@ -112,7 +112,7 @@ RSpec.describe "bundle executable" do bundle "fail" expect(last_command.stdout).to start_with(<<-EOS.strip) The latest bundler is #{latest_version}, but you are currently running #{bundler_version}. -To update, run `gem install bundler` +To install the latest version, run `gem install bundler` EOS end @@ -137,7 +137,7 @@ To update, run `gem install bundler` bundle "fail" expect(last_command.stdout).to start_with(<<-EOS.strip) The latest bundler is #{latest_version}, but you are currently running #{bundler_version}. -To update, run `gem install bundler --pre` +To install the latest version, run `gem install bundler --pre` EOS end end |