diff options
| author | The Bundler Bot <bot@bundler.io> | 2018-01-23 05:53:40 +0000 |
|---|---|---|
| committer | The Bundler Bot <bot@bundler.io> | 2018-01-23 05:53:40 +0000 |
| commit | 3aa29ce4c0589104c95beb480364c96c0e10d108 (patch) | |
| tree | 303a3422c5532d78f43153c5ca15158f0a0a2629 /doc/contributing | |
| parent | 350772f16aac77625b2e5f17b4df56858ebe087c (diff) | |
| parent | 748255034ca1c82e8bcd86c9736efec870d915eb (diff) | |
| download | bundler-3aa29ce4c0589104c95beb480364c96c0e10d108.tar.gz | |
Auto merge of #6267 - christhekeele:scaffold-error-class, r=colby-swandale
Add base error class to new gems.
Closes #6260.
Room for discussion:
- Which error class to use (`StandardError` makes sense to me)
- What formatting to use (the three-lines-with-comment seemed nicest to me)
- Whether or not using the flag to provide a different error base class is useful, and if it should validate the user's choice or not (I threw it in because it seemed harmless; is it? a boolean flag would work fine too)
---
### What was the end-user problem that led to this PR?
Libraries don't always follow best practice from discussion in linked issue.
### What was your diagnosis of the problem?
Bundler could encourage best practice by adding it to the gem scaffold.
### What is your fix for the problem, implemented in this PR?
I added a base error class to the templates, and provided a flag to change/disable this behaviour.
### Why did you choose this fix out of the possible options?
Like any best-practice-by-default, this could ruin someones workflow/go against someone's preferences so I made it as configurable as possible.
Diffstat (limited to 'doc/contributing')
0 files changed, 0 insertions, 0 deletions