delta/bundler.git/spec, branch colby/git-https-default

add feature flag to use https for :git in the dsl

2018-11-24T20:56:11+00:00

Followed up https://github.com/bundler/bundler/pull/6743

2018-11-16T13:17:58+00:00

  #6743 was failed with ruby core repository and ignored working example.
  Fixed them.

Merge #6775

2018-11-16T10:37:20+00:00

6775: [Plugin::Index] Only register each plugin once for a given hook r=colby-swandale a=segiddins

### What was the end-user problem that led to this PR?

The problem was running `plugin install` twice for a plugin withs hooks would cause that hook to be registered twice.

Closes #6771.

### What was your diagnosis of the problem?

My diagnosis was a plugin's hooks should only be run once per event.

### What is your fix for the problem, implemented in this PR?

My fix is to `uniq` the list of plugins registered for each event.

Co-authored-by: Samuel Giddins 
Co-authored-by: Olle Jonsson 
Co-authored-by: Colby Swandale

fix rubocop

2018-11-16T10:00:19+00:00

Merge #6743

2018-11-16T02:44:32+00:00

6743: Support file structure of ruby core repository. r=hsbt a=hsbt

### What was the end-user problem that led to this PR?

In the ruby core repository, I put bundler executable and bundler libraries under the `bin` and `lib` directories. It breaks the current behavior.

### What is your fix for the problem, implemented in this PR?

Support the structure of ruby core repository.



Co-authored-by: SHIBATA Hiroshi

Double-register hook in spec

2018-11-11T07:10:54+00:00


To make it clear the list is uniq’d

Co-Authored-By: segiddins

rubocop -a

2018-11-07T15:27:02+00:00

To use around hook instead of before suite.

2018-11-06T20:41:49+00:00

To use helper method instead of env variables.

2018-11-06T20:31:05+00:00

Merge #6714

2018-11-06T09:23:46+00:00

6714: Spec reset state and refactorings r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that while working on #6713, I noticed several issues like order dependent failures, situations hard to debug, or specs doing too much and taking longer than they should.
 
### What was your diagnosis of the problem?

My diagnosis was that:

* Sometimes specs leak settings and env variable modifications.
* When a hang happens inside a subprocess, it's hard to debug because logging is not printed out anywhere.
* Some specs create unnecessary gemfiles and run `bundle install` multiple times unnecessarily.

### What is your fix for the problem, implemented in this PR?

My fix for state leaks is to reset state after each spec, for the hangs is to reorder some lines in the `sys_exec` helper (https://github.com/bundler/bundler/commit/b305a5b2524a6457b05a9d39e9526f75c98a0752), and for the unnecessary operations, to refactor the specs to avoid them.

### Why did you choose this fix out of the possible options?

I chose this fix because it seems like the best way to alleviate the issues found.


Co-authored-by: David Rodríguez