<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/bundler.git/spec/support/helpers.rb, branch colby/git-https-default</title>
<subtitle>github.com: bundler/bundler.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/'/>
<entry>
<title>Merge #6743</title>
<updated>2018-11-16T02:44:32+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-11-16T02:44:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=172ec59db53ec05a91c0d9eb72e2d715ae82f3c0'/>
<id>172ec59db53ec05a91c0d9eb72e2d715ae82f3c0</id>
<content type='text'>
6743: Support file structure of ruby core repository. r=hsbt a=hsbt

### What was the end-user problem that led to this PR?

In the ruby core repository, I put bundler executable and bundler libraries under the `bin` and `lib` directories. It breaks the current behavior.

### What is your fix for the problem, implemented in this PR?

Support the structure of ruby core repository.



Co-authored-by: SHIBATA Hiroshi &lt;hsbt@ruby-lang.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
6743: Support file structure of ruby core repository. r=hsbt a=hsbt

### What was the end-user problem that led to this PR?

In the ruby core repository, I put bundler executable and bundler libraries under the `bin` and `lib` directories. It breaks the current behavior.

### What is your fix for the problem, implemented in this PR?

Support the structure of ruby core repository.



Co-authored-by: SHIBATA Hiroshi &lt;hsbt@ruby-lang.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #6714</title>
<updated>2018-11-06T09:23:46+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-11-06T09:23:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=98040394795a8e5fd03d7e893f1a060041cd6777'/>
<id>98040394795a8e5fd03d7e893f1a060041cd6777</id>
<content type='text'>
6714: Spec reset state and refactorings r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that while working on #6713, I noticed several issues like order dependent failures, situations hard to debug, or specs doing too much and taking longer than they should.
 
### What was your diagnosis of the problem?

My diagnosis was that:

* Sometimes specs leak settings and env variable modifications.
* When a hang happens inside a subprocess, it's hard to debug because logging is not printed out anywhere.
* Some specs create unnecessary gemfiles and run `bundle install` multiple times unnecessarily.

### What is your fix for the problem, implemented in this PR?

My fix for state leaks is to reset state after each spec, for the hangs is to reorder some lines in the `sys_exec` helper (https://github.com/bundler/bundler/commit/b305a5b2524a6457b05a9d39e9526f75c98a0752), and for the unnecessary operations, to refactor the specs to avoid them.

### Why did you choose this fix out of the possible options?

I chose this fix because it seems like the best way to alleviate the issues found.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
6714: Spec reset state and refactorings r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that while working on #6713, I noticed several issues like order dependent failures, situations hard to debug, or specs doing too much and taking longer than they should.
 
### What was your diagnosis of the problem?

My diagnosis was that:

* Sometimes specs leak settings and env variable modifications.
* When a hang happens inside a subprocess, it's hard to debug because logging is not printed out anywhere.
* Some specs create unnecessary gemfiles and run `bundle install` multiple times unnecessarily.

### What is your fix for the problem, implemented in this PR?

My fix for state leaks is to reset state after each spec, for the hangs is to reorder some lines in the `sys_exec` helper (https://github.com/bundler/bundler/commit/b305a5b2524a6457b05a9d39e9526f75c98a0752), and for the unnecessary operations, to refactor the specs to avoid them.

### Why did you choose this fix out of the possible options?

I chose this fix because it seems like the best way to alleviate the issues found.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Backport from ruby core</title>
<updated>2018-11-01T13:02:59+00:00</updated>
<author>
<name>SHIBATA Hiroshi</name>
<email>hsbt@ruby-lang.org</email>
</author>
<published>2018-11-01T12:49:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=09bfdfa31ad5ae34d29745344493f6a63d355804'/>
<id>09bfdfa31ad5ae34d29745344493f6a63d355804</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unnecessary stuff from specs</title>
<updated>2018-10-26T18:36:14+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2018-09-10T00:39:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=ab325bde24853207450904b06a55b4a9766fdbf0'/>
<id>ab325bde24853207450904b06a55b4a9766fdbf0</id>
<content type='text'>
Since we no longer test against rubygems versions that old.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since we no longer test against rubygems versions that old.
</pre>
</div>
</content>
</entry>
<entry>
<title>rubocop -a</title>
<updated>2018-10-20T11:01:01+00:00</updated>
<author>
<name>SHIBATA Hiroshi</name>
<email>hsbt@ruby-lang.org</email>
</author>
<published>2018-10-17T07:01:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=6d2c0d2a199564a75612eb492adec5e27eaa923d'/>
<id>6d2c0d2a199564a75612eb492adec5e27eaa923d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Added to support BUNDLE_RUBY and BUNDLE_GEM environmental variables.</title>
<updated>2018-10-20T11:00:39+00:00</updated>
<author>
<name>SHIBATA Hiroshi</name>
<email>hsbt@ruby-lang.org</email>
</author>
<published>2018-10-16T11:45:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=5417b218c499db48b23de2bdc38ba2f33d3223c0'/>
<id>5417b218c499db48b23de2bdc38ba2f33d3223c0</id>
<content type='text'>
  They are replaced build binary on ruby core repository.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  They are replaced build binary on ruby core repository.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #6742</title>
<updated>2018-10-17T11:34:13+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-10-17T11:34:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=3cc783b9495f85b8c3fea480d888c4f032942e89'/>
<id>3cc783b9495f85b8c3fea480d888c4f032942e89</id>
<content type='text'>
6742: Use helper method instead of hard-code path. r=colby-swandale a=hsbt

### What was the end-user problem that led to this PR?

In ruby core repository, We need to replace executable file like `ruby`, `rake`, `gem`. 

### What is your fix for the problem, implemented in this PR?

This pull request makes hard-coded executable file to the helper methods.



Co-authored-by: SHIBATA Hiroshi &lt;hsbt@ruby-lang.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
6742: Use helper method instead of hard-code path. r=colby-swandale a=hsbt

### What was the end-user problem that led to this PR?

In ruby core repository, We need to replace executable file like `ruby`, `rake`, `gem`. 

### What is your fix for the problem, implemented in this PR?

This pull request makes hard-coded executable file to the helper methods.



Co-authored-by: SHIBATA Hiroshi &lt;hsbt@ruby-lang.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>rubocop -a</title>
<updated>2018-10-16T07:38:58+00:00</updated>
<author>
<name>SHIBATA Hiroshi</name>
<email>hsbt@ruby-lang.org</email>
</author>
<published>2018-10-16T07:38:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=07236100c921f9dcd396d46792b3936a880fdf21'/>
<id>07236100c921f9dcd396d46792b3936a880fdf21</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>added full path of rake executable.</title>
<updated>2018-10-16T07:07:56+00:00</updated>
<author>
<name>SHIBATA Hiroshi</name>
<email>hsbt@ruby-lang.org</email>
</author>
<published>2018-10-16T07:07:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=0356592184ea0ee58b9e2b4eb73875f1540db4ad'/>
<id>0356592184ea0ee58b9e2b4eb73875f1540db4ad</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Added missing helper method for rake</title>
<updated>2018-10-16T04:52:24+00:00</updated>
<author>
<name>SHIBATA Hiroshi</name>
<email>hsbt@ruby-lang.org</email>
</author>
<published>2018-10-16T04:52:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=b061f1b424f29f95d21c9c6ad1d3aa66134d9305'/>
<id>b061f1b424f29f95d21c9c6ad1d3aa66134d9305</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
