<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/bundler.git/spec/runtime, branch parallel_rspec</title>
<subtitle>github.com: bundler/bundler.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/'/>
<entry>
<title>Parallelize test suite</title>
<updated>2019-07-23T21:14:52+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-01-24T16:28:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=5ca2dc737fcda83e625290e29cf1baf0c6cc2fd3'/>
<id>5ca2dc737fcda83e625290e29cf1baf0c6cc2fd3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a comment to explain the initial reset</title>
<updated>2019-07-23T09:23:00+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-07-23T06:16:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=6d0a8f4128dbfe855a33421c85419d09d1311d01'/>
<id>6d0a8f4128dbfe855a33421c85419d09d1311d01</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Move environment reset to the only test needing it</title>
<updated>2019-07-23T09:23:00+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-07-23T06:14:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=6d3b809695e579f0b64f111e023f47721cad3f30'/>
<id>6d3b809695e579f0b64f111e023f47721cad3f30</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve test to make it more independent from env</title>
<updated>2019-07-23T09:22:59+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-07-23T06:15:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=038f0d7c37b8a3f0a3faeac87b4c7b02fd40c22a'/>
<id>038f0d7c37b8a3f0a3faeac87b4c7b02fd40c22a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Change the refresh spec to not use `stubs_for`</title>
<updated>2019-07-11T09:02:49+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-07-11T09:02:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=49c519ef47edf17b79a10d9a87cad170d4dd34fc'/>
<id>49c519ef47edf17b79a10d9a87cad170d4dd34fc</id>
<content type='text'>
We plan to incrementally populate this array in rubygems, so that will
break the test because the first time `find_by_name("rack")` is called
will make the `rack` gem available in the array.

We can test the same thing using some other way, which is more
appropriate anyways, because `Bundler.rubygems.find_name` is only used
inside `bundler` to look for the `bundler` gem itself whereas
`Bundler.rubygems.all_specs` is used in more places.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We plan to incrementally populate this array in rubygems, so that will
break the test because the first time `find_by_name("rack")` is called
will make the `rack` gem available in the array.

We can test the same thing using some other way, which is more
appropriate anyways, because `Bundler.rubygems.find_name` is only used
inside `bundler` to look for the `bundler` gem itself whereas
`Bundler.rubygems.all_specs` is used in more places.
</pre>
</div>
</content>
</entry>
<entry>
<title>No need to make `Gem.refresh` a noop</title>
<updated>2019-07-11T09:02:35+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-07-11T09:02:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=3810f9945ce17c180e8375af46eb75059d68de91'/>
<id>3810f9945ce17c180e8375af46eb75059d68de91</id>
<content type='text'>
The rubygems integration sets up a `post_reset` hook that resets the
specs back to what bundler knows after `Gem::Specification.reset` is
called (which is what `Gem.refresh` calls under the hood).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The rubygems integration sets up a `post_reset` hook that resets the
specs back to what bundler knows after `Gem::Specification.reset` is
called (which is what `Gem.refresh` calls under the hood).
</pre>
</div>
</content>
</entry>
<entry>
<title>Add all platforms to lockfile by default</title>
<updated>2019-07-10T10:08:14+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-06-19T15:01:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=3dc509e645abb497e4dc92a7c42be471ff87db0b'/>
<id>3dc509e645abb497e4dc92a7c42be471ff87db0b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Make spec easier to debug</title>
<updated>2019-07-05T07:25:42+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-04-26T15:09:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=156629291e003da57c85fcdda4199da0fb07833a'/>
<id>156629291e003da57c85fcdda4199da0fb07833a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7154</title>
<updated>2019-07-04T18:35:32+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-07-04T18:35:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=0a3c70c375b38164d54d3cbda8dbaefb0e35d3b2'/>
<id>0a3c70c375b38164d54d3cbda8dbaefb0e35d3b2</id>
<content type='text'>
7154: bundler/inline should install gems to BUNDLE_PATH r=deivid-rodriguez a=robuye

### What was the end-user problem that led to this PR?

This addresses the problem described in issue #7131. `bundler/inline` does not respect `BUNDLE_PATH` env variable and installs gems to the default location.

### What was your diagnosis of the problem?

`Bundler.configure` is not called at any point in `bundler/inline`.

### What is your fix for the problem, implemented in this PR?

To call it :)

### Why did you choose this fix out of the possible options?

When bundler is invoked via `bundle install` this method gets called.

---

The included test is failing without this change as expected.

I have also tested it manually using the code from the issue on ruby 2.6 and with bundler `1.17.2` &amp; `2.0.1`.

Co-authored-by: robuye &lt;rulejczyk@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7154: bundler/inline should install gems to BUNDLE_PATH r=deivid-rodriguez a=robuye

### What was the end-user problem that led to this PR?

This addresses the problem described in issue #7131. `bundler/inline` does not respect `BUNDLE_PATH` env variable and installs gems to the default location.

### What was your diagnosis of the problem?

`Bundler.configure` is not called at any point in `bundler/inline`.

### What is your fix for the problem, implemented in this PR?

To call it :)

### Why did you choose this fix out of the possible options?

When bundler is invoked via `bundle install` this method gets called.

---

The included test is failing without this change as expected.

I have also tested it manually using the code from the issue on ruby 2.6 and with bundler `1.17.2` &amp; `2.0.1`.

Co-authored-by: robuye &lt;rulejczyk@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7161</title>
<updated>2019-06-24T10:33:28+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-06-24T10:33:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=c5dcdfbc3617d1ecf551f047456d4ea03a18f930'/>
<id>c5dcdfbc3617d1ecf551f047456d4ea03a18f930</id>
<content type='text'>
7161: Fix file URIs on Windows r=hsbt a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that file:// URIs were not properly handled on Windows, and those are heavily used by our specs.

### What was your diagnosis of the problem?

My diagnosis was that Windows paths do not start with a slash, so we need to add an extra slash to
separate the host from the path in file:// urls. Otherwise "D:" is parsed as the host segment in the URI.

As a consequence of that change, we also need to strip that leading character when using the path segment for those URIs, so that it's a valid file path on Windows.

This change reduces Windows CI spec failures from 429 to 355.

In order to apply this fix for all file URI's in tests, I extracted a helper method and searched and replaced all file:// ocurrences with the method. The diff is big because of that, but I think it works fine.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7161: Fix file URIs on Windows r=hsbt a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that file:// URIs were not properly handled on Windows, and those are heavily used by our specs.

### What was your diagnosis of the problem?

My diagnosis was that Windows paths do not start with a slash, so we need to add an extra slash to
separate the host from the path in file:// urls. Otherwise "D:" is parsed as the host segment in the URI.

As a consequence of that change, we also need to strip that leading character when using the path segment for those URIs, so that it's a valid file path on Windows.

This change reduces Windows CI spec failures from 429 to 355.

In order to apply this fix for all file URI's in tests, I extracted a helper method and searched and replaced all file:// ocurrences with the method. The diff is big because of that, but I think it works fine.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
</feed>
