<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/bundler.git/spec/plugins, branch parallel_rspec</title>
<subtitle>github.com: bundler/bundler.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/'/>
<entry>
<title>Normalize file:// handling in specs</title>
<updated>2019-06-11T10:36:19+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-05-06T16:06:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=5946d62ad03c57271ccb037680382b1db9fc2e65'/>
<id>5946d62ad03c57271ccb037680382b1db9fc2e65</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Move on to bundler 3</title>
<updated>2019-04-11T11:25:59+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-04-04T20:23:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=b9baa34673b96419410bd7c61d379bc8c89d798e'/>
<id>b9baa34673b96419410bd7c61d379bc8c89d798e</id>
<content type='text'>
* Drop bundler 1 stuff from tests.
* Move all feature flags to bundler 3 (like they are in 2-0-stable) and
get them tested.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Drop bundler 1 stuff from tests.
* Move all feature flags to bundler 3 (like they are in 2-0-stable) and
get them tested.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7007</title>
<updated>2019-04-02T07:11:40+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-04-02T07:11:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=d6f343cc5b69185c0bb45140d9e6b1fc4121688b'/>
<id>d6f343cc5b69185c0bb45140d9e6b1fc4121688b</id>
<content type='text'>
7007: Remove lockfile incompatibility created by the `lockfile_uses_separate_rubygems_sources` setting r=deivid-rodriguez a=deivid-rodriguez

This is more of a question PR, I created this patch to try it out and try to understand, not necessarily get it merged.

### What was the end-user problem that led to this PR?

The problem was that once we enable the `lockfile_uses_separate_rubygems_sources` setting, all lockfiles in the world will become incompatible with the previous version. Actually, not necessarily incompatible, but bundler will reorder the sections when the setting is enabled, that will generate churn lock file diffs, and _maybe_ some confusion / merge conflicts, and so on.

### What was your diagnosis of the problem?

My diagnosis was that maybe this is not necessary. I read over the issues where this setting was added and what I understood is that previously if a Gemfile specified multiple rubygems sources, they would all get merged together and that's dangerous because it's not deterministic from which source each gem will be picked up, and that could be maliciously exploited. So now each source gets its own separate section. However, how does that affect the ordering of the sections? I don't think it should affect it?

### What is your fix for the problem, implemented in this PR?

My fix is to change the `lock_sources` method so that both code branches (`lockfile_uses_separate_rubygems_sources == true`, and `lockfile_uses_separate_rubygems_sources == false`) result in the same ordering of the source sections.

### Why did you choose this fix out of the possible options?

I chose this fix because I _think_ it keeps the setting doing the same thing, but also keeps lock file compatibility.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7007: Remove lockfile incompatibility created by the `lockfile_uses_separate_rubygems_sources` setting r=deivid-rodriguez a=deivid-rodriguez

This is more of a question PR, I created this patch to try it out and try to understand, not necessarily get it merged.

### What was the end-user problem that led to this PR?

The problem was that once we enable the `lockfile_uses_separate_rubygems_sources` setting, all lockfiles in the world will become incompatible with the previous version. Actually, not necessarily incompatible, but bundler will reorder the sections when the setting is enabled, that will generate churn lock file diffs, and _maybe_ some confusion / merge conflicts, and so on.

### What was your diagnosis of the problem?

My diagnosis was that maybe this is not necessary. I read over the issues where this setting was added and what I understood is that previously if a Gemfile specified multiple rubygems sources, they would all get merged together and that's dangerous because it's not deterministic from which source each gem will be picked up, and that could be maliciously exploited. So now each source gets its own separate section. However, how does that affect the ordering of the sections? I don't think it should affect it?

### What is your fix for the problem, implemented in this PR?

My fix is to change the `lock_sources` method so that both code branches (`lockfile_uses_separate_rubygems_sources == true`, and `lockfile_uses_separate_rubygems_sources == false`) result in the same ordering of the source sections.

### Why did you choose this fix out of the possible options?

I chose this fix because I _think_ it keeps the setting doing the same thing, but also keeps lock file compatibility.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove ruby version leftovers</title>
<updated>2019-03-15T14:35:11+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-03-14T18:14:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=4c6e2ae1c08153ec0d390d292ee36fecae1f6a1e'/>
<id>4c6e2ae1c08153ec0d390d292ee36fecae1f6a1e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove lockfile incompatibility due to a setting</title>
<updated>2019-03-02T19:55:19+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-02-27T08:36:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=8c4b82e3a4ef42ab6fee9b324200a9e5ff20c948'/>
<id>8c4b82e3a4ef42ab6fee9b324200a9e5ff20c948</id>
<content type='text'>
The `lockfile_uses_separate_rubygems_sources` was causing a lockfile
incompatibility but in my opinion, this incompatibility is not necessary
in the general case.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The `lockfile_uses_separate_rubygems_sources` was causing a lockfile
incompatibility but in my opinion, this incompatibility is not necessary
in the general case.
</pre>
</div>
</content>
</entry>
<entry>
<title>add check for already installed plugin</title>
<updated>2019-02-20T21:29:59+00:00</updated>
<author>
<name>Ankit Kataria</name>
<email>ankitkataria28@gmail.com</email>
</author>
<published>2019-02-20T21:29:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=a0b91e3ad4e9243bdf73ca4eab6e755d93318899'/>
<id>a0b91e3ad4e9243bdf73ca4eab6e755d93318899</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Split stderr and stdout in specs</title>
<updated>2019-02-13T23:45:09+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-02-07T13:45:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=dac69e7b21cb05ad9df27941aab004abcb80b4ef'/>
<id>dac69e7b21cb05ad9df27941aab004abcb80b4ef</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>[Plugin] Ignore the deployment setting</title>
<updated>2018-11-24T18:25:51+00:00</updated>
<author>
<name>Samuel Giddins</name>
<email>segiddins@segiddins.me</email>
</author>
<published>2018-11-24T18:25:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=c6142c76301ce2cb47c7751700586a56cfdda8b4'/>
<id>c6142c76301ce2cb47c7751700586a56cfdda8b4</id>
<content type='text'>
This allows installing plugins when the bundler is frozen, since plugins are not locked anyways
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This allows installing plugins when the bundler is frozen, since plugins are not locked anyways
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #6749</title>
<updated>2018-10-19T08:01:04+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-10-19T08:01:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=74f142be8c322e035ae52894d4ea4166ffb93fbf'/>
<id>74f142be8c322e035ae52894d4ea4166ffb93fbf</id>
<content type='text'>
6749: Add local git repository source option (`--local_git`) to plugin installation r=indirect a=indirect

Reopening #6338 to close #5446.

Co-authored-by: Saverio Miroddi &lt;saverio.pub2@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
6749: Add local git repository source option (`--local_git`) to plugin installation r=indirect a=indirect

Reopening #6338 to close #5446.

Co-authored-by: Saverio Miroddi &lt;saverio.pub2@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove "no-color" tweaks from specs</title>
<updated>2018-10-02T00:26:22+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2018-10-01T23:23:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=9deb5447da89453c22686819782b034e62583b6b'/>
<id>9deb5447da89453c22686819782b034e62583b6b</id>
<content type='text'>
I don't know why it was there, and it makes things more complicated with
dealing and running assertions on ARGV.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I don't know why it was there, and it makes things more complicated with
dealing and running assertions on ARGV.
</pre>
</div>
</content>
</entry>
</feed>
