<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/bundler.git/spec/commands, branch https_sources</title>
<subtitle>github.com: bundler/bundler.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/'/>
<entry>
<title>Merge #6329</title>
<updated>2019-04-24T11:58:40+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-04-24T11:58:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=ec8f98574a90de1e87a50e00141180d761f161dc'/>
<id>ec8f98574a90de1e87a50e00141180d761f161dc</id>
<content type='text'>
6329: Stop printing “failed to update” message when changing sources r=segiddins a=segiddins

### What was the end-user problem that led to this PR?

The problem was `bundle update` shows incorrect message when updating git gems

Closes #6325 

### What was your diagnosis of the problem?

My diagnosis was we need to check if the source has changed

### What is your fix for the problem, implemented in this PR?

My fix only prints the message when the source has not changed

Note that is does not yet fix the "updated the git sha" case, since the locked spec and the new spec actually share the same source object!

Co-authored-by: Samuel Giddins &lt;segiddins@segiddins.me&gt;
Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
6329: Stop printing “failed to update” message when changing sources r=segiddins a=segiddins

### What was the end-user problem that led to this PR?

The problem was `bundle update` shows incorrect message when updating git gems

Closes #6325 

### What was your diagnosis of the problem?

My diagnosis was we need to check if the source has changed

### What is your fix for the problem, implemented in this PR?

My fix only prints the message when the source has not changed

Note that is does not yet fix the "updated the git sha" case, since the locked spec and the new spec actually share the same source object!

Co-authored-by: Samuel Giddins &lt;segiddins@segiddins.me&gt;
Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7127</title>
<updated>2019-04-23T19:30:19+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-04-23T19:30:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=58357f5bab5e7869d0532041bb44325d1832b036'/>
<id>58357f5bab5e7869d0532041bb44325d1832b036</id>
<content type='text'>
7127: Add git and branch options to `bundle add` r=deivid-rodriguez a=tokachev

Closes #6841 These changes will allow to add a gem with the git or branch options.

```
bundle add redis --git "https://github.com/redis/redis-rb" --branch "staging"
```

The result in Gemfile will be: 
```
gem "redis", "~&gt; 4.0", :git =&gt; "https://github.com/redis/redis-rb", :branch =&gt; "staging"
```

Co-authored-by: Baumgarten &lt;baumgarten@localhost.localdomain&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7127: Add git and branch options to `bundle add` r=deivid-rodriguez a=tokachev

Closes #6841 These changes will allow to add a gem with the git or branch options.

```
bundle add redis --git "https://github.com/redis/redis-rb" --branch "staging"
```

The result in Gemfile will be: 
```
gem "redis", "~&gt; 4.0", :git =&gt; "https://github.com/redis/redis-rb", :branch =&gt; "staging"
```

Co-authored-by: Baumgarten &lt;baumgarten@localhost.localdomain&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7128</title>
<updated>2019-04-14T12:40:12+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-04-14T12:40:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=0a20c21d87a85d5ce581480e8f6dd647b76176b2'/>
<id>0a20c21d87a85d5ce581480e8f6dd647b76176b2</id>
<content type='text'>
7128: Backport to workaround from ruby core. r=deivid-rodriguez a=hsbt

### What was the end-user problem that led to this PR?

The current master branch couldn't invoke with the ruby core repository.

### What was your diagnosis of the problem?

1. We need to add explicitly declare `rspec` in spec_helper.rb
2. Some examples were failed on ruby core repository.

### What is your fix for the problem, implemented in this PR?

1. simply added.
2. update the `ruby_repo` labels for skipping to run.


Co-authored-by: SHIBATA Hiroshi &lt;hsbt@ruby-lang.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7128: Backport to workaround from ruby core. r=deivid-rodriguez a=hsbt

### What was the end-user problem that led to this PR?

The current master branch couldn't invoke with the ruby core repository.

### What was your diagnosis of the problem?

1. We need to add explicitly declare `rspec` in spec_helper.rb
2. Some examples were failed on ruby core repository.

### What is your fix for the problem, implemented in this PR?

1. simply added.
2. update the `ruby_repo` labels for skipping to run.


Co-authored-by: SHIBATA Hiroshi &lt;hsbt@ruby-lang.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #6730</title>
<updated>2019-04-14T12:04:15+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-04-14T12:04:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=9424cedb913b738bbd733e30c772524ea054f5fe'/>
<id>9424cedb913b738bbd733e30c772524ea054f5fe</id>
<content type='text'>
6730: Print errors to stderr by default, and remove configuration option r=greysteil a=greysteil

### What was the end-user problem that led to this PR?

The problem was #6729 - Bundler unexpectedly outputs error and warning messages to STDOUT.

### What was your diagnosis of the problem?

My diagnosis was that whilst very minorly breaking, this is essentially a bug fix, and should be considered for inclusion for Bundler 2.0 even if very few other breaking changes are.

### What is your fix for the problem, implemented in this PR?

My fix was so switch output for warning and error messages to STDERR, and remove the configuration option (as is redundant once the setup is flipped - anyone wanting to redirect those message to STDOUT could do so in their shell).

### Why did you choose this fix out of the possible options?

I chose this fix because I think the new behaviour is what everyone would expect, and we should get it out from behind its feature switch sooner rather than later.

Alternatively, we might want to keep the Bundler 2.0 release "purer" by only dropping Ruby versions in it - that's totally fine too, but I figured we should have the code to discus #6729, rather than doing it in abstract.

Co-authored-by: Grey Baker &lt;greysteil@gmail.com&gt;
Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
6730: Print errors to stderr by default, and remove configuration option r=greysteil a=greysteil

### What was the end-user problem that led to this PR?

The problem was #6729 - Bundler unexpectedly outputs error and warning messages to STDOUT.

### What was your diagnosis of the problem?

My diagnosis was that whilst very minorly breaking, this is essentially a bug fix, and should be considered for inclusion for Bundler 2.0 even if very few other breaking changes are.

### What is your fix for the problem, implemented in this PR?

My fix was so switch output for warning and error messages to STDERR, and remove the configuration option (as is redundant once the setup is flipped - anyone wanting to redirect those message to STDOUT could do so in their shell).

### Why did you choose this fix out of the possible options?

I chose this fix because I think the new behaviour is what everyone would expect, and we should get it out from behind its feature switch sooner rather than later.

Alternatively, we might want to keep the Bundler 2.0 release "purer" by only dropping Ruby versions in it - that's totally fine too, but I figured we should have the code to discus #6729, rather than doing it in abstract.

Co-authored-by: Grey Baker &lt;greysteil@gmail.com&gt;
Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Update ruby_repo filter with the latest ruby-core implementaion.</title>
<updated>2019-04-14T10:43:35+00:00</updated>
<author>
<name>SHIBATA Hiroshi</name>
<email>hsbt@ruby-lang.org</email>
</author>
<published>2019-04-14T10:43:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=7ce68899d182f84b5a400cf5c5e217e1430b97a6'/>
<id>7ce68899d182f84b5a400cf5c5e217e1430b97a6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add git and branch options to `bundle add`</title>
<updated>2019-04-13T16:51:41+00:00</updated>
<author>
<name>Baumgarten</name>
<email>baumgarten@localhost.localdomain</email>
</author>
<published>2019-04-13T16:51:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=2aab1fd231f2af3a0f0a5888a7d5bb5cd079ceb6'/>
<id>2aab1fd231f2af3a0f0a5888a7d5bb5cd079ceb6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a failing spec for not warning when a git gem updates ref but not version</title>
<updated>2019-04-13T16:21:05+00:00</updated>
<author>
<name>Samuel Giddins</name>
<email>segiddins@segiddins.me</email>
</author>
<published>2018-03-07T04:45:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=5f6ee7a65f3231260ee846ae216c62fab70f7e6e'/>
<id>5f6ee7a65f3231260ee846ae216c62fab70f7e6e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>[Update] Stop printing “failed to update” message when changing sources</title>
<updated>2019-04-13T16:21:05+00:00</updated>
<author>
<name>Samuel Giddins</name>
<email>segiddins@segiddins.me</email>
</author>
<published>2018-03-07T04:44:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=3a83087a12fe4a42d2c5ae75da10993df469085e'/>
<id>3a83087a12fe4a42d2c5ae75da10993df469085e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>s/last_command.stdout/out/</title>
<updated>2019-04-12T08:48:05+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-04-12T08:48:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=c494e1261268a5249b6406fe35709016f7c4c3ac'/>
<id>c494e1261268a5249b6406fe35709016f7c4c3ac</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>s/last_command.stderr/err/</title>
<updated>2019-04-12T08:47:39+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-04-12T08:46:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=d5af877b6a51e0faaa6240089005ccca76dba727'/>
<id>d5af877b6a51e0faaa6240089005ccca76dba727</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
