<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/bundler.git/lib, branch dead_code</title>
<subtitle>github.com: bundler/bundler.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/'/>
<entry>
<title>Remove rubygems integration dead code</title>
<updated>2019-11-07T11:56:17+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-11-07T11:56:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=305ff80ae0f5d8852d0d11c835b30a233d5f32f4'/>
<id>305ff80ae0f5d8852d0d11c835b30a233d5f32f4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7417</title>
<updated>2019-11-07T09:57:38+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-07T09:57:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=a1ecdbffceded635d615fc31d4823a2a67a8db0d'/>
<id>a1ecdbffceded635d615fc31d4823a2a67a8db0d</id>
<content type='text'>
7417: Fix bundler/inline warning: method redefined; discarding old root r=deivid-rodriguez a=fatkodima

Closes #6167

Co-authored-by: fatkodima &lt;fatkodima123@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7417: Fix bundler/inline warning: method redefined; discarding old root r=deivid-rodriguez a=fatkodima

Closes #6167

Co-authored-by: fatkodima &lt;fatkodima123@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7416</title>
<updated>2019-11-07T09:12:08+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-07T09:12:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=ac758c84847a9850ae18226bfd5291e73e637ca3'/>
<id>ac758c84847a9850ae18226bfd5291e73e637ca3</id>
<content type='text'>
7416: Don't use insecure temporary directory as home directory r=deivid-rodriguez a=fatkodima

Closes #6501 

Co-authored-by: fatkodima &lt;fatkodima123@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7416: Don't use insecure temporary directory as home directory r=deivid-rodriguez a=fatkodima

Closes #6501 

Co-authored-by: fatkodima &lt;fatkodima123@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7424</title>
<updated>2019-11-06T12:51:35+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-06T12:51:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=0070d9fdddc027c0ee17662a1617e05b17331171'/>
<id>0070d9fdddc027c0ee17662a1617e05b17331171</id>
<content type='text'>
7424: Drop unnecessary `tempfile` require r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The `tempfile` dependency was dropped in [1], but the require was left in there. This could cause gem conflicts because `tempfile` requires `tmpdir` which requires `fileutils`, which loads the default gem instead of our namespaced version, and that could cause fileutils version mismatches and code overriding warnings.

[1]: https://github.com/bundler/bundler/commit/4a37d66f3f222739178d798b30fb135f2429fe45

### What is your fix for the problem, implemented in this PR?

My fix is to drop the unnecessary require.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7424: Drop unnecessary `tempfile` require r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The `tempfile` dependency was dropped in [1], but the require was left in there. This could cause gem conflicts because `tempfile` requires `tmpdir` which requires `fileutils`, which loads the default gem instead of our namespaced version, and that could cause fileutils version mismatches and code overriding warnings.

[1]: https://github.com/bundler/bundler/commit/4a37d66f3f222739178d798b30fb135f2429fe45

### What is your fix for the problem, implemented in this PR?

My fix is to drop the unnecessary require.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Drop unnecessary `tempfile` require</title>
<updated>2019-11-06T11:16:01+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-11-06T11:16:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=dcf9d21d1ad8f0a59433c630f4ab4aeadd722eff'/>
<id>dcf9d21d1ad8f0a59433c630f4ab4aeadd722eff</id>
<content type='text'>
The `tempfile` dependency was dropped in [1], but the require was left
in there. This could cause gem conflicts because `tempfile` requires
`tmpdir` which requires `fileutils`, which loads the default gem instead
of our namespaced version, and that could cause fileutils version
mismatches and code overriding warnings.

[1]: https://github.com/bundler/bundler/commit/4a37d66f3f222739178d798b30fb135f2429fe45
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The `tempfile` dependency was dropped in [1], but the require was left
in there. This could cause gem conflicts because `tempfile` requires
`tmpdir` which requires `fileutils`, which loads the default gem instead
of our namespaced version, and that could cause fileutils version
mismatches and code overriding warnings.

[1]: https://github.com/bundler/bundler/commit/4a37d66f3f222739178d798b30fb135f2429fe45
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7393</title>
<updated>2019-11-06T09:34:09+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-06T09:34:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=f83412ae8cda9c933b8cf33ec2abfb78a408daab'/>
<id>f83412ae8cda9c933b8cf33ec2abfb78a408daab</id>
<content type='text'>
7393: Make 'bundle add' cache newly added gems when needed r=deivid-rodriguez a=andrehjr

### What was the end-user problem that led to this PR?

The problem was that when calling `bundle add` with cache_all as true, I have to call an additional `bundle install` to vendor gems.

### What was your diagnosis of the problem?

My diagnosis was that a call to Bundler.load.cache was missing. For example Bundler::CLI::Update does the same after installing gems.

### What is your fix for the problem, implemented in this PR?

My fix was to call Bundler.load.cache when `Bundler.app_cache.exist? ` 

### Why did you choose this fix out of the possible options?

I chose this fix because it looks like this makes the behavior consistent with other commands.

I should also say that, as this is my first PR here, I'm not sure that this is the best solution, and it seems an easy fix for #7384. 

Co-authored-by: André Luis Leal Cardoso Junior &lt;andrehjr@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7393: Make 'bundle add' cache newly added gems when needed r=deivid-rodriguez a=andrehjr

### What was the end-user problem that led to this PR?

The problem was that when calling `bundle add` with cache_all as true, I have to call an additional `bundle install` to vendor gems.

### What was your diagnosis of the problem?

My diagnosis was that a call to Bundler.load.cache was missing. For example Bundler::CLI::Update does the same after installing gems.

### What is your fix for the problem, implemented in this PR?

My fix was to call Bundler.load.cache when `Bundler.app_cache.exist? ` 

### Why did you choose this fix out of the possible options?

I chose this fix because it looks like this makes the behavior consistent with other commands.

I should also say that, as this is my first PR here, I'm not sure that this is the best solution, and it seems an easy fix for #7384. 

Co-authored-by: André Luis Leal Cardoso Junior &lt;andrehjr@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7394</title>
<updated>2019-11-06T00:46:53+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-06T00:46:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=a7cc4ec87f17e549a1f0fb9063c53a76889426d6'/>
<id>a7cc4ec87f17e549a1f0fb9063c53a76889426d6</id>
<content type='text'>
7394: Add inline RDoc documentation r=hsbt a=zverok

Since Bundler became part of the standard library, it renders in Ruby's docs. Unfortunately, what renders there...  is not really helpful: https://docs.ruby-lang.org/en/master/Bundler.html

I've added rudimentary documentation for `Bundler` module and two of its most user-facing methods to solve this problem at least partially.

Co-authored-by: zverok &lt;zverok.offline@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7394: Add inline RDoc documentation r=hsbt a=zverok

Since Bundler became part of the standard library, it renders in Ruby's docs. Unfortunately, what renders there...  is not really helpful: https://docs.ruby-lang.org/en/master/Bundler.html

I've added rudimentary documentation for `Bundler` module and two of its most user-facing methods to solve this problem at least partially.

Co-authored-by: zverok &lt;zverok.offline@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Grammar</title>
<updated>2019-11-05T17:32:50+00:00</updated>
<author>
<name>zverok</name>
<email>zverok.offline@gmail.com</email>
</author>
<published>2019-11-05T17:32:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=9e0641e588ea02456b5b7bdf9bbde0436f8a56f2'/>
<id>9e0641e588ea02456b5b7bdf9bbde0436f8a56f2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unnecessary lines from `bundler/setup`</title>
<updated>2019-11-05T09:28:29+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-10-30T10:09:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=0698cb1519f4ddad388024cea83867f339219b4c'/>
<id>0698cb1519f4ddad388024cea83867f339219b4c</id>
<content type='text'>
Bundler no longer needs to be in the `$LOAD_PATH` once a version of
itself has been loaded.

In any case, the `Metadata` source takes care of adding `bundler` to the
index:

https://github.com/bundler/bundler/blob/e70643c1be3a4417bd537d7e63470265465e693e/lib/bundler/source/metadata.rb#L13-L30

and then that spec is added to the resolution here:

https://github.com/bundler/bundler/blob/e70643c1be3a4417bd537d7e63470265465e693e/lib/bundler/definition.rb#L180-L184

And from the resulting set of specs, the `$LOAD_PATH` is setup:

https://github.com/bundler/bundler/blob/e70643c1be3a4417bd537d7e63470265465e693e/lib/bundler/runtime.rb#L25-L38

So `bundler` will be present in the `$LOAD_PATH` anyways, and the lines
being removed here will never be useful.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Bundler no longer needs to be in the `$LOAD_PATH` once a version of
itself has been loaded.

In any case, the `Metadata` source takes care of adding `bundler` to the
index:

https://github.com/bundler/bundler/blob/e70643c1be3a4417bd537d7e63470265465e693e/lib/bundler/source/metadata.rb#L13-L30

and then that spec is added to the resolution here:

https://github.com/bundler/bundler/blob/e70643c1be3a4417bd537d7e63470265465e693e/lib/bundler/definition.rb#L180-L184

And from the resulting set of specs, the `$LOAD_PATH` is setup:

https://github.com/bundler/bundler/blob/e70643c1be3a4417bd537d7e63470265465e693e/lib/bundler/runtime.rb#L25-L38

So `bundler` will be present in the `$LOAD_PATH` anyways, and the lines
being removed here will never be useful.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make bundle add caches newly added gems when needed.</title>
<updated>2019-11-04T18:10:40+00:00</updated>
<author>
<name>André Luis Leal Cardoso Junior</name>
<email>andrehjr@gmail.com</email>
</author>
<published>2019-10-25T19:23:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=293ad80da8939f766fe886c7653903f09b6133d8'/>
<id>293ad80da8939f766fe886c7653903f09b6133d8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
