<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/bundler.git, branch rubymorillo-patch-2</title>
<subtitle>github.com: bundler/bundler.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/'/>
<entry>
<title>Made small copy tweaks, removed redundant phrasing</title>
<updated>2018-03-27T21:21:38+00:00</updated>
<author>
<name>Stephanie Morillo</name>
<email>rubymorillo@users.noreply.github.com</email>
</author>
<published>2018-03-27T21:21:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=6b1574c69c93a787e8e4b8d9b03832df7f5095e9'/>
<id>6b1574c69c93a787e8e4b8d9b03832df7f5095e9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Auto merge of #6305 - wagenet:fix-git-pristine, r=indirect</title>
<updated>2018-03-27T19:47:41+00:00</updated>
<author>
<name>The Bundler Bot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-03-27T19:47:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=77dbd12d0759ca635e3cb5cb0e90840cdac7f0d0'/>
<id>77dbd12d0759ca635e3cb5cb0e90840cdac7f0d0</id>
<content type='text'>
Correctly re-install extensions when running `pristine` for a git source

### What was the end-user problem that led to this PR?

I have a gem with a native extension that is installed via git. I had to recompile it due to some needed build arguments.

### The problem was...

Running `bundle pristine` would not recompile it as expected.

### My diagnosis was...

After digging into the source, I discovered that the built extension lived in a different location than the cloned git repo. `bundle pristine` was only removing the git repo so the built extension was not getting rebuilt.

### My fix...

Update `bundle pristine` to also remove the built extension. For 2.0, this also required removing the built extension cache. Without doing that, the built extension directory would just be recreated from the cache.

### I chose this fix because...

As far as I know, it's the only solution.

Resolves #6294
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Correctly re-install extensions when running `pristine` for a git source

### What was the end-user problem that led to this PR?

I have a gem with a native extension that is installed via git. I had to recompile it due to some needed build arguments.

### The problem was...

Running `bundle pristine` would not recompile it as expected.

### My diagnosis was...

After digging into the source, I discovered that the built extension lived in a different location than the cloned git repo. `bundle pristine` was only removing the git repo so the built extension was not getting rebuilt.

### My fix...

Update `bundle pristine` to also remove the built extension. For 2.0, this also required removing the built extension cache. Without doing that, the built extension directory would just be recreated from the cache.

### I chose this fix because...

As far as I know, it's the only solution.

Resolves #6294
</pre>
</div>
</content>
</entry>
<entry>
<title>Auto merge of #6446 - bundler:segiddins/remove-unused-ivar, r=colby-swandale</title>
<updated>2018-03-19T04:39:37+00:00</updated>
<author>
<name>The Bundler Bot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-03-19T04:39:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=0fc3fc1c32bc633334df42aca3f7976c6444c24e'/>
<id>0fc3fc1c32bc633334df42aca3f7976c6444c24e</id>
<content type='text'>
[SpecGroup] Remove unused ivar

### What was the end-user problem that led to this PR?

The problem was this ivar was unused.

### What was your diagnosis of the problem?

My diagnosis was we should remove it. For performance, you know.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
[SpecGroup] Remove unused ivar

### What was the end-user problem that led to this PR?

The problem was this ivar was unused.

### What was your diagnosis of the problem?

My diagnosis was we should remove it. For performance, you know.
</pre>
</div>
</content>
</entry>
<entry>
<title>[SpecGroup] Remove unused ivar</title>
<updated>2018-03-19T01:20:56+00:00</updated>
<author>
<name>Samuel Giddins</name>
<email>segiddins@segiddins.me</email>
</author>
<published>2018-03-19T01:20:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=34149335e299d76311fd9ff2162d99934ff715e2'/>
<id>34149335e299d76311fd9ff2162d99934ff715e2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Auto merge of #6444 - greysteil:handle-gem-specific-updates-non-local-platform, r=segiddins</title>
<updated>2018-03-18T17:18:12+00:00</updated>
<author>
<name>The Bundler Bot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-03-18T17:18:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=91a3e3fd69bfb2fa5e5293dbe012c4ada0c7b49b'/>
<id>91a3e3fd69bfb2fa5e5293dbe012c4ada0c7b49b</id>
<content type='text'>
Handle updating a specific gem for a non-local platform

Fixes https://github.com/bundler/bundler/issues/6350.

Kudos to @segiddins for the test.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Handle updating a specific gem for a non-local platform

Fixes https://github.com/bundler/bundler/issues/6350.

Kudos to @segiddins for the test.
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle updating a specific gem for a non-local platform</title>
<updated>2018-03-18T12:06:34+00:00</updated>
<author>
<name>Grey Baker</name>
<email>greysteil@gmail.com</email>
</author>
<published>2018-03-18T12:06:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=25be4c9f5e1d61e782f4599cece08ba1bc8c7bac'/>
<id>25be4c9f5e1d61e782f4599cece08ba1bc8c7bac</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Auto merge of #6310 - utilum:rescue_unspecified_exception, r=segiddins</title>
<updated>2018-03-17T21:24:30+00:00</updated>
<author>
<name>The Bundler Bot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-03-17T21:24:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=ff6b8712a0337305ba9617e35545b9e8f8cd4a53'/>
<id>ff6b8712a0337305ba9617e35545b9e8f8cd4a53</id>
<content type='text'>
Fix some rescue calls that do not specifiy error type.

### What was the end-user problem that led to this PR?

The problem I noticed was in style, several instances of `rescue` clauses that do not specify an exception type. This is noted in in the Ruby Style Guide as [Avoid rescuing the Exception class](https://github.com/bbatsov/ruby-style-guide#no-blind-rescues).

### What was your diagnosis of the problem?

My diagnosis was that at least some of those are leftover style. They are noted in `.rubocop_todo.yml`. To make sure, I asked on Slack.

### What is your fix for the problem, implemented in this PR?

My fix is to make as many of them more specific, specifying at least `StandardError`, and trying to be more specific.

### Why did you choose this fix out of the possible options?

No other ways of addressing this came to mind. I'd be happy to consider.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix some rescue calls that do not specifiy error type.

### What was the end-user problem that led to this PR?

The problem I noticed was in style, several instances of `rescue` clauses that do not specify an exception type. This is noted in in the Ruby Style Guide as [Avoid rescuing the Exception class](https://github.com/bbatsov/ruby-style-guide#no-blind-rescues).

### What was your diagnosis of the problem?

My diagnosis was that at least some of those are leftover style. They are noted in `.rubocop_todo.yml`. To make sure, I asked on Slack.

### What is your fix for the problem, implemented in this PR?

My fix is to make as many of them more specific, specifying at least `StandardError`, and trying to be more specific.

### Why did you choose this fix out of the possible options?

No other ways of addressing this came to mind. I'd be happy to consider.
</pre>
</div>
</content>
</entry>
<entry>
<title>Rescue StandardError from Etc.nprocessors since it can raise NoMethodError on Ruby 1.8.7</title>
<updated>2018-03-17T18:41:38+00:00</updated>
<author>
<name>Samuel Giddins</name>
<email>segiddins@segiddins.me</email>
</author>
<published>2018-03-17T18:41:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=c18c48d67ca99c357b4dabbb5d40790384cb5435'/>
<id>c18c48d67ca99c357b4dabbb5d40790384cb5435</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Auto merge of #6346 - nesaulov:explain-spec-files, r=segiddins</title>
<updated>2018-03-17T18:40:22+00:00</updated>
<author>
<name>The Bundler Bot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-03-17T18:40:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=94d328be35394eecce9b9d2b42848195e6f204c2'/>
<id>94d328be35394eecce9b9d2b42848195e6f204c2</id>
<content type='text'>
Explain spec files and output a link to bundler.io guides

Resolves #6246

### What was the end-user problem that led to this PR?

1. There is no helpful comment about `spec.files` method in a new gem's gemspec.
2. `$ bundle gem gem_name` is missing link to further reading about developing, testing and releasing the newly created gem.

### What is your fix for the problem, implemented in this PR?

1. Add a comment in the `newgem.gemspec.tt`
2. Add a message after new gem generation with link to [bundler.io guides](https://bundler.io/guides/creating_gem.html)

Example:
```bash
๛  ~/code/oss/tmp $  ../bundler/bin/bundle gem new_gem
Creating gem 'new_gem'...
      create  new_gem/Gemfile
      create  new_gem/lib/new_gem.rb
      create  new_gem/lib/new_gem/version.rb
      create  new_gem/new_gem.gemspec
      create  new_gem/Rakefile
      create  new_gem/README.md
      create  new_gem/bin/console
      create  new_gem/bin/setup
      create  new_gem/.gitignore
Initializing git repo in /Users/nesaulov/code/oss/tmp/new_gem
Gem 'new_gem' was successfully created. For detailed information on further steps please visit https://bundler.io/guides/creating_gem.html
๛  ~/code/oss/tmp $
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Explain spec files and output a link to bundler.io guides

Resolves #6246

### What was the end-user problem that led to this PR?

1. There is no helpful comment about `spec.files` method in a new gem's gemspec.
2. `$ bundle gem gem_name` is missing link to further reading about developing, testing and releasing the newly created gem.

### What is your fix for the problem, implemented in this PR?

1. Add a comment in the `newgem.gemspec.tt`
2. Add a message after new gem generation with link to [bundler.io guides](https://bundler.io/guides/creating_gem.html)

Example:
```bash
๛  ~/code/oss/tmp $  ../bundler/bin/bundle gem new_gem
Creating gem 'new_gem'...
      create  new_gem/Gemfile
      create  new_gem/lib/new_gem.rb
      create  new_gem/lib/new_gem/version.rb
      create  new_gem/new_gem.gemspec
      create  new_gem/Rakefile
      create  new_gem/README.md
      create  new_gem/bin/console
      create  new_gem/bin/setup
      create  new_gem/.gitignore
Initializing git repo in /Users/nesaulov/code/oss/tmp/new_gem
Gem 'new_gem' was successfully created. For detailed information on further steps please visit https://bundler.io/guides/creating_gem.html
๛  ~/code/oss/tmp $
```
</pre>
</div>
</content>
</entry>
<entry>
<title>Auto merge of #6349 - shime:check-if-stderr-is-closed-before-reporting-errors, r=segiddins</title>
<updated>2018-03-17T18:08:24+00:00</updated>
<author>
<name>The Bundler Bot</name>
<email>bot@bundler.io</email>
</author>
<published>2018-03-17T18:08:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=6a7af6b4016ad2c659a66cff86074f7dd52b3cdf'/>
<id>6a7af6b4016ad2c659a66cff86074f7dd52b3cdf</id>
<content type='text'>
Fix to check if stderr was closed before writing to it

### What was the end-user problem that led to this PR?

See https://github.com/bundler/bundler/issues/6190

### What was your diagnosis of the problem?

The error is happening because we're not checking if stderr is closed prior to writing to it.

### What is your fix for the problem, implemented in this PR?

My fix is to add a check to determine if stderr was closed.

### Why did you choose this fix out of the possible options?

I chose to fix it here for a start and discuss with others if more checks were needed. Maybe we need to check if stderr is closed for all references of `$stderr.puts` and replace `abort` with `$stderr.puts` and `exit(1)`?
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix to check if stderr was closed before writing to it

### What was the end-user problem that led to this PR?

See https://github.com/bundler/bundler/issues/6190

### What was your diagnosis of the problem?

The error is happening because we're not checking if stderr is closed prior to writing to it.

### What is your fix for the problem, implemented in this PR?

My fix is to add a check to determine if stderr was closed.

### Why did you choose this fix out of the possible options?

I chose to fix it here for a start and discuss with others if more checks were needed. Maybe we need to check if stderr is closed for all references of `$stderr.puts` and replace `abort` with `$stderr.puts` and `exit(1)`?
</pre>
</div>
</content>
</entry>
</feed>
