<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/bundler.git, branch dead_code</title>
<subtitle>github.com: bundler/bundler.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/'/>
<entry>
<title>Remove rubygems integration dead code</title>
<updated>2019-11-07T11:56:17+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-11-07T11:56:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=305ff80ae0f5d8852d0d11c835b30a233d5f32f4'/>
<id>305ff80ae0f5d8852d0d11c835b30a233d5f32f4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7417</title>
<updated>2019-11-07T09:57:38+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-07T09:57:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=a1ecdbffceded635d615fc31d4823a2a67a8db0d'/>
<id>a1ecdbffceded635d615fc31d4823a2a67a8db0d</id>
<content type='text'>
7417: Fix bundler/inline warning: method redefined; discarding old root r=deivid-rodriguez a=fatkodima

Closes #6167

Co-authored-by: fatkodima &lt;fatkodima123@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7417: Fix bundler/inline warning: method redefined; discarding old root r=deivid-rodriguez a=fatkodima

Closes #6167

Co-authored-by: fatkodima &lt;fatkodima123@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7416</title>
<updated>2019-11-07T09:12:08+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-07T09:12:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=ac758c84847a9850ae18226bfd5291e73e637ca3'/>
<id>ac758c84847a9850ae18226bfd5291e73e637ca3</id>
<content type='text'>
7416: Don't use insecure temporary directory as home directory r=deivid-rodriguez a=fatkodima

Closes #6501 

Co-authored-by: fatkodima &lt;fatkodima123@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7416: Don't use insecure temporary directory as home directory r=deivid-rodriguez a=fatkodima

Closes #6501 

Co-authored-by: fatkodima &lt;fatkodima123@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7427</title>
<updated>2019-11-06T23:07:51+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-06T23:07:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=6f452d62eb76c2699988e75b7a0eb69232026259'/>
<id>6f452d62eb76c2699988e75b7a0eb69232026259</id>
<content type='text'>
7427: Pass `env` as a parameter to `sys_exec` r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that Windows has trouble with commands of the form `BUNDLE_FROZEN=true bundle install`.

### What was your diagnosis of the problem?

My diagnosis was that we should use `Open3.popen3` explicit `env` argument instead of passing a command line that has environment variables in the front.

### What is your fix for the problem, implemented in this PR?

My fix is to do just that. This is a follow up to #7011, but specifically for the `ruby` test helper. I expect this to fix some more Windows failures.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7427: Pass `env` as a parameter to `sys_exec` r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that Windows has trouble with commands of the form `BUNDLE_FROZEN=true bundle install`.

### What was your diagnosis of the problem?

My diagnosis was that we should use `Open3.popen3` explicit `env` argument instead of passing a command line that has environment variables in the front.

### What is your fix for the problem, implemented in this PR?

My fix is to do just that. This is a follow up to #7011, but specifically for the `ruby` test helper. I expect this to fix some more Windows failures.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Pass `env` as a parameter to `sys_exec`</title>
<updated>2019-11-06T20:45:31+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-11-05T11:59:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=036efa71c7092a04acf17ac3e2856df95838e589'/>
<id>036efa71c7092a04acf17ac3e2856df95838e589</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7426</title>
<updated>2019-11-06T20:01:20+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-06T20:01:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=b12a21f8cd2ab0ed66a6d0083df14b1444444198'/>
<id>b12a21f8cd2ab0ed66a6d0083df14b1444444198</id>
<content type='text'>
7426: Revert "I don't think we need this now" r=deivid-rodriguez a=deivid-rodriguez

This reverts commit 36816866581147ba7bd491a2a658ac35a2f03afe.

### What was the end-user problem that led to this PR?

The problem was that in #7401, after I got specs passing against a non-silenced by default UI, I started undoing workarounds that I thought were due to the silent by default UI. 

### What was your diagnosis of the problem?

My diagnosis was that in the case I'm reverting here this is not actually fixed, [as the Azure Pipelines logs confirm](https://dev.azure.com/bundler/bundler/_build/results?buildId=2662&amp;view=ms.vss-test-web.build-test-results-tab&amp;runId=1003360&amp;resultId=101526&amp;paneView=debug).

### What is your fix for the problem, implemented in this PR?

My fix is to unrevert the specific commit that I shouldn't have reverted.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7426: Revert "I don't think we need this now" r=deivid-rodriguez a=deivid-rodriguez

This reverts commit 36816866581147ba7bd491a2a658ac35a2f03afe.

### What was the end-user problem that led to this PR?

The problem was that in #7401, after I got specs passing against a non-silenced by default UI, I started undoing workarounds that I thought were due to the silent by default UI. 

### What was your diagnosis of the problem?

My diagnosis was that in the case I'm reverting here this is not actually fixed, [as the Azure Pipelines logs confirm](https://dev.azure.com/bundler/bundler/_build/results?buildId=2662&amp;view=ms.vss-test-web.build-test-results-tab&amp;runId=1003360&amp;resultId=101526&amp;paneView=debug).

### What is your fix for the problem, implemented in this PR?

My fix is to unrevert the specific commit that I shouldn't have reverted.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "I don't think we need this now"</title>
<updated>2019-11-06T17:22:24+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-11-06T17:22:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=1e6ae6bc5eff12e43b909940eb7b95e9598c2dc4'/>
<id>1e6ae6bc5eff12e43b909940eb7b95e9598c2dc4</id>
<content type='text'>
This reverts commit 36816866581147ba7bd491a2a658ac35a2f03afe.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit 36816866581147ba7bd491a2a658ac35a2f03afe.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7425</title>
<updated>2019-11-06T16:03:03+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-06T16:03:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=3eabc1ca06e39e455469adf72e5d57e292dd08fc'/>
<id>3eabc1ca06e39e455469adf72e5d57e292dd08fc</id>
<content type='text'>
7425: Properly avoid readline crashes when running specs on Windows r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that specs cannot be run on windows unless you add the ugly workaround currently included in the azure pipelines config.

### What was your diagnosis of the problem?

My diagnosis was that the `tmp/tmpdir` and `tmp/home` folder (which act as `ENV["HOME"]` and `ENV["TMPDIR"]` for our specs) are emptied in an `around(:each)` hook, but there's some stuff going before that and after `ENV["HOME"]` and `ENV["TMPDIR"]` are set (on a `before(:suite)` hook) that might require the folders they point to to exist.

This is the case of rb-readline, used on Windows:

https://github.com/ConnorAtherton/rb-readline/blob/9fba246073f78831b7c7129c76cc07d8476a8892/lib/rbreadline.rb#L1096

or any bundler's code that uses `Bundler.user_home`:

https://github.com/bundler/bundler/blob/f83412ae8cda9c933b8cf33ec2abfb78a408daab/lib/bundler.rb#L227

For example, running `rm -rf tmp/ &amp;&amp; bin/rspec ./spec/other/major_deprecation_spec.rb:368` prints a warning about this that it's fixed by this PR:

```
$ rm -rf tmp/ &amp;&amp; bin/rspec ./spec/other/major_deprecation_spec.rb:368 

Randomized with seed 1955

(... stuff ...)

`/home/deivid/Code/bundler/tmp/1/home` is not a directory.
Bundler will use `/tmp/bundler/home/deivid' as your home directory temporarily.
.

Retried examples: 0


Finished in 5.26 seconds (files took 0.17927 seconds to load)
1 example, 0 failures

Randomized with seed 1955
```

### What is your fix for the problem, implemented in this PR?

My fix is to create the folders as soon as the environment variables are set.

### Why did you choose this fix out of the possible options?

I chose this fix because it's more general that a workaround living on a specific CI config.

Fixes #6902.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7425: Properly avoid readline crashes when running specs on Windows r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that specs cannot be run on windows unless you add the ugly workaround currently included in the azure pipelines config.

### What was your diagnosis of the problem?

My diagnosis was that the `tmp/tmpdir` and `tmp/home` folder (which act as `ENV["HOME"]` and `ENV["TMPDIR"]` for our specs) are emptied in an `around(:each)` hook, but there's some stuff going before that and after `ENV["HOME"]` and `ENV["TMPDIR"]` are set (on a `before(:suite)` hook) that might require the folders they point to to exist.

This is the case of rb-readline, used on Windows:

https://github.com/ConnorAtherton/rb-readline/blob/9fba246073f78831b7c7129c76cc07d8476a8892/lib/rbreadline.rb#L1096

or any bundler's code that uses `Bundler.user_home`:

https://github.com/bundler/bundler/blob/f83412ae8cda9c933b8cf33ec2abfb78a408daab/lib/bundler.rb#L227

For example, running `rm -rf tmp/ &amp;&amp; bin/rspec ./spec/other/major_deprecation_spec.rb:368` prints a warning about this that it's fixed by this PR:

```
$ rm -rf tmp/ &amp;&amp; bin/rspec ./spec/other/major_deprecation_spec.rb:368 

Randomized with seed 1955

(... stuff ...)

`/home/deivid/Code/bundler/tmp/1/home` is not a directory.
Bundler will use `/tmp/bundler/home/deivid' as your home directory temporarily.
.

Retried examples: 0


Finished in 5.26 seconds (files took 0.17927 seconds to load)
1 example, 0 failures

Randomized with seed 1955
```

### What is your fix for the problem, implemented in this PR?

My fix is to create the folders as soon as the environment variables are set.

### Why did you choose this fix out of the possible options?

I chose this fix because it's more general that a workaround living on a specific CI config.

Fixes #6902.

Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge #7424</title>
<updated>2019-11-06T12:51:35+00:00</updated>
<author>
<name>Bundlerbot</name>
<email>bot@bundler.io</email>
</author>
<published>2019-11-06T12:51:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=0070d9fdddc027c0ee17662a1617e05b17331171'/>
<id>0070d9fdddc027c0ee17662a1617e05b17331171</id>
<content type='text'>
7424: Drop unnecessary `tempfile` require r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The `tempfile` dependency was dropped in [1], but the require was left in there. This could cause gem conflicts because `tempfile` requires `tmpdir` which requires `fileutils`, which loads the default gem instead of our namespaced version, and that could cause fileutils version mismatches and code overriding warnings.

[1]: https://github.com/bundler/bundler/commit/4a37d66f3f222739178d798b30fb135f2429fe45

### What is your fix for the problem, implemented in this PR?

My fix is to drop the unnecessary require.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
7424: Drop unnecessary `tempfile` require r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The `tempfile` dependency was dropped in [1], but the require was left in there. This could cause gem conflicts because `tempfile` requires `tmpdir` which requires `fileutils`, which loads the default gem instead of our namespaced version, and that could cause fileutils version mismatches and code overriding warnings.

[1]: https://github.com/bundler/bundler/commit/4a37d66f3f222739178d798b30fb135f2429fe45

### What is your fix for the problem, implemented in this PR?

My fix is to drop the unnecessary require.


Co-authored-by: David Rodríguez &lt;deivid.rodriguez@riseup.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Properly avoid readline crashes when running specs on Windows</title>
<updated>2019-11-06T12:49:47+00:00</updated>
<author>
<name>David Rodríguez</name>
<email>deivid.rodriguez@riseup.net</email>
</author>
<published>2019-11-06T12:21:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/bundler.git/commit/?id=3d6e6a1a57ce40d2a5da166c8299ab4c3b57aacc'/>
<id>3d6e6a1a57ce40d2a5da166c8299ab4c3b57aacc</id>
<content type='text'>
This also avoids the following warning when running specs on any
platform:

```
`/home/deivid/Code/bundler/tmp/1/home` is not a directory.
Bundler will use `/tmp/bundler/home/deivid' as your home directory temporarily
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This also avoids the following warning when running specs on any
platform:

```
`/home/deivid/Code/bundler/tmp/1/home` is not a directory.
Bundler will use `/tmp/bundler/home/deivid' as your home directory temporarily
```
</pre>
</div>
</content>
</entry>
</feed>
