6798: Use https in the Github shortcut by default in Bundler 2 r=colby-swandale a=colby-swandale This PR is setting Git gems to be fetched over https by default. Note: This PR is successing #6791 Closes #6785 Co-authored-by: Colby Swandale <me@colby.fyi> (cherry picked from commit cf45792213fadf97f7aa6464de8ebd79f09725d2)
Backport `GemHelper` changes for #7108
7080: Always pass the `--all` flag when needed r=deivid-rodriguez a=deivid-rodriguez The problem was that some specs were still using `bundle update` to update all gems, which is deprecated. My fix is to update all specs to use the new preferred command, namely, `bundle update --all`. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 63cc70aa2573345ebfb6bddaeef0b9d465591dd9) (cherry picked from commit e423c83f1f6bccbfc992bca7aef2ad31d6449d75)
7089: Normalize file URIs in spec's lockfiles r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that bumping bundler's version in #7088 made a lockfile spec fail. ### What was your diagnosis of the problem? My diagnosis was that there was a combination of bugs that was making this spec pass, but the spec was incorrect. ### What is your fix for the problem, implemented in this PR? My fix is to change the test version the spec uses to not hit https://github.com/rubygems/rubygems/issues/2595, and thus reproduce the failure. And then fix the spec that was incorrect because the lockfile written had different URLs (`file://localhost/<stuff>`) from the lockfile we were checking against (`file://<stuff>`), thus tricking `bundle install` into thinking something had changed, and thus making it rewrite it with an incorrect bundler version. ### Why did you choose this fix out of the possible options? I chose this fix because it makes #7088 pass and it reduces surprises. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 4cae424d604cbeb8ee84127a6b8896c45e7e2c84)
7068: Bump vendored fileutils to 1.2.0 r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was we manually updated some code in the vendored fileutils instead of using a released version. ### What was your diagnosis of the problem? My diagnosis was that we should use the recently released fileutils 1.2.0. ### What is your fix for the problem, implemented in this PR? My fix is to vendor it through `bin/rake vendor:fileutils[v1.2.0]`. ### Why did you choose this fix out of the possible options? I chose this fix because it properly upgrades the vendored code to match what's last released. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 2167156db020fbe6ce74759cbf62ad1ceb651fb7)
7036: Bump travis rubies r=hsbt a=deivid-rodriguez The problem was that hacks create confusion, even if they include TODO notes. My diagnosis was that we can should upgrade to the latest ruby releases to reduce the number of hacks we need to maintain. My fix is to upgrade rubies and remove hacks. I chose this fix because it's a good change. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit d368aa9e6257a27fab31efe0396069c8977cdc99)
7067: Tweaking vendoring r=hsbt a=deivid-rodriguez The problem was that we were not using the latest versions of some of our vendored dependencies. My diagnosis was that we should upgrade them. My fix is to upgrade them using `automatiek`, and add a few tweaks to our vendoring setup. I chose this fix because.... I didn't really considered other options. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 6f39ea5b15d61e5bdf7915bc94d66c31b1242d15)