From 7fde8dde9d9ab0f885e3a5cdb5e0b868a3ac0c28 Mon Sep 17 00:00:00 2001 From: Benjamin Schubert Date: Sat, 4 Jul 2020 14:24:55 +0000 Subject: app.py: Remove unnecessary operation in _message() This copies a dictionary before it gets expanded, which is not necessary since the expansion will not keep the dictionary as is --- src/buildstream/_frontend/app.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/buildstream/_frontend/app.py b/src/buildstream/_frontend/app.py index b77cfc130..e7831dac3 100644 --- a/src/buildstream/_frontend/app.py +++ b/src/buildstream/_frontend/app.py @@ -516,8 +516,7 @@ class App: # Local message propagator # def _message(self, message_type, message, **kwargs): - args = dict(kwargs) - self.context.messenger.message(Message(message_type, message, **args)) + self.context.messenger.message(Message(message_type, message, **kwargs)) # Exception handler # -- cgit v1.2.1 From 17548ebca305f9b10a2d228abf916e70be38cfef Mon Sep 17 00:00:00 2001 From: Benjamin Schubert Date: Sat, 4 Jul 2020 16:10:05 +0000 Subject: sandbox.py: Remove unused import --- src/buildstream/sandbox/sandbox.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/buildstream/sandbox/sandbox.py b/src/buildstream/sandbox/sandbox.py index 592866dac..031968826 100644 --- a/src/buildstream/sandbox/sandbox.py +++ b/src/buildstream/sandbox/sandbox.py @@ -35,7 +35,7 @@ import contextlib from contextlib import contextmanager from typing import Dict, Generator, List, Optional, TYPE_CHECKING -from .._exceptions import ImplError, BstError, SandboxError +from .._exceptions import ImplError, SandboxError from .._message import Message, MessageType from ..storage.directory import Directory from ..storage._casbaseddirectory import CasBasedDirectory -- cgit v1.2.1