From ceeca58f96bea79d8163433adec1591de33cfa98 Mon Sep 17 00:00:00 2001
From: Tristan van Berkom <tristan@codethink.co.uk>
Date: Tue, 27 Oct 2020 17:08:39 +0900
Subject: _loader/loader.py: Avoid double dictionary lookup

Use try / except KeyError instead.
---
 src/buildstream/_loader/loader.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/buildstream/_loader/loader.py b/src/buildstream/_loader/loader.py
index c260eefe5..90b7fbe50 100644
--- a/src/buildstream/_loader/loader.py
+++ b/src/buildstream/_loader/loader.py
@@ -854,9 +854,9 @@ class Loader:
 
         # If the element is already loaded in the target loader, then there
         # is no need for a shallow load.
-        if element_name in target_loader._elements:
+        try:
             element = target_loader._elements[element_name]
-        else:
+        except KeyError:
             # Shallow load the the element.
             element = target_loader._load_file_no_deps(element_name, provenance_node)
 
-- 
cgit v1.2.1