From c01f0df533e6dbf5aae63f8753ed8e6e2f88359d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=B6k=C3=A7en=20Nurlu?= Date: Fri, 1 Jun 2018 11:32:20 +0100 Subject: _sandboxbwrap.py: Fix post-bwrap cleanup behaviour The cleanup was supposed not to remove folders (`/dev`, `/tmp`, `/proc`) if they already existed before bwrap but it did the opposite: it tried to remove them if they existed before, and didn't remove them if they were created during bwrap. This was caused by a `not` clause, and this removes it. Fixes #379 --- buildstream/sandbox/_sandboxbwrap.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildstream/sandbox/_sandboxbwrap.py b/buildstream/sandbox/_sandboxbwrap.py index d18cb9ec0..798bcb690 100644 --- a/buildstream/sandbox/_sandboxbwrap.py +++ b/buildstream/sandbox/_sandboxbwrap.py @@ -207,7 +207,7 @@ class SandboxBwrap(Sandbox): # Skip removal of directories which already existed before # launching bwrap - if not existing_basedirs[basedir]: + if existing_basedirs[basedir]: continue base_directory = os.path.join(root_mount_source, basedir) -- cgit v1.2.1