From b1b9d60b85ca0b6af06a1faac3a4380da372883c Mon Sep 17 00:00:00 2001 From: James Ennis Date: Mon, 12 Aug 2019 17:44:16 +0100 Subject: _stream.py: Remove FIXME --- src/buildstream/_stream.py | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/buildstream/_stream.py b/src/buildstream/_stream.py index 36610434b..41a90f8ea 100644 --- a/src/buildstream/_stream.py +++ b/src/buildstream/_stream.py @@ -469,20 +469,6 @@ class Stream(): self._message(MessageType.INFO, "Attempting to fetch missing artifact buildtrees") self._add_queue(PullQueue(self._scheduler)) self._enqueue_plan(require_buildtrees) - else: - # FIXME: This hack should be removed as a result of refactoring - # Element._update_state() - # - # This workaround marks all dependencies of all selected elements as - # "pulled" before trying to push. - # - # Instead of lying to the elements and telling them they have already - # been pulled, we should have something more consistent with how other - # state bits are handled; and explicitly tell the elements that they - # need to be pulled with something like Element._schedule_pull(). - # - for element in elements: - element._pull_done() self._scheduler.clear_queues() push_queue = ArtifactPushQueue(self._scheduler) -- cgit v1.2.1