From 6e3e5bf59887712f845b317a4977dd206c7888c4 Mon Sep 17 00:00:00 2001 From: Tom Pollard Date: Fri, 12 Apr 2019 10:50:33 +0100 Subject: element.py: Remove redundant fully private __cached_success() This was being accessed via a local private method that wasn't augmenting the output as such it can be moved to match _cached_failure. --- buildstream/element.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/buildstream/element.py b/buildstream/element.py index 17cc9548c..7a573c7c9 100644 --- a/buildstream/element.py +++ b/buildstream/element.py @@ -1080,7 +1080,11 @@ class Element(Plugin): # the artifact cache and the element assembled successfully # def _cached_success(self): - return self.__cached_success() + if not self._cached(): + return False + + success, _, _ = self._get_build_result() + return success # _cached_failure(): # @@ -2896,13 +2900,6 @@ class Element(Plugin): self.__build_result = self.__artifact.load_build_result() - def __cached_success(self): - if not self._cached(): - return False - - success, _, _ = self._get_build_result() - return success - def __get_cache_keys_for_commit(self): keys = [] -- cgit v1.2.1