From 48456242b0a3067c0aa6a551c4a0c5972baf27c4 Mon Sep 17 00:00:00 2001 From: Benjamin Schubert Date: Sun, 10 Mar 2019 15:35:52 +0000 Subject: tests:lint: Raise exception instead of using 'assert False' for errors This fixes a inconsistent-return-statements from pylint and makes it easier to understand what is happening --- tests/internals/yaml.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/internals/yaml.py b/tests/internals/yaml.py index 5c1383a25..c505fbd20 100644 --- a/tests/internals/yaml.py +++ b/tests/internals/yaml.py @@ -166,7 +166,9 @@ def load_yaml_file(filename, *, cache_path, shortname=None, from_cache='raw'): _yaml.load(filename, shortname, yaml_cache=yc) return _yaml.load(filename, shortname, yaml_cache=yc) else: - assert False + raise Exception( + "Invalid value for parameter 'from_cache', Expected 'raw' or 'cached'" + ) # Tests for list composition -- cgit v1.2.1