From 468dac5a97e9fc8f4863e01dd692ffc7f2eff4c3 Mon Sep 17 00:00:00 2001 From: Benjamin Schubert Date: Fri, 8 Nov 2019 12:29:19 +0000 Subject: scheduler.py: Remove FIXME message and add explanation instead --- src/buildstream/_scheduler/scheduler.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/buildstream/_scheduler/scheduler.py b/src/buildstream/_scheduler/scheduler.py index 78af639fa..ede8e60f2 100644 --- a/src/buildstream/_scheduler/scheduler.py +++ b/src/buildstream/_scheduler/scheduler.py @@ -478,11 +478,9 @@ class Scheduler(): # def _interrupt_event(self): - # FIXME: This should not be needed, but for some reason we receive an - # additional SIGINT event when the user hits ^C a second time - # to inform us that they really intend to terminate; even though - # we have disconnected our handlers at this time. - # + # The event loop receives a copy of all signals that are sent while it is running + # This means that even though we catch the SIGINT in the question to the user, + # the loop will receive it too, and thus we need to skip it here. if self.terminated: return -- cgit v1.2.1