From 228c41bf68122e791a19f7f37d87a31e0cf440d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrg=20Billeter?= Date: Wed, 17 Oct 2018 17:08:44 +0100 Subject: _artifactcache: Rename update_atime() to update_mtime() os.utime() updates both, however, list_artifacts() sorts refs by mtime, i.e., atime is irrelevant. --- buildstream/_artifactcache/artifactcache.py | 12 ++++++------ buildstream/_artifactcache/cascache.py | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/buildstream/_artifactcache/artifactcache.py b/buildstream/_artifactcache/artifactcache.py index 48fd32218..728819e81 100644 --- a/buildstream/_artifactcache/artifactcache.py +++ b/buildstream/_artifactcache/artifactcache.py @@ -256,7 +256,7 @@ class ArtifactCache(): self._required_elements.update(elements) # For the cache keys which were resolved so far, we bump - # the atime of them. + # the mtime of them. # # This is just in case we have concurrent instances of # BuildStream running with the same artifact cache, it will @@ -268,7 +268,7 @@ class ArtifactCache(): for key in (strong_key, weak_key): if key: try: - self.update_atime(key) + self.update_mtime(key) except ArtifactError: pass @@ -478,15 +478,15 @@ class ArtifactCache(): def preflight(self): pass - # update_atime() + # update_mtime() # - # Update the atime of an artifact. + # Update the mtime of an artifact. # # Args: # key (str): The key of the artifact. # - def update_atime(self, key): - raise ImplError("Cache '{kind}' does not implement contains()" + def update_mtime(self, key): + raise ImplError("Cache '{kind}' does not implement update_mtime()" .format(kind=type(self).__name__)) # initialize_remotes(): diff --git a/buildstream/_artifactcache/cascache.py b/buildstream/_artifactcache/cascache.py index 4f0d10da5..c1fc90bb6 100644 --- a/buildstream/_artifactcache/cascache.py +++ b/buildstream/_artifactcache/cascache.py @@ -513,7 +513,7 @@ class CASCache(ArtifactCache): except FileNotFoundError as e: raise ArtifactError("Attempt to access unavailable artifact: {}".format(e)) from e - def update_atime(self, ref): + def update_mtime(self, ref): try: os.utime(self._refpath(ref)) except FileNotFoundError as e: -- cgit v1.2.1