From 1b65a23b852345b63a61bb4d0e5fc8a86bcec31a Mon Sep 17 00:00:00 2001 From: Tristan van Berkom Date: Mon, 10 Aug 2020 13:17:59 +0900 Subject: element/source: Remove pointless extra variable These __meta_kind members are documented as relevant for pickling, which was removed a short while ago. --- src/buildstream/element.py | 1 - src/buildstream/source.py | 1 - 2 files changed, 2 deletions(-) diff --git a/src/buildstream/element.py b/src/buildstream/element.py index dbbc7bf93..d1d11c4c1 100644 --- a/src/buildstream/element.py +++ b/src/buildstream/element.py @@ -255,7 +255,6 @@ class Element(Plugin): # Artifact class for direct artifact composite interaction self.__artifact = None # type: Optional[Artifact] self.__strict_artifact = None # Artifact for strict cache key - self.__meta_kind = meta.kind # The kind of this source, required for unpickling self.__batch_prepare_assemble = False # Whether batching across prepare()/assemble() is configured self.__batch_prepare_assemble_flags = 0 # Sandbox flags for batching across prepare()/assemble() diff --git a/src/buildstream/source.py b/src/buildstream/source.py index 4c284a57c..dc87c35de 100644 --- a/src/buildstream/source.py +++ b/src/buildstream/source.py @@ -342,7 +342,6 @@ class Source(Plugin): self.__element_index = meta.element_index # The index of the source in the owning element's source list self.__element_kind = meta.element_kind # The kind of the element owning this source self.__directory = meta.directory # Staging relative directory - self.__meta_kind = meta.kind # The kind of this source, required for unpickling self.__variables = variables # The variables used to resolve the source's config self.__key = None # Cache key for source -- cgit v1.2.1