From 18b60dbb9999ff5b96f8791eecfd720dcdd8a610 Mon Sep 17 00:00:00 2001 From: Tristan Van Berkom Date: Mon, 2 Apr 2018 20:17:54 +0900 Subject: tests/frontend/workspace.py: Reduce unneeded coverage here. Here we are overly testing the same functionality which does not require source specific support, e.g. lets not test resetting of workspaces for every kind of repo, since we already test opening and closing of workspaces for every repo kind, this is redundant and slowing down tests. --- tests/frontend/workspace.py | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tests/frontend/workspace.py b/tests/frontend/workspace.py index 494b053d5..db3db3e13 100644 --- a/tests/frontend/workspace.py +++ b/tests/frontend/workspace.py @@ -78,7 +78,7 @@ def test_open(cli, tmpdir, datafiles, kind): @pytest.mark.datafiles(DATA_DIR) -def test_open_bzr(cli, tmpdir, datafiles): +def test_open_bzr_customize(cli, tmpdir, datafiles): element_name, project, workspace = open_workspace(cli, tmpdir, datafiles, "bzr", False) # Check that the .bzr dir exists @@ -117,9 +117,8 @@ def test_close(cli, tmpdir, datafiles, kind): @pytest.mark.datafiles(DATA_DIR) -@pytest.mark.parametrize("kind", repo_kinds) -def test_close_removed(cli, tmpdir, datafiles, kind): - element_name, project, workspace = open_workspace(cli, tmpdir, datafiles, kind, False) +def test_close_removed(cli, tmpdir, datafiles): + element_name, project, workspace = open_workspace(cli, tmpdir, datafiles, 'git', False) # Remove it first, closing the workspace should work shutil.rmtree(workspace) @@ -155,10 +154,9 @@ def test_close_nonexistant_element(cli, tmpdir, datafiles): @pytest.mark.datafiles(DATA_DIR) -@pytest.mark.parametrize("kind", repo_kinds) -def test_reset(cli, tmpdir, datafiles, kind): +def test_reset(cli, tmpdir, datafiles): # Open the workspace - element_name, project, workspace = open_workspace(cli, tmpdir, datafiles, kind, False) + element_name, project, workspace = open_workspace(cli, tmpdir, datafiles, 'git', False) # Modify workspace shutil.rmtree(os.path.join(workspace, 'usr', 'bin')) @@ -177,9 +175,8 @@ def test_reset(cli, tmpdir, datafiles, kind): @pytest.mark.datafiles(DATA_DIR) -@pytest.mark.parametrize("kind", repo_kinds) -def test_list(cli, tmpdir, datafiles, kind): - element_name, project, workspace = open_workspace(cli, tmpdir, datafiles, kind, False) +def test_list(cli, tmpdir, datafiles): + element_name, project, workspace = open_workspace(cli, tmpdir, datafiles, 'git', False) # Now list the workspaces result = cli.run(project=project, args=[ -- cgit v1.2.1