From 512c726e5996ccf979fd06a6e90fea65458a6225 Mon Sep 17 00:00:00 2001 From: Tristan Van Berkom Date: Mon, 7 Jan 2019 22:38:11 -0500 Subject: sandbox/sandbox.py: Fix regression of command logging Since we added batch commands, the batch commands print the text of the commands directly in the message text, but this is wrong. The detail string is the appropriate place for text of unknown lengths (the user can actually configure how many max lines of commands they want to see in their log), the message text itself should be controlled and brief enough to avoid text wrapping. --- buildstream/sandbox/sandbox.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildstream/sandbox/sandbox.py b/buildstream/sandbox/sandbox.py index f16772cce..617ebf5f5 100644 --- a/buildstream/sandbox/sandbox.py +++ b/buildstream/sandbox/sandbox.py @@ -592,7 +592,7 @@ class _SandboxBatch(): if command.label: context = self.sandbox._get_context() message = Message(self.sandbox._get_plugin_id(), MessageType.STATUS, - 'Running {}'.format(command.label)) + 'Running command', detail=command.label) context.message(message) exitcode = self.sandbox._run(command.command, self.flags, cwd=command.cwd, env=command.env) -- cgit v1.2.1