summaryrefslogtreecommitdiff
path: root/src/buildstream/plugins/sources/pip.py
diff options
context:
space:
mode:
authorBenjamin Schubert <ben.c.schubert@gmail.com>2019-07-16 18:31:19 +0100
committerBenjamin Schubert <ben.c.schubert@gmail.com>2019-07-16 18:32:48 +0100
commitf2ece705b7bf36d7d923264af2b1f51b66a9f9a7 (patch)
tree7df4a79b12013f6094371e86bcf52bb6aa8719e7 /src/buildstream/plugins/sources/pip.py
parentfbb8eea8334023e30c8719cb52f9b0e226b4eb8b (diff)
downloadbuildstream-bschubert/api-improvements.tar.gz
node: Add 'get_str_list' on 'MappingNode'bschubert/api-improvements
`mapping.get_sequence(...).as_str_list()` is a very common pattern seen both in plugins and the core. Adding a helper to reduce the number of operations will make usage smoother
Diffstat (limited to 'src/buildstream/plugins/sources/pip.py')
-rw-r--r--src/buildstream/plugins/sources/pip.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/buildstream/plugins/sources/pip.py b/src/buildstream/plugins/sources/pip.py
index 78c11fd89..40ddf8c68 100644
--- a/src/buildstream/plugins/sources/pip.py
+++ b/src/buildstream/plugins/sources/pip.py
@@ -114,8 +114,8 @@ class PipSource(Source):
self.ref = node.get_str('ref', None)
self.original_url = node.get_str('url', _PYPI_INDEX_URL)
self.index_url = self.translate_url(self.original_url)
- self.packages = node.get_sequence('packages', []).as_str_list()
- self.requirements_files = node.get_sequence('requirements-files', []).as_str_list()
+ self.packages = node.get_str_list('packages', [])
+ self.requirements_files = node.get_str_list('requirements-files', [])
if not (self.packages or self.requirements_files):
raise SourceError("{}: Either 'packages' or 'requirements-files' must be specified". format(self))