delta/buildstream.git/tests/testutils/python_repo.py, branch remove-dead-code gitlab.com: buildstream/buildstream.git tests/testutils/python_repo.py: Use subprocess to run sdist 2019-01-18T21:23:05+00:00 Tristan Van Berkom tristan.vanberkom@codethink.co.uk 2019-01-18T21:23:05+00:00 adfb929141903129708fe05189303d72116e82fa The current approach using setuptools.sandbox.run_setup() was causing a spurious (but highly frequent) failure where setuptools gets mixed up with it's manipulation of sys.modules and hits a RuntimeError as a dictionary changes size while being iterated over. For instance: https://gitlab.com/BuildStream/buildstream/-/jobs/147967307 Since this already happens in an isolated virtual environment created by tox, we should not need additional sandboxing here from setuptools, and launching this as a subprocess will be safer. 
The current approach using setuptools.sandbox.run_setup() was
causing a spurious (but highly frequent) failure where setuptools
gets mixed up with it's manipulation of sys.modules and hits a
RuntimeError as a dictionary changes size while being iterated over.

For instance: https://gitlab.com/BuildStream/buildstream/-/jobs/147967307

Since this already happens in an isolated virtual environment created
by tox, we should not need additional sandboxing here from setuptools,
and launching this as a subprocess will be safer.
plugins/sources/pip.py: Accomodate characters '-','.','_' for packages 2018-11-02T16:41:54+00:00 ctolentino8 ctolentino8@bloomberg.net 2018-09-24T09:32:45+00:00 de59ebdbf755ca65c7c9d389204f6ce508f84e7e